Passed
Push — master ( f70f67...05b81b )
by Andreas
28:08
created
lib/org/openpsa/slideshow/handler/edit.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
         $images = $qb->execute();
62 62
         $failed = 0;
63 63
         foreach ($images as $image) {
64
-            if (   !$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
64
+            if (!$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
65 65
                 || !$image->generate_image('image', $this->_config->get('image_filter'))) {
66 66
                 $failed++;
67 67
             }
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
         $attachment->title = $title;
242 242
         $attachment->mimetype = $file->getMimeType();
243 243
         $attachment->parentguid = $image->guid;
244
-        if (   !$attachment->create()
244
+        if (!$attachment->create()
245 245
             || !$attachment->copy_from_file($file->getRealPath())) {
246 246
             throw new midcom_error('Failed to create attachment: ' . midcom_connection::get_error_string());
247 247
         }
Please login to merge, or discard this patch.
lib/midcom/helper/nav/main.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
         while ($parent = $object->get_parent()) {
341 341
             // Verify that this topic is within the current sites tree, if it is not,
342 342
             // we ignore it.
343
-            if (   $parent instanceof midcom_db_topic
343
+            if ($parent instanceof midcom_db_topic
344 344
                 && $this->is_node_in_tree($parent->id, $this->get_root_node())) {
345 345
                 return $parent;
346 346
             }
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
                     $entry = "<span class=\"{$current_class}\">{$entry}</span>";
395 395
                 }
396 396
             } else {
397
-                if (   !empty($data['napobject'][MIDCOM_NAV_GUID])
397
+                if (!empty($data['napobject'][MIDCOM_NAV_GUID])
398 398
                     && in_array($data['napobject'][MIDCOM_NAV_GUID], $skip_guids)) {
399 399
                     continue;
400 400
                 }
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
                     $id = "custom-{$key}";
509 509
 
510 510
                     $url = "{$prefix}{$entry[MIDCOM_NAV_URL]}";
511
-                    if (   str_starts_with($entry[MIDCOM_NAV_URL], '/')
511
+                    if (str_starts_with($entry[MIDCOM_NAV_URL], '/')
512 512
                         || preg_match('|^https?://|', $entry[MIDCOM_NAV_URL])) {
513 513
                         $url = $entry[MIDCOM_NAV_URL];
514 514
                     }
Please login to merge, or discard this patch.
lib/org/openpsa/products/viewer.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,11 +30,11 @@
 block discarded – undo
30 30
         $object = $dm->get_storage()->get_value();
31 31
 
32 32
         $document = $indexer->new_document($dm);
33
-        if (   $config->get('enable_scheduling')
33
+        if ($config->get('enable_scheduling')
34 34
             && $object instanceof org_openpsa_products_product_dba) {
35 35
             // Check start/end for products
36
-            if (   $object->start > time()
37
-                || (   $object->end != 0
36
+            if ($object->start > time()
37
+                || ($object->end != 0
38 38
                     && $object->end < time())) {
39 39
                 // Not in market, remove from index
40 40
                 $indexer->delete($document->RI);
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/permissions.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         $tmp = $this->_object;
83 83
 
84 84
         $i = 0;
85
-        while (   !empty($tmp->guid)
85
+        while (!empty($tmp->guid)
86 86
                && !($tmp instanceof midcom_db_topic)
87 87
                && $i < 100) {
88 88
             // Get the parent; wishing eventually to get a topic
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 
128 128
         $assignees = $this->load_assignees();
129 129
         $this->process_assignees($assignees, $schemadb);
130
-        $assignee_field =& $schemadb->get('privileges')->get_field('add_assignee');
130
+        $assignee_field = & $schemadb->get('privileges')->get_field('add_assignee');
131 131
 
132 132
         if (!$this->additional_assignee) {
133 133
             // Populate additional assignee selector
Please login to merge, or discard this patch.
lib/midcom/helper/imagepopup/handler/upload.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
         $temp = $request->files->get('file');
24 24
 
25 25
         // Verify file extension
26
-        if (   !$temp instanceof UploadedFile
26
+        if (!$temp instanceof UploadedFile
27 27
             || !in_array(strtolower($temp->getClientOriginalExtension()), ["gif", "jpg", "png"])) {
28 28
             throw new midcom_error('Invalid extension.');
29 29
         }
Please login to merge, or discard this patch.
src/midcom/datamanager/indexer/document.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
                     if (!empty($field->vars['value'])) {
172 172
                         //only index the first attachment for now
173 173
                         $attachment = array_shift($field->vars['value']);
174
-                        if (   !$attachment instanceof \midcom_db_attachment
174
+                        if (!$attachment instanceof \midcom_db_attachment
175 175
                             && !empty($attachment['object'])) {
176 176
                             //This is the form edit case
177 177
                             //@todo: In create case, nothing is found currently
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/importer/csv.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,11 +55,11 @@
 block discarded – undo
55 55
         foreach (array_filter($csv_line) as $field => $value) {
56 56
             // Process the row accordingly
57 57
             $field_matching = $this->_settings['fields'][$field];
58
-            if (   $field_matching
58
+            if ($field_matching
59 59
                 && str_contains($field_matching, ':')) {
60 60
                 [$schemadb, $schema_field] = explode(':', $field_matching);
61 61
 
62
-                if (   !array_key_exists($schemadb, $this->_schemadbs)
62
+                if (!array_key_exists($schemadb, $this->_schemadbs)
63 63
                     || !$this->_schemadbs[$schemadb]->get('default')->has_field($schema_field)) {
64 64
                     // Invalid matching, skip
65 65
                     continue;
Please login to merge, or discard this patch.
src/midcom/dba/parameters.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
             return false;
202 202
         }
203 203
 
204
-        if (   !$this->can_do('midgard:update')
204
+        if (!$this->can_do('midgard:update')
205 205
             || !$this->can_do('midgard:parameters')) {
206 206
             debug_add("Failed to set parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
207 207
                   MIDCOM_LOG_ERROR);
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
             return false;
246 246
         }
247 247
 
248
-        if (   !$this->can_do('midgard:update')
248
+        if (!$this->can_do('midgard:update')
249 249
             || !$this->can_do('midgard:parameters')) {
250 250
             debug_add("Failed to delete parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
251 251
                   MIDCOM_LOG_ERROR);
Please login to merge, or discard this patch.
src/midcom/dba/attachments.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
             return false;
52 52
         }
53 53
 
54
-        if (   !$this->can_do('midgard:update')
54
+        if (!$this->can_do('midgard:update')
55 55
             || !$this->can_do('midgard:attachments')) {
56 56
             debug_add("Failed to set parameters, midgard:update or midgard:attachments on " . static::class . " {$this->guid} not granted for the current user.",
57 57
             MIDCOM_LOG_ERROR);
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
             return null;
72 72
         }
73 73
 
74
-        if (   !$this->can_do('midgard:update')
74
+        if (!$this->can_do('midgard:update')
75 75
             || !$this->can_do('midgard:attachments')) {
76 76
             debug_add("Failed to set parameters, midgard:update or midgard:attachments on the " . static::class . " {$this->guid} not granted for the current user.",
77 77
             MIDCOM_LOG_ERROR);
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
         $attachment->parentguid = $this->guid;
86 86
 
87 87
         if (!$attachment->create()) {
88
-            debug_add("Could not create the attachment '{$name}' for " . static::class . " {$this->guid}: "  . midcom_connection::get_error_string(),
88
+            debug_add("Could not create the attachment '{$name}' for " . static::class . " {$this->guid}: " . midcom_connection::get_error_string(),
89 89
             MIDCOM_LOG_INFO);
90 90
             return null;
91 91
         }
Please login to merge, or discard this patch.