Passed
Push — master ( f70f67...05b81b )
by Andreas
28:08
created
src/midcom/datamanager/storage/image.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
             $this->save_attachment_list();
57 57
         }
58 58
 
59
-        if (   array_intersect_key(array_flip(['description', 'title', 'score']), $this->value)
59
+        if (array_intersect_key(array_flip(['description', 'title', 'score']), $this->value)
60 60
             && $main = $this->get_main()) {
61 61
             $needs_update = false;
62 62
             if (array_key_exists('description', $this->value)) {
Please login to merge, or discard this patch.
lib/midcom/core/collector.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
             if ($counter <= $this->_offset) {
143 143
                 continue;
144 144
             }
145
-            if (   $this->_limit
145
+            if ($this->_limit
146 146
                 && $counter > ($this->_offset + $this->_limit)) {
147 147
                 break;
148 148
             }
Please login to merge, or discard this patch.
lib/midcom/helper/reflector/tree.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
     private static function _check_permissions(bool $deleted) : bool
80 80
     {
81 81
         // PONDER: Check for some generic user privilege instead  ??
82
-        if (   $deleted
82
+        if ($deleted
83 83
             && !midcom::get()->auth->admin
84 84
             && !midcom::get()->auth->is_component_sudo()) {
85 85
             debug_add('Non-admins are not allowed to list deleted objects', MIDCOM_LOG_ERROR);
Please login to merge, or discard this patch.
lib/org/openpsa/sales/calculator/default.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
 
50 50
     private function get_units($units = false) : float
51 51
     {
52
-        if (   $this->deliverable->invoiceByActualUnits
52
+        if ($this->deliverable->invoiceByActualUnits
53 53
             || $this->deliverable->plannedUnits == 0) {
54 54
             // In most cases we calculate the price based on the actual units entered
55 55
             return $units ?: $this->deliverable->units;
Please login to merge, or discard this patch.
lib/org/openpsa/sales/salesproject/deliverable.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
     {
72 72
         $this->calculate_price(false);
73 73
 
74
-        if (   $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
74
+        if ($this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
75 75
             && $this->continuous) {
76 76
             $this->end = 0;
77 77
         } elseif ($this->end < $this->start) {
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
         $calculator->run($this);
139 139
         $cost = $calculator->get_cost();
140 140
         $price = $calculator->get_price();
141
-        if (   $price != $this->price
141
+        if ($price != $this->price
142 142
             || $cost != $this->cost) {
143 143
             $this->price = $price;
144 144
             $this->cost = $cost;
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
         $units = $hours['invoiceable'];
179 179
         $uninvoiceableUnits = $hours['reported'] - ($hours['invoiceable'] + $hours['invoiced']);
180 180
 
181
-        if (   $units != $this->units
181
+        if ($units != $this->units
182 182
             || $uninvoiceableUnits != $this->uninvoiceableUnits) {
183 183
             debug_add("agreement values have changed, setting units to " . $units . ", uninvoiceable: " . $uninvoiceableUnits);
184 184
             $this->units = $units;
@@ -229,11 +229,11 @@  discard block
 block discarded – undo
229 229
                 break;
230 230
             case 'q':
231 231
                 // Quarterly recurring subscription
232
-                $identifier = ceil(((int)$date->format('n')) / 4) . 'Q' . $date->format('y');
232
+                $identifier = ceil(((int) $date->format('n')) / 4) . 'Q' . $date->format('y');
233 233
                 break;
234 234
             case 'hy':
235 235
                 // Half-yearly recurring subscription
236
-                $identifier = ceil(((int)$date->format('n')) / 6) . '/' . $date->format('Y');
236
+                $identifier = ceil(((int) $date->format('n')) / 6) . '/' . $date->format('Y');
237 237
                 break;
238 238
             case 'y':
239 239
                 // Yearly recurring subscription
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
 
262 262
     public function invoice() : bool
263 263
     {
264
-        if (   $this->state >= self::STATE_INVOICED
264
+        if ($this->state >= self::STATE_INVOICED
265 265
             || $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
266 266
             return false;
267 267
         }
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
             midcom::get()->uimessages->add(midcom::get()->i18n->get_string('org.openpsa.sales', 'org.openpsa.sales'), sprintf(midcom::get()->i18n->get_string('marked deliverable "%s" delivered', 'org.openpsa.sales'), $this->title));
365 365
 
366 366
             // Check if we need to create task or ship goods
367
-            if (   $update_deliveries
367
+            if ($update_deliveries
368 368
                 && $product->orgOpenpsaObtype === org_openpsa_products_product_dba::TYPE_SERVICE) {
369 369
                 // Change status of tasks connected to the deliverable
370 370
                 $qb = org_openpsa_projects_task_dba::new_query_builder();
Please login to merge, or discard this patch.
lib/org/openpsa/documents/elFinderVolumeOpenpsa.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_MIME, '(' . $mime . ')');
68 68
         }
69 69
 
70
-        $tmpsize = (int)sprintf('%u', filesize($tmpname));
70
+        $tmpsize = (int) sprintf('%u', filesize($tmpname));
71 71
         if ($this->uploadMaxSize > 0 && $tmpsize > $this->uploadMaxSize) {
72 72
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_SIZE);
73 73
         }
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
         $output = [$object->get_label()];
251 251
 
252 252
         $parent = $object->get_parent();
253
-        while (   $parent
253
+        while ($parent
254 254
                && $parent->component == 'org.openpsa.documents') {
255 255
             $output[] = $parent->extra;
256 256
             $parent = $parent->get_parent();
@@ -347,12 +347,12 @@  discard block
 block discarded – undo
347 347
             $data['mime'] = 'directory';
348 348
         }
349 349
 
350
-        if (   $owner
350
+        if ($owner
351 351
             && $group = midcom::get()->auth->get_assignee($owner)) {
352 352
             $data['group'] = $group->name;
353 353
         }
354 354
 
355
-        if (   $this->root !== $path
355
+        if ($this->root !== $path
356 356
             && $parent = $object->get_parent()) {
357 357
             $data['phash'] = $this->encode($parent->guid);
358 358
         }
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
      * @param  string $mode open mode
412 412
      * @return resource|false
413 413
      */
414
-    protected function _fopen($path, $mode="rb")
414
+    protected function _fopen($path, $mode = "rb")
415 415
     {
416 416
         $document = org_openpsa_documents_document_dba::get_cached($path);
417 417
         $attachments = blobs::get_attachments($document, 'document');
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
      * @param  string    $path  file path
430 430
      * @return bool
431 431
      */
432
-    protected function _fclose($fp, $path='')
432
+    protected function _fclose($fp, $path = '')
433 433
     {
434 434
         fclose($fp);
435 435
         return true;
@@ -611,7 +611,7 @@  discard block
 block discarded – undo
611 611
     {
612 612
         $filename = midcom_db_attachment::safe_filename($name);
613 613
         $att = $doc->create_attachment($filename, $name, $mimetype);
614
-        if (   !$att
614
+        if (!$att
615 615
             || !$att->copy_from_handle($fp)) {
616 616
             return false;
617 617
         }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/schemaType.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -35,11 +35,11 @@  discard block
 block discarded – undo
35 35
         $resolver
36 36
             ->setRequired('schema')
37 37
             ->setAllowedTypes('schema', [schema::class, 'string'])
38
-            ->setDefault('action', function (Options $options, $value) {
38
+            ->setDefault('action', function(Options $options, $value) {
39 39
                 return $options['schema']->get('action');
40 40
             });
41 41
 
42
-        $resolver->setNormalizer('csrf_protection', function (Options $options, $value) {
42
+        $resolver->setNormalizer('csrf_protection', function(Options $options, $value) {
43 43
             foreach ($options['schema']->get('fields') as $config) {
44 44
                 if ($config['widget'] === 'csrf') {
45 45
                     return true;
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
             }
48 48
             return false;
49 49
         });
50
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
50
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
51 51
             $validation = $options['schema']->get('validation');
52 52
             if (!empty($validation)) {
53 53
                 $cb_wrapper = new cb_wrapper($validation);
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
             }
56 56
             return $value;
57 57
         });
58
-        $resolver->setNormalizer('schema', function (Options $options, $value) {
58
+        $resolver->setNormalizer('schema', function(Options $options, $value) {
59 59
             if (is_string($value)) {
60 60
                 $schemadb = schemadb::from_path($value);
61 61
                 return $schemadb->get_first();
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         // this is mainly there to skip validation in case the user pressed cancel
81 81
         $builder->addEventListener(FormEvents::POST_SUBMIT, function(PostSubmitEvent $event) {
82 82
             $form = $event->getForm();
83
-            if (   $form instanceof Form
83
+            if ($form instanceof Form
84 84
                 && $form->getClickedButton()
85 85
                 && $form->getClickedButton()->getConfig()->getOption('operation') == controller::CANCEL) {
86 86
                 $event->stopPropagation();
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/subformType.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
                 'max_count' => 0
39 39
             ]
40 40
         ]);
41
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
41
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
42 42
             $validation = [];
43 43
             if ($options['type_config']['max_count'] > 0) {
44 44
                 $validation['max'] = $options['type_config']['max_count'];
@@ -51,12 +51,12 @@  discard block
 block discarded – undo
51 51
             }
52 52
             return $validation;
53 53
         });
54
-        $resolver->setNormalizer('entry_options', function (Options $options, $value) {
54
+        $resolver->setNormalizer('entry_options', function(Options $options, $value) {
55 55
             return array_replace([
56 56
                 'widget_config' => $options['widget_config']
57 57
             ], (array) $value);
58 58
         });
59
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
59
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
60 60
             if (!array_key_exists('sortable', $value)) {
61 61
                 $value['sortable'] = false;
62 62
             }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/style/midgard_admin_asgard_rcs_history.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
                 echo "                    <td>" . $formatter->datetime($revision['date'], IntlDateFormatter::MEDIUM, IntlDateFormatter::LONG) . "</td>\n";
34 34
                 echo "                    <td>";
35 35
 
36
-                if (   $revision['user']
36
+                if ($revision['user']
37 37
                     && $user = midcom::get()->auth->get_user($revision['user'])) {
38 38
                     echo $user->get_storage()->name;
39 39
                 } elseif ($revision['ip']) {
Please login to merge, or discard this patch.