flack / openpsa

lib/midcom/services/rcs/handler.php

Spacing +3 added lines, -3 removed lines

@@ -48,7 +48,7 @@ 
     {
         $this->object = midcom::get()->dbfactory->get_object_by_guid($guid);
 
-        if (   !midcom::get()->config->get('midcom_services_rcs_enable')
+        if (!midcom::get()->config->get('midcom_services_rcs_enable')
             || !$this->object->_use_rcs) {
             throw new midcom_error_notfound("Revision control not supported for " . get_class($this->object) . ".");
         }
@@ -262,7 +262,7 @@ 
             throw new midcom_error_notfound("Revision {$args[1]} does not exist.");
         }
 
-        $data['preview'] = array_filter($this->backend->get_revision($revision), function ($value, $key) {
+        $data['preview'] = array_filter($this->backend->get_revision($revision), function($value, $key) {
             return !is_array($value)
                 && !in_array($value, ['', '0000-00-00'])
                 && midcom_services_rcs::is_field_showable($key);
@@ -292,7 +292,7 @@ 
         $this->object->require_do('midgard:update');
         // TODO: set another privilege for restoring?
 
-        if (   $this->backend->get_history()->version_exists($args[1])
+        if ($this->backend->get_history()->version_exists($args[1])
             && $this->backend->restore_to_revision($args[1])) {
             midcom::get()->uimessages->add($this->_l10n->get('midcom.admin.rcs'), sprintf($this->_l10n->get('restore to version %s successful'), $args[1]));
             return new midcom_response_relocate($this->get_object_url());

lib/midcom/admin/rcs/style/midcom-admin-rcs-history.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
         echo "                    <td><a href='" . $data['router']->generate('preview', ['guid' => $guid, 'revision' => $number]) . "'>{$revision['version']}</a></td>\n";
         echo "                    <td>" . $formatter->datetime($revision['date']) . "</td>\n";
 
-        if (   $revision['user']
+        if ($revision['user']
             && $user = midcom::get()->auth->get_user($revision['user'])) {
             $person_label = $user->get_storage()->name;
             echo "                    <td>{$person_label}</td>\n";

src/midcom/datamanager/template/plaintext.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
 
     public function form_widget_simple(FormView $view, array $data)
     {
-        if (   !empty($data['value'])
+        if (!empty($data['value'])
             || is_numeric($data['value'])) {
             return $data['value'];
         }

src/midcom/datamanager/template/view.php

Spacing +1 added lines, -1 removed lines

@@ -143,7 +143,7 @@
 
     public function form_widget_simple(FormView $view, array $data)
     {
-        if (   !empty($data['value'])
+        if (!empty($data['value'])
             || is_numeric($data['value'])) {
             return $this->escape($data['value']);
         }

lib/midcom/helper/toolbar/node.php

Spacing +3 added lines, -3 removed lines

@@ -57,7 +57,7 @@ 
         }
         $buttons = [];
         $workflow = new midcom\workflow\datamanager;
-        if (   $this->topic->can_do('midgard:update')
+        if ($this->topic->can_do('midgard:update')
             && $this->topic->can_do('midcom.admin.folder:topic_management')) {
             $buttons[] = $workflow->get_button("__ais/folder/edit/", [
                 MIDCOM_TOOLBAR_LABEL => midcom::get()->i18n->get_string('edit folder', 'midcom.admin.folder'),
@@ -91,7 +91,7 @@ 
             ];
         }
         $buttons = array_merge($buttons, $this->get_approval_controls($this->topic, false));
-        if (   $this->topic->can_do('midcom.admin.folder:template_management')
+        if ($this->topic->can_do('midcom.admin.folder:template_management')
             && midcom::get()->auth->can_user_do('midgard.admin.asgard:manage_objects', null, 'midgard_admin_asgard_plugin')) {
             $enabled = false;
             $styleeditor_url = '';
@@ -124,7 +124,7 @@ 
                     MIDCOM_TOOLBAR_ACCESSKEY => 'f',
                 ]);
             }
-            if (   $this->topic->guid !== midcom::get()->config->get('midcom_root_topic_guid')
+            if ($this->topic->guid !== midcom::get()->config->get('midcom_root_topic_guid')
                 && $this->topic->can_do('midgard:delete')) {
                 $workflow = new midcom\workflow\delete(['object' => $this->topic, 'recursive' => true]);
                 $buttons[] = $workflow->get_button("__ais/folder/delete/", [

lib/org/openpsa/directmarketing/sender/backend/email.php

Spacing +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
         $address = addslashes($address);
         return preg_replace_callback(
             '/href="(http:\/\/.*?)"/i',
-            function ($match) use ($address) {
+            function($match) use ($address) {
                 return 'href="' . str_replace("URL", rawurlencode($match[1]), $address) . '"';
             },
             $html);

lib/org/openpsa/sales/salesproject/deliverable.php

Spacing +4 added lines, -4 removed lines

@@ -81,7 +81,7 @@ 
     {
         $this->calculate_price(false);
 
-        if (   $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+        if ($this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
             && $this->continuous) {
             $this->end = 0;
         } elseif ($this->end < $this->start) {
@@ -169,7 +169,7 @@ 
         $calculator->run($this);
         $cost = $calculator->get_cost();
         $price = $calculator->get_price();
-        if (   $price != $this->price
+        if ($price != $this->price
             || $cost != $this->cost) {
             $this->price = $price;
             $this->cost = $cost;
@@ -216,7 +216,7 @@ 
         $units = $agreement_hours['invoiceable'];
         $uninvoiceableUnits = $agreement_hours['reported'] - ($agreement_hours['invoiceable'] + $agreement_hours['invoiced']);
 
-        if (   $units != $this->units
+        if ($units != $this->units
             || $uninvoiceableUnits != $this->uninvoiceableUnits) {
             debug_add("agreement values have changed, setting units to " . $units . ", uninvoiceable: " . $uninvoiceableUnits);
             $this->units = $units;
@@ -270,7 +270,7 @@ 
 
     public function invoice() : bool
     {
-        if (   $this->state >= self::STATE_INVOICED
+        if ($this->state >= self::STATE_INVOICED
             || $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
             return false;
         }

lib/midgard/admin/asgard/navigation.php

Spacing +13 added lines, -13 removed lines

@@ -43,7 +43,7 @@ 
         parent::__construct();
 
         $this->_object = $object;
-        $this->_request_data =& $request_data;
+        $this->_request_data = & $request_data;
 
         $this->root_types = midcom_helper_reflector_tree::get_root_classes();
 
@@ -59,7 +59,7 @@ 
             // we go through the path bottom up and show the first root type we find
             foreach (array_reverse($this->_object_path) as $node) {
                 foreach ($this->root_types as $root_type) {
-                    if (   is_a($node, $root_type)
+                    if (is_a($node, $root_type)
                         || midcom_helper_reflector::is_same_class($root_type, $node->__midcom_class_name__)) {
                         $this->expanded_root_types[] = $root_type;
                         break;
@@ -71,7 +71,7 @@ 
 
     protected function _is_collapsed(string $type, int $total) : bool
     {
-        return (   $total > $this->_config->get('max_navigation_entries')
+        return ($total > $this->_config->get('max_navigation_entries')
                 && empty($_GET['show_all_' . $type]));
     }
 
@@ -87,7 +87,7 @@ 
         foreach ($ref->get_child_classes() as $class) {
             $qb = $ref->_child_objects_type_qb($class, $object, false);
 
-            if (   !$qb
+            if (!$qb
                 || !($count = $qb->count_unchecked())) {
                 continue;
             }
@@ -133,7 +133,7 @@ 
     {
         $qb = $ref->_root_objects_qb();
 
-        if (   !$qb
+        if (!$qb
             || !($total = $qb->count_unchecked())) {
             return;
         }
@@ -211,7 +211,7 @@ 
         }
 
         echo "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/{$mode}/{$object->guid}/\" title=\"GUID: {$object->guid}, ID: {$object->id}\">{$icon}{$label}</a>\n";
-        if (   $selected
+        if ($selected
             || $autoexpand) {
             $this->_list_child_elements($object, $level + 1);
         }
@@ -231,7 +231,7 @@ 
                 continue;
             }
 
-            if (   method_exists($class, 'navigation')
+            if (method_exists($class, 'navigation')
                 && ($this->_request_data['plugin_name'] == "asgard_{$component}")) {
                 $this->_request_data['expanded'] = true;
                 midcom_show_style('midgard_admin_asgard_navigation_section_header');
@@ -265,13 +265,13 @@ 
         if ($this->_is_selected($object)) {
             $css_class .= ' selected';
         }
-        if (   is_object($this->_object)
-            && (   $object->guid == $this->_object->guid
-                || (   is_a($this->_object, midcom_db_parameter::class)
+        if (is_object($this->_object)
+            && ($object->guid == $this->_object->guid
+                || (is_a($this->_object, midcom_db_parameter::class)
                     && $object->guid == $this->_object->parentguid))) {
             $css_class .= ' current';
         }
-        if ( !$object->can_do('midgard:update')) {
+        if (!$object->can_do('midgard:update')) {
             $css_class .= ' readonly';
         }
         return $css_class;
@@ -314,7 +314,7 @@ 
 
         // If the regular expression has been set, check which types should be shown
         if ($regexp !== '//') {
-            $label_mapping = array_filter($label_mapping, function ($root_type) use ($regexp, $exclude) {
+            $label_mapping = array_filter($label_mapping, function($root_type) use ($regexp, $exclude) {
                 return preg_match($regexp, $root_type) == $exclude;
             }, ARRAY_FILTER_USE_KEY);
         }
@@ -344,7 +344,7 @@ 
          * click if nothing is expanded
          */
         $types_shown = false;
-        if (    !empty($expanded_types)
+        if (!empty($expanded_types)
              && midgard_admin_asgard_plugin::get_preference('navigation_type') === 'dropdown') {
             $this->_draw_select_navigation();
             $types_shown = true;

lib/midgard/admin/asgard/style/ASGARD_ROOT.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
 
                             $edited = (int) $view_metadata->get('revised');
                             $revision = $view_metadata->get('revision');
-                            if (   $revision > 1
+                            if ($revision > 1
                                 && $edited != $created) {
                                 try {
                                     $editor = new midcom_db_person($view_metadata->get('revisor'));