flack / openpsa

lib/org/openpsa/reports/handler/invoices/report.php

Spacing +5 added lines, -5 removed lines

@@ -64,7 +64,7 @@ 
 
     private function _get_invoices_for_subscription(org_openpsa_sales_salesproject_deliverable_dba $deliverable, midcom_services_at_entry_dba $at_entry) : array
     {
-        if (   $deliverable->invoiceByActualUnits
+        if ($deliverable->invoiceByActualUnits
             && $at_entry->arguments['cycle'] > 1) {
             $invoice_sum = $deliverable->invoiced / ($at_entry->arguments['cycle'] - 1);
             if ($invoice_sum == 0) {
@@ -80,8 +80,8 @@ 
         $time = $at_entry->start;
         $scheduler = new org_openpsa_invoices_scheduler($deliverable);
 
-        while (   $time < $this->_request_data['end']
-               && (   $time < $deliverable->end
+        while ($time < $this->_request_data['end']
+               && ($time < $deliverable->end
                    || $deliverable->continuous)) {
             $invoices[] = $this->get_invoice_for_deliverable($deliverable, $invoice_sum, $time, $calculation_base);
 
@@ -123,8 +123,8 @@ 
         foreach ($qb->execute() as $at_entry) {
             try {
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($at_entry->arguments['deliverable']);
-                if (   $deliverable->continuous
-                    || (   $deliverable->start < $this->_request_data['end']
+                if ($deliverable->continuous
+                    || ($deliverable->start < $this->_request_data['end']
                         && $deliverable->end > $this->_request_data['start'])) {
                     $invoices = array_merge($invoices, $this->_get_invoices_for_subscription($deliverable, $at_entry));
                 }

lib/org/openpsa/qbpager/main.php

Spacing +5 added lines, -5 removed lines

@@ -61,13 +61,13 @@ 
         $results_var = $this->_prefix . 'results';
         if (!empty($_REQUEST[$page_var])) {
             debug_add("{$page_var} has value: {$_REQUEST[$page_var]}");
-            $this->_current_page = (int)$_REQUEST[$page_var];
+            $this->_current_page = (int) $_REQUEST[$page_var];
         }
         if (!empty($_REQUEST[$results_var])) {
             debug_add("{$results_var} has value: {$_REQUEST[$results_var]}");
-            $this->results_per_page = (int)$_REQUEST[$results_var];
+            $this->results_per_page = (int) $_REQUEST[$results_var];
         }
-        $this->_offset = ($this->_current_page-1)*$this->results_per_page;
+        $this->_offset = ($this->_current_page - 1) * $this->results_per_page;
         if ($this->_offset < 0) {
             $this->_offset = 0;
         }
@@ -299,7 +299,7 @@ 
     public function count() : int
     {
         $this->_sanity_check();
-        if (   !$this->count
+        if (!$this->count
             || $this->_count_mode != 'count') {
             $this->count = $this->_midcom_qb_count->count();
         }
@@ -310,7 +310,7 @@ 
     public function count_unchecked() : int
     {
         $this->_sanity_check();
-        if (   !$this->count
+        if (!$this->count
             || $this->_count_mode != 'count_unchecked') {
             $this->count = $this->_midcom_qb_count->count_unchecked();
         }

lib/midcom/baseclasses/core/dbobject.php

Spacing +4 added lines, -4 removed lines

@@ -133,14 +133,14 @@ 
         if ($parent !== null) {
             // Attachments are a special case
             if ($object instanceof midcom_db_attachment) {
-                if (   !$parent->can_do('midgard:attachments')
+                if (!$parent->can_do('midgard:attachments')
                     || !$parent->can_do('midgard:update')) {
                     debug_add("Failed to create attachment, update or attachments privilege on the parent " . get_class($parent) . " {$parent->guid} not granted for the current user.",
                         MIDCOM_LOG_ERROR);
                     midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
                     return false;
                 }
-            } elseif (   !$parent->can_do('midgard:create')
+            } elseif (!$parent->can_do('midgard:create')
                       && !midcom::get()->auth->can_user_do('midgard:create', null, get_class($object))) {
                 debug_add("Failed to create object, create privilege on the parent " . get_class($parent) . " {$parent->guid} or the actual object class not granted for the current user.",
                     MIDCOM_LOG_ERROR);
@@ -263,7 +263,7 @@ 
             }
 
             // Default the owner to first group of current user
-            if (   empty($object->metadata->owner)
+            if (empty($object->metadata->owner)
                 && $first_group = midcom::get()->auth->user->get_first_group_guid()) {
                 $object->metadata->set('owner', $first_group);
             }
@@ -720,7 +720,7 @@ 
      */
     public static function get_by_guid(midcom_core_dbaobject $object, string $guid) : bool
     {
-        if (   !midcom::get()->auth->admin
+        if (!midcom::get()->auth->admin
             && !midcom::get()->auth->acl->can_do_byguid('midgard:read', $guid, get_class($object), midcom::get()->auth->acl->get_user_id())) {
             debug_add("Failed to load object, read privilege on the " . get_class($object) . " {$guid} not granted for the current user.", MIDCOM_LOG_ERROR);
             return false;

lib/net/nehmer/comments/handler/admin.php

Spacing +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
      */
     public function _handler_moderate_ajax(Request $request, string $status, array &$data)
     {
-        if (   !$request->request->has('action')
+        if (!$request->request->has('action')
             || !$request->request->has('guid')) {
             throw new midcom_error_notfound('Incomplete POST data');
         }

lib/org/openpsa/sales/handler/deliverable/add.php

Spacing +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
      */
     public function _handler_add(Request $request, string $guid, array &$data)
     {
-        if (   !$request->request->has('product')
+        if (!$request->request->has('product')
             && !$request->request->has('org_openpsa_sales')) {
             throw new midcom_error('No product specified, aborting.');
         }

lib/midcom/admin/folder/handler/approvals.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      */
     public function _handler_approval(Request $request, string $handler_id)
     {
-        if (   !$request->request->has('guid')
+        if (!$request->request->has('guid')
             || !$request->request->has('return_to')) {
             throw new midcom_error('Cannot process approval request, request is incomplete.');
         }

lib/midcom/helper/nav/backend.php

Spacing +2 added lines, -2 removed lines

@@ -279,7 +279,7 @@ 
             }
 
             $this->_leaves[$id] = $leaf;
-            $this->_loaded_leaves[$node->id][$id] =& $this->_leaves[$id];
+            $this->_loaded_leaves[$node->id][$id] = & $this->_leaves[$id];
         }
     }
 
@@ -337,7 +337,7 @@ 
                     continue;
                 }
 
-                if (   !$show_noentry
+                if (!$show_noentry
                     && self::$_nodes[$id]->noentry) {
                     // Hide "noentry" items
                     continue;

lib/org/openpsa/directmarketing/style/show-campaign.php

Spacing +2 added lines, -2 removed lines

@@ -50,14 +50,14 @@
     </div>
 
     <script type="text/javascript">
-    $('#<?php echo $grid->get_identifier();?>').on('click', 'td.delete i', function(event) {
+    $('#<?php echo $grid->get_identifier(); ?>').on('click', 'td.delete i', function(event) {
         var guid = $(event.target).data('person-guid'),
             member_guid = $(event.target).data('member-guid'),
             post_data = {org_openpsa_ajax_mode: 'unsubscribe', org_openpsa_ajax_person_guid: guid};
 
         $(event.target).removeClass('fa-trash').addClass('fa-spin fa-spinner');
         $.post('&(node[MIDCOM_NAV_ABSOLUTEURL]);campaign/unsubscribe/ajax/' + member_guid + '/', post_data, function() {
-            $('#<?php echo $grid->get_identifier();?>').trigger('reloadGrid');
+            $('#<?php echo $grid->get_identifier(); ?>').trigger('reloadGrid');
             $('#org_openpsa_widgets_contact-' + guid).fadeOut('fast', function() {
                 $('#org_openpsa_widgets_contact-' + guid).remove();
             });

src/midcom/datamanager/extension/type/urlnameType.php

Spacing +2 added lines, -2 removed lines

@@ -22,7 +22,7 @@ 
      */
     public function configureOptions(OptionsResolver $resolver)
     {
-        $resolver->setNormalizer('write_privilege', function (Options $options, $value) {
+        $resolver->setNormalizer('write_privilege', function(Options $options, $value) {
             return (array) $value + ['privilege' => 'midcom:urlname'];
         });
 
@@ -36,7 +36,7 @@ 
             ]
         ]);
 
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
             $validator_options = [
                 'allow_catenate' => $options['type_config']['allow_catenate'],
                 'allow_unclean' => $options['type_config']['allow_unclean'],