flack / openpsa

lib/net/nemein/tag/tag.php

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
 
     public function _on_creating()
     {
-        return (   $this->validate_tag($this->tag)
+        return ($this->validate_tag($this->tag)
                 && $this->_check_duplicates() == 0);
     }
 
@@ -69,7 +69,7 @@ 
 
     public function _on_updating()
     {
-        return (   $this->validate_tag($this->tag)
+        return ($this->validate_tag($this->tag)
                 && $this->_check_duplicates() == 0);
     }
 

lib/org/openpsa/directmarketing/campaign/ruleresolver.php

Spacing +2 added lines, -2 removed lines

@@ -279,7 +279,7 @@ 
      */
     private function add_misc_rule(array $rule, string $class, string $person_property) : bool
     {
-        $persons = [ 0 => -1];
+        $persons = [0 => -1];
         $match = $rule['match'];
         $constraint_match = "IN";
         if ($rule['match'] == '<>') {
@@ -351,7 +351,7 @@ 
         $ret = [];
 
         foreach ($object->get_properties() as $property) {
-            if (   $property[0] == '_'
+            if ($property[0] == '_'
                 || in_array($property, $skip_properties)) {
                 // Skip private or otherwise invalid properties
                 continue;

lib/midcom/helper/formatter.php

Spacing +2 added lines, -2 removed lines

@@ -50,12 +50,12 @@
      */
     public static function compile(string $content) : string
     {
-        return preg_replace_callback("%&\(([^)]*)\);%i", function ($variable)
+        return preg_replace_callback("%&\(([^)]*)\);%i", function($variable)
         {
             $parts = explode(':', $variable[1]);
             $variable = '$' . str_replace('.', '->', $parts[0]);
 
-            if (   isset($parts[1])
+            if (isset($parts[1])
                 && array_key_exists($parts[1], self::$_filters)) {
                 if ($parts[1] == 'p') {
                     $command = 'eval(\'?>\' . ' . $variable . ')';

lib/midcom/admin/folder/style/midcom-admin-folder-order-type.php

Spacing +2 added lines, -2 removed lines

@@ -4,7 +4,7 @@ 
 $count = count($data['navigation_items']);
 
 foreach ($data['navigation_items'] as $i => $item) {
-    if (   isset($item[MIDCOM_NAV_SORTABLE])
+    if (isset($item[MIDCOM_NAV_SORTABLE])
         && !$item[MIDCOM_NAV_SORTABLE]) {
         continue;
     }
@@ -15,7 +15,7 @@ 
     $style = '';
 
     // Skip all components that return the default icon
-    if (   isset($item[MIDCOM_NAV_COMPONENT])
+    if (isset($item[MIDCOM_NAV_COMPONENT])
         && ($tmp = midcom::get()->componentloader->get_component_icon($item[MIDCOM_NAV_COMPONENT], false))) {
         $icon = '<i class="fa fa-' . $tmp . '"></i>';
     } elseif (!$item[MIDCOM_NAV_GUID]) {

lib/org/openpsa/directmarketing/importer.php

Spacing +3 added lines, -3 removed lines

@@ -133,7 +133,7 @@ 
             // User is or has been subscriber earlier, update status
             $member = $members[0];
 
-            if (   $member->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED
+            if ($member->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED
                 || $member->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_member_dba::NORMAL) {
                 $this->_import_status['already_subscribed']++;
                 return;
@@ -173,7 +173,7 @@ 
 
             $qb = org_openpsa_contacts_group_dba::new_query_builder();
             $schema = $this->_schemadbs['organization']->get('default');
-            if (   $schema->has_field('company_id')
+            if ($schema->has_field('company_id')
                 && !empty($subscriber['organization']['company_id'])) {
                 // Imported data has a company id, we use that instead of name
                 $qb->add_constraint($schema->get_field('company_id')['storage']['location'], '=', $subscriber['organization']['company_id']);
@@ -181,7 +181,7 @@ 
                 // Seek by official name
                 $qb->add_constraint('official', '=', $subscriber['organization']['official']);
 
-                if (   $schema->has_field('city')
+                if ($schema->has_field('city')
                     && !empty($subscriber['organization']['city'])) {
                     // Imported data has a city, we use also that for matching
                     $qb->add_constraint($schema->get_field('city')['storage']['location'], '=', $subscriber['organization']['city']);

lib/org/openpsa/user/style/show-person-account.php

Spacing +4 added lines, -4 removed lines

@@ -11,7 +11,7 @@ 
             echo '<p>' . $data['l10n']->get('last login') . ': ' . $formatter->datetime($lastlogin) . "</p>\n";
         }
 
-        if (   $data['person']->guid == midcom::get()->auth->user->guid
+        if ($data['person']->guid == midcom::get()->auth->user->guid
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $workflow = new midcom\workflow\datamanager;
             echo '<ul class="area_toolbar">';
@@ -20,9 +20,9 @@ 
                 'object' => $data['person'],
                 'label' => $data['l10n']->get('account')
             ]);
-            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]). '" ' . $workflow->render_attributes() . '"  class="button">';
+            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]) . '" ' . $workflow->render_attributes() . '"  class="button">';
             echo '<span class="toolbar_label">' . $data['l10n_midcom']->get('delete') . '</span></a></li>';
-            if (    midcom::get()->config->get('auth_allow_trusted') === true
+            if (midcom::get()->config->get('auth_allow_trusted') === true
                  && $data['person']->can_do('org.openpsa.user:su')) {
                  echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '">' . $data['l10n']->get('switch to user') . "</a></li>\n";
             }
@@ -30,7 +30,7 @@ 
         }
     } else {
         echo '<p><span class="metadata">' . $data['l10n']->get("no account") . '</span></p>';
-        if (   $data['person']->guid == midcom::get()->auth->user->guid
+        if ($data['person']->guid == midcom::get()->auth->user->guid
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $workflow = new midcom\workflow\datamanager;
             echo '<ul class="area_toolbar">';

lib/org/openpsa/user/handler/person/view.php

Spacing +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@ 
         $this->add_breadcrumb('', $person->get_label());
 
         $auth = midcom::get()->auth;
-        if (   $person->guid == midcom::get()->auth->user->guid
+        if ($person->guid == midcom::get()->auth->user->guid
             || $auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $buttons = [];
             $workflow = $this->get_workflow('datamanager');
@@ -37,7 +37,7 @@ 
                 $delete_workflow = $this->get_workflow('delete', ['object' => $person]);
                 $buttons[] = $delete_workflow->get_button($this->router->generate('user_delete', ['guid' => $person->guid]));
             }
-            if (   midcom_connection::is_user($person)
+            if (midcom_connection::is_user($person)
                 && $person->can_do('midgard:privileges')) {
                 $buttons[] = $workflow->get_button($this->router->generate('user_privileges', ['guid' => $person->guid]), [
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get("permissions"),

lib/org/openpsa/contacts/handler/person/view.php

Spacing +3 added lines, -3 removed lines

@@ -105,7 +105,7 @@ 
         $invoices_url = $siteconfig->get_node_full_url('org.openpsa.invoices');
         $user_url = $siteconfig->get_node_full_url('org.openpsa.user');
 
-        if (   $invoices_url
+        if ($invoices_url
             && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)
             && $this->_contact->can_do('midgard:update')) {
             $buttons[] = $workflow->get_button($invoices_url . "billingdata/" . $this->_contact->guid . '/', [
@@ -114,8 +114,8 @@ 
             ]);
         }
 
-        if (   $user_url
-            && (   midcom::get()->auth->user->guid == $this->_contact->guid
+        if ($user_url
+            && (midcom::get()->auth->user->guid == $this->_contact->guid
                 || midcom::get()->auth->can_user_do('org.openpsa.user:access', null, org_openpsa_user_interface::class))) {
             $buttons[] = [
                 MIDCOM_TOOLBAR_URL => $user_url . "view/{$this->_contact->guid}/",

lib/midcom/services/cache/module/content.php

Spacing +5 added lines, -5 removed lines

@@ -171,8 +171,8 @@ 
         $this->_uncached = $config->get('cache_module_content_uncached');
         $this->_headers_strategy = $this->get_strategy('cache_module_content_headers_strategy');
         $this->_headers_strategy_authenticated = $this->get_strategy('cache_module_content_headers_strategy_authenticated');
-        $this->_default_lifetime = (int)$config->get('cache_module_content_default_lifetime');
-        $this->_default_lifetime_authenticated = (int)$config->get('cache_module_content_default_lifetime_authenticated');
+        $this->_default_lifetime = (int) $config->get('cache_module_content_default_lifetime');
+        $this->_default_lifetime_authenticated = (int) $config->get('cache_module_content_default_lifetime_authenticated');
 
         if ($this->_headers_strategy == 'no-cache') {
             // we can't call no_cache() here, because it would try to call back to this class via the global getter
@@ -455,7 +455,7 @@ 
      */
     public function expires(int $timestamp)
     {
-        if (   $this->_expires === null
+        if ($this->_expires === null
             || $this->_expires > $timestamp) {
             $this->_expires = $timestamp;
         }
@@ -567,7 +567,7 @@ 
      */
     public function write_meta_cache(string $content_id, Request $request, Response $response)
     {
-        if (   $this->_uncached
+        if ($this->_uncached
             || $this->_no_cache) {
             return;
         }
@@ -636,7 +636,7 @@ 
 
     public function store_dl_content(int $context, string $dl_cache_data, Request $request)
     {
-        if (   $this->_no_cache
+        if ($this->_no_cache
             || $this->_uncached) {
             return;
         }