Passed
Push — master ( 722134...8d9c6d )
by Andreas
12:20
created
lib/org/openpsa/documents/elFinderVolumeOpenpsa.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_MIME, '(' . $mime . ')');
68 68
         }
69 69
 
70
-        $tmpsize = (int)sprintf('%u', filesize($tmpname));
70
+        $tmpsize = (int) sprintf('%u', filesize($tmpname));
71 71
         if ($this->uploadMaxSize > 0 && $tmpsize > $this->uploadMaxSize) {
72 72
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_SIZE);
73 73
         }
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
         $output = [$object->get_label()];
251 251
 
252 252
         $parent = $object->get_parent();
253
-        while (   $parent
253
+        while ($parent
254 254
                && $parent->component == 'org.openpsa.documents') {
255 255
             $output[] = $parent->extra;
256 256
             $parent = $parent->get_parent();
@@ -347,12 +347,12 @@  discard block
 block discarded – undo
347 347
             $data['mime'] = 'directory';
348 348
         }
349 349
 
350
-        if (   $owner
350
+        if ($owner
351 351
             && $group = midcom::get()->auth->get_assignee($owner)) {
352 352
             $data['group'] = $group->name;
353 353
         }
354 354
 
355
-        if (   $this->root !== $path
355
+        if ($this->root !== $path
356 356
             && $parent = $object->get_parent()) {
357 357
             $data['phash'] = $this->encode($parent->guid);
358 358
         }
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
      * @param  string $mode open mode
412 412
      * @return resource|false
413 413
      */
414
-    protected function _fopen($path, $mode="rb")
414
+    protected function _fopen($path, $mode = "rb")
415 415
     {
416 416
         $document = org_openpsa_documents_document_dba::get_cached($path);
417 417
         $attachments = blobs::get_attachments($document, 'document');
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
      * @param  string    $path  file path
430 430
      * @return bool
431 431
      */
432
-    protected function _fclose($fp, $path='')
432
+    protected function _fclose($fp, $path = '')
433 433
     {
434 434
         fclose($fp);
435 435
         return true;
@@ -611,7 +611,7 @@  discard block
 block discarded – undo
611 611
     {
612 612
         $filename = midcom_db_attachment::safe_filename($name);
613 613
         $att = $doc->create_attachment($filename, $name, $mimetype);
614
-        if (   !$att
614
+        if (!$att
615 615
             || !$att->copy_from_handle($fp)) {
616 616
             return false;
617 617
         }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/schemaType.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -35,11 +35,11 @@  discard block
 block discarded – undo
35 35
         $resolver
36 36
             ->setRequired('schema')
37 37
             ->setAllowedTypes('schema', [schema::class, 'string'])
38
-            ->setDefault('action', function (Options $options, $value) {
38
+            ->setDefault('action', function(Options $options, $value) {
39 39
                 return $options['schema']->get('action');
40 40
             });
41 41
 
42
-        $resolver->setNormalizer('csrf_protection', function (Options $options, $value) {
42
+        $resolver->setNormalizer('csrf_protection', function(Options $options, $value) {
43 43
             foreach ($options['schema']->get('fields') as $config) {
44 44
                 if ($config['widget'] === 'csrf') {
45 45
                     return true;
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
             }
48 48
             return false;
49 49
         });
50
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
50
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
51 51
             $validation = $options['schema']->get('validation');
52 52
             if (!empty($validation)) {
53 53
                 $cb_wrapper = new cb_wrapper($validation);
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
             }
56 56
             return $value;
57 57
         });
58
-        $resolver->setNormalizer('schema', function (Options $options, $value) {
58
+        $resolver->setNormalizer('schema', function(Options $options, $value) {
59 59
             if (is_string($value)) {
60 60
                 $schemadb = schemadb::from_path($value);
61 61
                 return $schemadb->get_first();
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         // this is mainly there to skip validation in case the user pressed cancel
81 81
         $builder->addEventListener(FormEvents::POST_SUBMIT, function(PostSubmitEvent $event) {
82 82
             $form = $event->getForm();
83
-            if (   $form instanceof Form
83
+            if ($form instanceof Form
84 84
                 && $form->getClickedButton()
85 85
                 && $form->getClickedButton()->getConfig()->getOption('operation') == controller::CANCEL) {
86 86
                 $event->stopPropagation();
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/subformType.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
                 'max_count' => 0
39 39
             ]
40 40
         ]);
41
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
41
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
42 42
             $validation = [];
43 43
             if ($options['type_config']['max_count'] > 0) {
44 44
                 $validation['max'] = $options['type_config']['max_count'];
@@ -51,12 +51,12 @@  discard block
 block discarded – undo
51 51
             }
52 52
             return $validation;
53 53
         });
54
-        $resolver->setNormalizer('entry_options', function (Options $options, $value) {
54
+        $resolver->setNormalizer('entry_options', function(Options $options, $value) {
55 55
             return array_replace([
56 56
                 'widget_config' => $options['widget_config']
57 57
             ], (array) $value);
58 58
         });
59
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
59
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
60 60
             if (!array_key_exists('sortable', $value)) {
61 61
                 $value['sortable'] = false;
62 62
             }
Please login to merge, or discard this patch.
lib/org/openpsa/user/handler/person/privileges.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,9 +23,9 @@
 block discarded – undo
23 23
         $schemadb = schemadb::from_path($this->_config->get('schemadb_acl'));
24 24
 
25 25
         // Get the calendar root event
26
-        if (   class_exists('org_openpsa_calendar_interface')
26
+        if (class_exists('org_openpsa_calendar_interface')
27 27
             && $root_event = org_openpsa_calendar_interface::find_root_event()) {
28
-            $field =& $schemadb->get('default')->get_field('calendar');
28
+            $field = & $schemadb->get('default')->get_field('calendar');
29 29
             $field['type_config']['privilege_object'] = $root_event;
30 30
             $field['type_config']['assignee'] = 'user:' . $person->guid;
31 31
         }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/style/midgard_admin_asgard_rcs_history.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
                 echo "                    <td>" . $formatter->datetime($revision['date'], IntlDateFormatter::MEDIUM, IntlDateFormatter::LONG) . "</td>\n";
34 34
                 echo "                    <td>";
35 35
 
36
-                if (   $revision['user']
36
+                if ($revision['user']
37 37
                     && $user = midcom::get()->auth->get_user($revision['user'])) {
38 38
                     echo $user->get_storage()->name;
39 39
                 } elseif ($revision['ip']) {
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/message/compose.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         }
65 65
 
66 66
         //Substyle handling
67
-        if (   !empty($data['message_array']['substyle'])
67
+        if (!empty($data['message_array']['substyle'])
68 68
             && !str_starts_with($data['message_array']['substyle'], 'builtin:')) {
69 69
             debug_add("Appending substyle {$data['message_array']['substyle']}");
70 70
             midcom::get()->style->append_substyle($data['message_array']['substyle']);
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
     private function _real_show_compose(array $data)
114 114
     {
115 115
         $prefix = '';
116
-        if (   !empty($data['message_array']['substyle'])
116
+        if (!empty($data['message_array']['substyle'])
117 117
             && preg_match('/^builtin:(.*)/', $data['message_array']['substyle'], $matches_style)) {
118 118
             $prefix = $matches_style[1] . '-';
119 119
         }
Please login to merge, or discard this patch.
lib/org/openpsa/slideshow/handler/edit.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
         $images = $qb->execute();
62 62
         $failed = 0;
63 63
         foreach ($images as $image) {
64
-            if (   !$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
64
+            if (!$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
65 65
                 || !$image->generate_image('image', $this->_config->get('image_filter'))) {
66 66
                 $failed++;
67 67
             }
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
         $attachment->title = $title;
242 242
         $attachment->mimetype = $file->getMimeType();
243 243
         $attachment->parentguid = $image->guid;
244
-        if (   !$attachment->create()
244
+        if (!$attachment->create()
245 245
             || !$attachment->copy_from_file($file->getRealPath())) {
246 246
             throw new midcom_error('Failed to create attachment: ' . midcom_connection::get_error_string());
247 247
         }
Please login to merge, or discard this patch.
lib/midcom/helper/nav/main.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
         while ($parent = $object->get_parent()) {
341 341
             // Verify that this topic is within the current sites tree, if it is not,
342 342
             // we ignore it.
343
-            if (   $parent instanceof midcom_db_topic
343
+            if ($parent instanceof midcom_db_topic
344 344
                 && $this->is_node_in_tree($parent->id, $this->get_root_node())) {
345 345
                 return $parent;
346 346
             }
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
                     $entry = "<span class=\"{$current_class}\">{$entry}</span>";
395 395
                 }
396 396
             } else {
397
-                if (   !empty($data['napobject'][MIDCOM_NAV_GUID])
397
+                if (!empty($data['napobject'][MIDCOM_NAV_GUID])
398 398
                     && in_array($data['napobject'][MIDCOM_NAV_GUID], $skip_guids)) {
399 399
                     continue;
400 400
                 }
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
                     $id = "custom-{$key}";
509 509
 
510 510
                     $url = "{$prefix}{$entry[MIDCOM_NAV_URL]}";
511
-                    if (   str_starts_with($entry[MIDCOM_NAV_URL], '/')
511
+                    if (str_starts_with($entry[MIDCOM_NAV_URL], '/')
512 512
                         || preg_match('|^https?://|', $entry[MIDCOM_NAV_URL])) {
513 513
                         $url = $entry[MIDCOM_NAV_URL];
514 514
                     }
Please login to merge, or discard this patch.
lib/org/openpsa/products/viewer.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,11 +30,11 @@
 block discarded – undo
30 30
         $object = $dm->get_storage()->get_value();
31 31
 
32 32
         $document = $indexer->new_document($dm);
33
-        if (   $config->get('enable_scheduling')
33
+        if ($config->get('enable_scheduling')
34 34
             && $object instanceof org_openpsa_products_product_dba) {
35 35
             // Check start/end for products
36
-            if (   $object->start > time()
37
-                || (   $object->end != 0
36
+            if ($object->start > time()
37
+                || ($object->end != 0
38 38
                     && $object->end < time())) {
39 39
                 // Not in market, remove from index
40 40
                 $indexer->delete($document->RI);
Please login to merge, or discard this patch.