@@ -119,7 +119,7 @@ discard block |
||
119 | 119 | } |
120 | 120 | } |
121 | 121 | $profit = $value - $cost; |
122 | - if ( $this->value != $value |
|
122 | + if ($this->value != $value |
|
123 | 123 | || $this->profit != $profit) { |
124 | 124 | $this->value = $value; |
125 | 125 | $this->profit = $value - $cost; |
@@ -184,12 +184,12 @@ discard block |
||
184 | 184 | |
185 | 185 | public function _on_updating() : bool |
186 | 186 | { |
187 | - if ( $this->state != self::STATE_ACTIVE |
|
187 | + if ($this->state != self::STATE_ACTIVE |
|
188 | 188 | && !$this->end) { |
189 | 189 | //Not active anymore and end not set, set it to now |
190 | 190 | $this->end = time(); |
191 | 191 | } |
192 | - if ( $this->end |
|
192 | + if ($this->end |
|
193 | 193 | && $this->state == self::STATE_ACTIVE) { |
194 | 194 | //Returned to active state, clear the end marker. |
195 | 195 | $this->end = 0; |
@@ -40,7 +40,7 @@ discard block |
||
40 | 40 | |
41 | 41 | public function _on_creating() : bool |
42 | 42 | { |
43 | - return ( $this->validate_tag($this->tag) |
|
43 | + return ($this->validate_tag($this->tag) |
|
44 | 44 | && $this->_check_duplicates() == 0); |
45 | 45 | } |
46 | 46 | |
@@ -69,7 +69,7 @@ discard block |
||
69 | 69 | |
70 | 70 | public function _on_updating() : bool |
71 | 71 | { |
72 | - return ( $this->validate_tag($this->tag) |
|
72 | + return ($this->validate_tag($this->tag) |
|
73 | 73 | && $this->_check_duplicates() == 0); |
74 | 74 | } |
75 | 75 |
@@ -28,7 +28,7 @@ |
||
28 | 28 | |
29 | 29 | public function _on_creating() : bool |
30 | 30 | { |
31 | - if ( $this->title == '' |
|
31 | + if ($this->title == '' |
|
32 | 32 | || !$this->topic) { |
33 | 33 | // We must have wikiword and topic at this stage |
34 | 34 | return false; |
@@ -56,7 +56,7 @@ |
||
56 | 56 | $this->save_attachment_list(); |
57 | 57 | } |
58 | 58 | |
59 | - if ( array_intersect_key(array_flip(['description', 'title', 'score']), $this->value) |
|
59 | + if (array_intersect_key(array_flip(['description', 'title', 'score']), $this->value) |
|
60 | 60 | && $main = $this->get_main()) { |
61 | 61 | $needs_update = false; |
62 | 62 | if (array_key_exists('description', $this->value)) { |
@@ -163,8 +163,8 @@ discard block |
||
163 | 163 | $this->_uncached = $config->get('cache_module_content_uncached'); |
164 | 164 | $this->_headers_strategy = $this->get_strategy('cache_module_content_headers_strategy'); |
165 | 165 | $this->_headers_strategy_authenticated = $this->get_strategy('cache_module_content_headers_strategy_authenticated'); |
166 | - $this->_default_lifetime = (int)$config->get('cache_module_content_default_lifetime'); |
|
167 | - $this->_default_lifetime_authenticated = (int)$config->get('cache_module_content_default_lifetime_authenticated'); |
|
166 | + $this->_default_lifetime = (int) $config->get('cache_module_content_default_lifetime'); |
|
167 | + $this->_default_lifetime_authenticated = (int) $config->get('cache_module_content_default_lifetime_authenticated'); |
|
168 | 168 | |
169 | 169 | if ($this->_headers_strategy == 'no-cache') { |
170 | 170 | // we can't call no_cache() here, because it would try to call back to this class via the global getter |
@@ -531,7 +531,7 @@ discard block |
||
531 | 531 | */ |
532 | 532 | public function write_meta_cache(string $content_id, Request $request, Response $response) |
533 | 533 | { |
534 | - if ( $this->_uncached |
|
534 | + if ($this->_uncached |
|
535 | 535 | || $this->_no_cache) { |
536 | 536 | return; |
537 | 537 | } |
@@ -593,7 +593,7 @@ discard block |
||
593 | 593 | |
594 | 594 | public function store_dl_content(int $context, string $dl_cache_data, Request $request) |
595 | 595 | { |
596 | - if ( $this->_no_cache |
|
596 | + if ($this->_no_cache |
|
597 | 597 | || $this->_uncached) { |
598 | 598 | return; |
599 | 599 | } |
@@ -627,7 +627,7 @@ discard block |
||
627 | 627 | |
628 | 628 | /* TODO: Doublecheck the way this is handled, now we just don't send it |
629 | 629 | * if headers_strategy implies caching */ |
630 | - if ( !$response->headers->has('Content-Length') |
|
630 | + if (!$response->headers->has('Content-Length') |
|
631 | 631 | && !in_array($this->_headers_strategy, ['public', 'private'])) { |
632 | 632 | $response->headers->set("Content-Length", strlen($response->getContent())); |
633 | 633 | } |
@@ -142,7 +142,7 @@ |
||
142 | 142 | if ($counter <= $this->_offset) { |
143 | 143 | continue; |
144 | 144 | } |
145 | - if ( $this->_limit |
|
145 | + if ($this->_limit |
|
146 | 146 | && $counter > ($this->_offset + $this->_limit)) { |
147 | 147 | break; |
148 | 148 | } |
@@ -79,7 +79,7 @@ |
||
79 | 79 | private static function _check_permissions(bool $deleted) : bool |
80 | 80 | { |
81 | 81 | // PONDER: Check for some generic user privilege instead ?? |
82 | - if ( $deleted |
|
82 | + if ($deleted |
|
83 | 83 | && !midcom::get()->auth->admin |
84 | 84 | && !midcom::get()->auth->is_component_sudo()) { |
85 | 85 | debug_add('Non-admins are not allowed to list deleted objects', MIDCOM_LOG_ERROR); |
@@ -52,7 +52,7 @@ discard block |
||
52 | 52 | } |
53 | 53 | } |
54 | 54 | |
55 | - if ( empty($link->toComponent) |
|
55 | + if (empty($link->toComponent) |
|
56 | 56 | && !empty($link->fromComponent)) { |
57 | 57 | debug_add("Setting property 'toComponent' to '{$component}'"); |
58 | 58 | $link->toComponent = $component; |
@@ -61,7 +61,7 @@ discard block |
||
61 | 61 | $link->fromComponent = $component; |
62 | 62 | } |
63 | 63 | |
64 | - if ( empty($link->toGuid) |
|
64 | + if (empty($link->toGuid) |
|
65 | 65 | && !empty($link->fromGuid)) { |
66 | 66 | $link->toClass = get_class($obj); |
67 | 67 | $link->toGuid = $obj->guid; |
@@ -49,7 +49,7 @@ |
||
49 | 49 | |
50 | 50 | private function get_units($units = false) : float |
51 | 51 | { |
52 | - if ( $this->deliverable->invoiceByActualUnits |
|
52 | + if ($this->deliverable->invoiceByActualUnits |
|
53 | 53 | || $this->deliverable->plannedUnits == 0) { |
54 | 54 | // In most cases we calculate the price based on the actual units entered |
55 | 55 | return $units ?: $this->deliverable->units; |