flack / openpsa

lib/org/openpsa/projects/status.php

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
             $status_changer_label = $this->l10n->get('system');
             $target_person_label = $this->l10n->get('system');
 
-            if (    $status_change->metadata->creator
+            if ($status_change->metadata->creator
                  && $status_change->metadata->creator != $fallback_creator->guid) {
                 $status_changer = org_openpsa_widgets_contact::get($status_change->metadata->creator);
                 $status_changer_label = $status_changer->show_inline();

lib/org/openpsa/mypage/handler/workingon.php

Spacing +1 added lines, -1 removed lines

@@ -152,7 +152,7 @@
         // Set the "now working on" status
         $workingon = new org_openpsa_mypage_workingon();
         if (!$workingon->set($_POST['task'])) {
-            midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.mypage'),  'Failed to set "working on" parameter to "' . $_POST['task'] . '", reason ' . midcom_connection::get_error_string(), 'error');
+            midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.mypage'), 'Failed to set "working on" parameter to "' . $_POST['task'] . '", reason ' . midcom_connection::get_error_string(), 'error');
         }
 
         return new midcom_response_relocate($relocate . "workingon/");

Braces +2 added lines, -1 removed lines

@@ -92,7 +92,8 @@
                         $customer = new org_openpsa_contacts_group_dba($customer_id);
                         $customer_label = $customer->official;
                         $customer = $customer_id;
-                    } catch (midcom_error $e) {
+                    }
+                    catch (midcom_error $e) {
                     }
                 }
             }

lib/org/openpsa/sales/salesproject/deliverable.php

Spacing +4 added lines, -4 removed lines

@@ -54,7 +54,7 @@ 
     {
         $this->calculate_price(false);
 
-        if (   $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+        if ($this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
             && $this->continuous == true) {
             $this->end = 0;
         } elseif ($this->end < $this->start) {
@@ -140,7 +140,7 @@ 
         $calculator->run($this);
         $cost = $calculator->get_cost();
         $price = $calculator->get_price();
-        if (   $price != $this->price
+        if ($price != $this->price
             || $cost != $this->cost) {
             $this->price = $price;
             $this->cost = $cost;
@@ -187,7 +187,7 @@ 
         $units = $agreement_hours['invoiceable'];
         $uninvoiceableUnits = $agreement_hours['reported'] - ($agreement_hours['invoiceable'] + $agreement_hours['invoiced']);
 
-        if (   $units != $this->units
+        if ($units != $this->units
             || $uninvoiceableUnits != $this->uninvoiceableUnits) {
             debug_add("agreement values have changed, setting units to " . $units . ", uninvoiceable: " . $uninvoiceableUnits);
             $this->units = $units;
@@ -242,7 +242,7 @@ 
 
     public function invoice()
     {
-        if (   $this->state >= self::STATE_INVOICED
+        if ($this->state >= self::STATE_INVOICED
             || $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
             return false;
         }

lib/org/openpsa/sales/midcom/interfaces.php

Spacing +2 added lines, -2 removed lines

@@ -53,7 +53,7 @@ 
      */
     private function _find_suspects_event(midcom_core_dbaobject $object, $defaults, array &$links_array)
     {
-        if (   !is_array($object->participants)
+        if (!is_array($object->participants)
             || count($object->participants) < 2) {
             //We have invalid list or less than two participants, abort
             return;
@@ -144,7 +144,7 @@ 
      */
     public function new_subscription_cycle(array $args, midcom_baseclasses_components_cron_handler $handler)
     {
-        if (   !isset($args['deliverable'])
+        if (!isset($args['deliverable'])
             || !isset($args['cycle'])) {
             $handler->print_error('deliverable GUID or cycle number not set, aborting');
             return false;

Braces +6 added lines, -3 removed lines

@@ -134,7 +134,8 @@ 
 
         try {
             $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($args['deliverable']);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $handler->print_error("Deliverable {$args['deliverable']} not found: " . midcom_connection::get_error_string());
             return false;
         }
@@ -158,7 +159,8 @@ 
         }
         try {
             $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($args['deliverable']);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $handler->print_error('no deliverable with passed GUID: ' . $args['deliverable'] . ', aborting');
             return false;
         }
@@ -166,7 +168,8 @@ 
         //get the owner of the salesproject the deliverable belongs to
         try {
             $project = new org_openpsa_sales_salesproject_dba($deliverable->salesproject);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $handler->print_error('Failed to load salesproject: ' . $e->getMessage());
             return false;
         }

lib/org/openpsa/sales/salesproject.php

Spacing +3 added lines, -3 removed lines

@@ -90,7 +90,7 @@ 
             }
         }
         $profit = $value - $cost;
-        if (   $this->value != $value
+        if ($this->value != $value
             || $this->profit != $profit) {
             $this->value = $value;
             $this->profit = $value - $cost;
@@ -220,12 +220,12 @@ 
 
     public function _on_updating()
     {
-        if (   $this->state != self::STATE_ACTIVE
+        if ($this->state != self::STATE_ACTIVE
             && !$this->end) {
             //Not active anymore and end not set, set it to now
             $this->end = time();
         }
-        if (   $this->end
+        if ($this->end
             && $this->state == self::STATE_ACTIVE) {
             //Returned to active state, clear the end marker.
             $this->end = 0;

Braces +4 added lines, -2 removed lines

@@ -120,14 +120,16 @@
         if (!empty($this->customer)) {
             try {
                 return org_openpsa_contacts_group_dba::get_cached($this->customer);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }
         if (!empty($this->customerContact)) {
             try {
                 return org_openpsa_contacts_person_dba::get_cached($this->customerContact);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/midcom/db/member.php

Braces +4 added lines, -2 removed lines

@@ -23,7 +23,8 @@ 
         try {
             $person = new midcom_db_person($this->uid);
             $grp = new midcom_db_group($this->gid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return 'Invalid membership record';
         }
@@ -40,7 +41,8 @@ 
         }
         try {
             $person = new midcom_db_person($this->uid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             return;
         }
         midcom::get()->cache->invalidate($person->guid);

lib/midcom/db/person.php

Spacing +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
     {
         parent::__set($property, $value);
 
-        if (   $property == 'firstname'
+        if ($property == 'firstname'
             || $property == 'lastname'
             || $property == 'homepage'
             || $property == 'email') {

lib/midcom/helper/xsspreventer.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
     {
         return preg_replace_callback(
             "%(<\s*)+(/\s*)+{$element}%i",
-            function ($matches) {
+            function($matches) {
                 return htmlentities($matches[0]);
             },
             $input

lib/midcom/helper/nav/main.php

Spacing +3 added lines, -3 removed lines

@@ -222,7 +222,7 @@ 
         if ($uplink == $root_id) {
             return true;
         }
-        if (   $uplink == false
+        if ($uplink == false
             || $uplink == -1) {
             return false;
         }
@@ -446,7 +446,7 @@ 
                     $entry = "<span class=\"{$current_class}\">{$entry}</span>";
                 }
             } else {
-                if (   !empty($data['napobject'][MIDCOM_NAV_GUID])
+                if (!empty($data['napobject'][MIDCOM_NAV_GUID])
                     && in_array($data['napobject'][MIDCOM_NAV_GUID], $skip_guids)) {
                     continue;
                 }
@@ -569,7 +569,7 @@ 
                     $id = "custom-{$key}";
 
                     $url = "{$prefix}{$entry[MIDCOM_NAV_URL]}";
-                    if (   substr($entry[MIDCOM_NAV_URL], 0, 1) == '/'
+                    if (substr($entry[MIDCOM_NAV_URL], 0, 1) == '/'
                         || preg_match('|^https?://|', $entry[MIDCOM_NAV_URL])) {
                         $url = $entry[MIDCOM_NAV_URL];
                     }

Braces +2 added lines, -1 removed lines

@@ -296,7 +296,8 @@
         // the tree. This is, for example, used by the on-delete cache invalidation.
         try {
             $object = midcom::get()->dbfactory->get_object_by_guid($guid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             debug_add("Could not load GUID {$guid}, trying to continue anyway. Last error was: " . $e->getMessage(), MIDCOM_LOG_WARN);
         }
         if (!empty($object)) {