flack / openpsa

lib/midgard/admin/asgard/response.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
     public function send()
     {
         $context = midcom_core_context::get();
-        $data =& $context->get_custom_key('request_data');
+        $data = & $context->get_custom_key('request_data');
         midcom::get()->style->enter_context($context->id);
 
         if (isset($data['view_title'])) {

lib/midgard/admin/asgard/toolbar.php

Braces +2 added lines, -1 removed lines

@@ -117,7 +117,8 @@
                                 }
                                 break;
                         }
-                    } catch (midcom_error $e) {
+                    }
+                    catch (midcom_error $e) {
                         $e->log();
                     }
                 }

Spacing +3 added lines, -3 removed lines

@@ -144,7 +144,7 @@ 
             ];
         }
 
-        if (   midcom::get()->config->get('midcom_services_rcs_enable')
+        if (midcom::get()->config->get('midcom_services_rcs_enable')
             && $object->can_do('midgard:update')
             && $object->_use_rcs) {
             $buttons[] = [
@@ -205,7 +205,7 @@ 
     private function get_toolbar_update_items($object)
     {
         $buttons = [];
-        if (   is_a($object, midcom_db_topic::class)
+        if (is_a($object, midcom_db_topic::class)
             && $object->component
             && $object->can_do('midcom:component_config')) {
             $buttons[] = [
@@ -243,7 +243,7 @@ 
             MIDCOM_TOOLBAR_ENABLED => $object->can_do('midgard:privileges'),
         ];
 
-        if (   midcom::get()->componentloader->is_installed('midcom.helper.replicator')
+        if (midcom::get()->componentloader->is_installed('midcom.helper.replicator')
             && midcom::get()->auth->admin) {
             $buttons[] = [
                 MIDCOM_TOOLBAR_URL => "__mfa/asgard_midcom.helper.replicator/object/{$object->guid}/",

lib/midgard/admin/user/handler/list.php

Braces +2 added lines, -1 removed lines

@@ -217,7 +217,8 @@
 
         try {
             $account = new midcom_core_account($person);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             midcom::get()->uimessages->add($this->_l10n->get('midgard.admin.user'), sprintf($this->_l10n->get('failed to get the user with id %s'), $person->id), 'error');
             return;
         }

lib/midgard/admin/user/handler/group/list.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
                 midcom::get()->uimessages->add($this->_l10n->get('midgard.admin.user'), $this->_l10n_midcom->get('updated'));
                 return new midcom_response_relocate("__mfa/asgard_midgard.admin.user/group/edit/{$data['group']->guid}/");
             }
-            debug_add('Failed to update the group, last error was '. midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
+            debug_add('Failed to update the group, last error was ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
             debug_print_r('We operated on this object', $data['group'], MIDCOM_LOG_ERROR);
 
             throw new midcom_error('Failed to update the group, see error level log for details');

lib/midgard/admin/user/validator.php

Spacing +2 added lines, -2 removed lines

@@ -27,8 +27,8 @@
         if (!empty($fields["username"])) {
             $user = midcom::get()->auth->get_user_by_name($fields["username"]);
 
-            if (   $user
-                && (   !isset($fields['person'])
+            if ($user
+                && (!isset($fields['person'])
                     || $user->guid != $fields['person'])) {
                 $result["username"] = sprintf(midcom::get()->i18n->get_string("username %s is already in use", "midgard.admin.user"), $fields['username']);
             }

lib/org/openpsa/projects/handler/workflow.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     {
         midcom::get()->auth->require_valid_user();
         //Look for action among POST variables, then load main handler...
-        if (   empty($_POST['org_openpsa_projects_workflow_action'])
+        if (empty($_POST['org_openpsa_projects_workflow_action'])
             || !is_array($_POST['org_openpsa_projects_workflow_action'])) {
             throw new midcom_error('Incomplete request');
         }

lib/org/openpsa/projects/handler/task/list.php

Braces +4 added lines, -2 removed lines

@@ -426,7 +426,8 @@ 
             $prefix = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX);
             $ret['project'] = '<a href="' . $prefix . 'project/' . $project->guid . '/">' . $project->title . '</a>';
             $ret['index_project'] = $project->title;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
 
@@ -437,7 +438,8 @@ 
                 $customer_url = "{$this->_request_data['contacts_url']}group/{$customer->guid}/";
                 $ret['customer'] = "<a href='{$customer_url}' title='{$customer->official}'>{$customer->get_label()}</a>";
                 $ret['index_customer'] = $customer->name;
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $ret['customer'] = '';
                 $ret['index_customer'] = '';
             }

Spacing +1 added lines, -1 removed lines

@@ -174,7 +174,7 @@
             case 'proposed':
                 $html = $this->render_status($task->manager, "from %s");
                 $task->get_members();
-                if (   $task->can_do('midgard:update')
+                if ($task->can_do('midgard:update')
                     && isset($task->resources[midcom_connection::get_user()])) {
                     $html .= '<form method="post" action="' . $prefix . 'workflow/' . $task->guid . '/">';
                     //TODO: If we need all resources to accept task hide tools when we have accepted and replace with "pending acceptance from..."

lib/org/openpsa/documents/directory.php

Spacing +2 added lines, -2 removed lines

@@ -20,7 +20,7 @@ 
         $ownerwg = $this->get_parameter('org.openpsa.core', 'orgOpenpsaOwnerWg');
         $accesstype = $this->get_parameter('org.openpsa.core', 'orgOpenpsaAccesstype');
 
-        if (   $ownerwg
+        if ($ownerwg
             && $accesstype) {
             // Sync the object's ACL properties into MidCOM ACL system
             $sync = new org_openpsa_core_acl_synchronizer();
@@ -41,7 +41,7 @@ 
     private function _update_parent_timestamp()
     {
         $parent = $this->get_parent();
-        if (   $parent
+        if ($parent
             && $parent->component == 'org.openpsa.documents') {
             midcom::get()->auth->request_sudo('org.openpsa.documents');
 

lib/org/openpsa/httplib/main.php

Spacing +1 added lines, -1 removed lines

@@ -115,7 +115,7 @@
         $request->addHeader('User-Agent: Midgard/' . substr(mgd_version(), 0, 4));
 
         // Handle basic auth
-        if (   !empty($username)
+        if (!empty($username)
             && !empty($password)) {
             // Set basic auth
             $request->addHeader('Authorization: Basic ' . base64_encode($username . ':' . $password));

Braces +2 added lines, -1 removed lines

@@ -129,7 +129,8 @@
 
         try {
             $response = $browser->send($request);
-        } catch (Exception $e) {
+        }
+        catch (Exception $e) {
             $this->error = $e->getMessage();
             debug_add("Got error '{$this->error}' from HTTP request", MIDCOM_LOG_INFO);
             return false;