midgard_admin_asgard_handler

Complexity

Total Complexity

4

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Test Coverage

Coverage

94.12%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	get_response()	0	10	3
A	load_deleted()	0	14	1

<?php
/**
 * @package midgard.admin.asgard
 * @author CONTENT CONTROL http://www.contentcontrol-berlin.de/
 * @copyright CONTENT CONTROL http://www.contentcontrol-berlin.de/
 * @license http://www.gnu.org/licenses/gpl.html GNU General Public License
 */

use midgard\portable\storage\connection;

/**
 * @package midgard.admin.asgard
 */
trait midgard_admin_asgard_handler
{
    public function get_response(string $element = null) : midcom_response_styled
    {
        if (isset($_GET['ajax'])) {
            midcom::get()->skip_page_style = true;
        }
        $this->populate_breadcrumb_line();

It seems like populate_breadcrumb_line() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($element) {
            return $this->show($element, 'ASGARD_ROOT');

It seems like show() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
        return new midcom_response_styled(midcom_core_context::get(), 'ASGARD_ROOT');
    }

    public function load_deleted(string $guid) : midcom_core_dbaobject
    {
        $type = connection::get_em()
            ->createQuery('SELECT r.typename from midgard_repligard r WHERE r.guid = ?1')
            ->setParameter(1, $guid)
            ->getSingleScalarResult();

        $dba_type = midcom::get()->dbclassloader->get_midcom_class_name_for_mgdschema_object($type);

        $qb = midcom::get()->dbfactory->new_query_builder($dba_type);

It seems like $dba_type can also be of type null; however, parameter $classname of midcom_helper__dbfactory::new_query_builder() does only seem to accept string, maybe add an additional type check?

        $qb->include_deleted();
        $qb->add_constraint('guid', '=', $guid);

        return $qb->get_result(0);
    }
}