Passed
Push — master ( 3420f6...8740f6 )
by Andreas
10:59
created
lib/net/nemein/wiki/midcom/interfaces.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,8 @@
 block discarded – undo
30 30
             foreach ($result as $wikipage) {
31 31
                 try {
32 32
                     $datamanager->set_storage($wikipage);
33
-                } catch (midcom_error $e) {
33
+                }
34
+                catch (midcom_error $e) {
34 35
                     $e->log(MIDCOM_LOG_WARN);
35 36
                     continue;
36 37
                 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 
45 45
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
46 46
     {
47
-        if (   $object instanceof midcom_db_article
47
+        if ($object instanceof midcom_db_article
48 48
             && $topic->id == $object->topic) {
49 49
             if ($object->name == 'index') {
50 50
                 return '';
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/archive.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -409,7 +409,8 @@
 block discarded – undo
409 409
             foreach ($this->_articles as $article_counter => $article) {
410 410
                 try {
411 411
                     $data['datamanager']->set_storage($article);
412
-                } catch (midcom_error $e) {
412
+                }
413
+                catch (midcom_error $e) {
413 414
                     $e->log();
414 415
                     continue;
415 416
                 }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -131,8 +131,8 @@  discard block
 block discarded – undo
131 131
         $year_data = [];
132 132
         $first_post = $this->_compute_welcome_first_post();
133 133
         $this->_request_data['first_post'] = $first_post;
134
-        $this->_request_data['total_count'] =& $total_count;
135
-        $this->_request_data['year_data'] =& $year_data;
134
+        $this->_request_data['total_count'] = & $total_count;
135
+        $this->_request_data['year_data'] = & $year_data;
136 136
         if (!$first_post) {
137 137
             return;
138 138
         }
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
         switch ($handler_id) {
262 262
             case 'archive-year-category':
263 263
                 $category = trim(strip_tags($args[1]));
264
-                if (   $data['datamanager']->get_schema('default')->has_field('categories')
264
+                if ($data['datamanager']->get_schema('default')->has_field('categories')
265 265
                     && !$data['datamanager']->get_schema('default')->get_field('categories')['type_config']['allow_multiple']) {
266 266
                     $qb->add_constraint('extra1', '=', $category);
267 267
                 } else {
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
             throw new midcom_error_notfound("The year '{$year}' is not valid.");
346 346
         }
347 347
 
348
-        if (   $month < 1
348
+        if ($month < 1
349 349
             || $month > 12) {
350 350
             throw new midcom_error_notfound("The month {$month} is not valid.");
351 351
         }
Please login to merge, or discard this patch.
lib/net/nehmer/static/handler/view.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
             ]);
47 47
         }
48 48
 
49
-        if (   $this->_article->topic === $this->_topic->id
49
+        if ($this->_article->topic === $this->_topic->id
50 50
             && $this->_article->can_do('midgard:delete')) {
51 51
             $delete = $this->get_workflow('delete', ['object' => $this->_article]);
52 52
             $buttons[] = $delete->get_button("delete/{$this->_article->guid}/");
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
         $this->_datamanager->set_storage($this->_article);
115 115
 
116 116
         $arg = $this->_article->name ?: $this->_article->guid;
117
-        if (   $arg != 'index'
117
+        if ($arg != 'index'
118 118
             && $this->_config->get('hide_navigation')) {
119 119
             $this->add_breadcrumb("{$arg}/", $this->_article->title);
120 120
         }
@@ -124,13 +124,13 @@  discard block
 block discarded – undo
124 124
         midcom::get()->metadata->set_request_metadata($this->_article->metadata->revised, $this->_article->guid);
125 125
         $this->bind_view_to_object($this->_article, $this->_datamanager->get_schema()->get_name());
126 126
 
127
-        if (   $this->_config->get('indexinnav')
127
+        if ($this->_config->get('indexinnav')
128 128
             || $this->_config->get('autoindex')
129 129
             || $this->_article->name != 'index') {
130 130
             $this->set_active_leaf($this->_article->id);
131 131
         }
132 132
 
133
-        if (   $this->_config->get('folder_in_title')
133
+        if ($this->_config->get('folder_in_title')
134 134
             && $this->_topic->extra != $this->_article->title) {
135 135
             midcom::get()->head->set_pagetitle("{$this->_topic->extra}: {$this->_article->title}");
136 136
         } else {
Please login to merge, or discard this patch.
lib/midcom/style/midcom_datamanager_unlock.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,8 @@
 block discarded – undo
7 7
 try {
8 8
     $person = new midcom_db_person($metadata->locker);
9 9
     $name = $person->name;
10
-} catch (midcom_error $e) {
10
+}
11
+catch (midcom_error $e) {
11 12
     $name = $l10n_midcom->get('unknown user');
12 13
     $e->log();
13 14
 }
Please login to merge, or discard this patch.
lib/net/nemein/wiki/style/view-wikipage-whatlinks.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,8 @@
 block discarded – undo
12 12
     foreach ($data['wikilinks'] as $link) {
13 13
         try {
14 14
             $page = new net_nemein_wiki_wikipage($link->frompage);
15
-        } catch (midcom_error $e) {
15
+        }
16
+        catch (midcom_error $e) {
16 17
             $e->log();
17 18
             continue;
18 19
         }
Please login to merge, or discard this patch.
lib/net/nemein/wiki/style/view-latest-item.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
     </td>
23 23
     <td class="revisor">
24 24
         <?php
25
-        if (   $history['user']
25
+        if ($history['user']
26 26
             && $user = midcom::get()->auth->get_user($history['user'])) {
27 27
             $person_label = org_openpsa_widgets_contact::get($user->guid)->show_inline();
28 28
             echo "                    {$person_label}\n";
Please login to merge, or discard this patch.
lib/net/nehmer/comments/style/admin-comments-item.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@
 block discarded – undo
16 16
     $view['author'],
17 17
     $formatter->datetime($created));
18 18
 
19
-if (   midcom::get()->auth->admin
20
-   || (   midcom::get()->auth->user
19
+if (midcom::get()->auth->admin
20
+   || (midcom::get()->auth->user
21 21
        && $comment->can_do('midgard:delete'))) {
22 22
     $creator = $comment->metadata->creator;
23 23
     $created = $comment->metadata->created;
Please login to merge, or discard this patch.
lib/net/nehmer/blog/style/archive-welcome-start.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 
4 4
 if ($data['first_post']) {
5 5
     $summary .= ' ' . sprintf($data['l10n']->get('first post was made on %s.'),
6
-                              $data['l10n']->get_formatter()->date($data['first_post']));
6
+                                $data['l10n']->get_formatter()->date($data['first_post']));
7 7
 }
8 8
 ?>
9 9
 
Please login to merge, or discard this patch.
lib/net/nehmer/blog/style/view.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,8 @@
 block discarded – undo
35 35
             try {
36 36
                 $article = new midcom_db_article($related);
37 37
                 echo "<li><a href=\"" . midcom::get()->permalinks->create_permalink($article->guid) . "\">{$article->title}</a></li>\n";
38
-            } catch (midcom_error $e) {
38
+            }
39
+            catch (midcom_error $e) {
39 40
                 $e->log();
40 41
             }
41 42
         }
Please login to merge, or discard this patch.