flack / openpsa

src/midcom/datamanager/storage/container/dbacontainer.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
             }
             $config['name'] = $name;
             $field = $this->prepare_field($config);
-            if (   isset($config['default'])
+            if (isset($config['default'])
                 && (!$this->object->id || $field instanceof transientnode)) {
                 $field->set_value($config['default']);
             }

lib/midcom/response/styled.php

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
 
     private function set_context(midcom_core_context $context)
     {
-        if (   $context->get_key(MIDCOM_CONTEXT_PERMALINKGUID) === null
+        if ($context->get_key(MIDCOM_CONTEXT_PERMALINKGUID) === null
             || $context->get_key(MIDCOM_CONTEXT_PAGETITLE) == '') {
             // Retrieve Metadata
             $nav = new midcom_helper_nav();

lib/midcom/baseclasses/core/dbobject.php

Braces +2 added lines, -1 removed lines

@@ -673,7 +673,8 @@
          */
         try {
             return $object->get_by_id($object->id);
-        } catch (Exception $e) {
+        }
+        catch (Exception $e) {
             return false;
         }
     }

Spacing +4 added lines, -4 removed lines

@@ -119,14 +119,14 @@ 
         if ($parent = $object->get_parent()) {
             // Attachments are a special case
             if ($object instanceof midcom_db_attachment) {
-                if (   !$parent->can_do('midgard:attachments')
+                if (!$parent->can_do('midgard:attachments')
                     || !$parent->can_do('midgard:update')) {
                     debug_add("Failed to create attachment, update or attachments privilege on the parent " . get_class($parent) . " {$parent->guid} not granted for the current user.",
                         MIDCOM_LOG_ERROR);
                     midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
                     return false;
                 }
-            } elseif (   !$parent->can_do('midgard:create')
+            } elseif (!$parent->can_do('midgard:create')
                       && !midcom::get()->auth->can_user_do('midgard:create', null, get_class($object))) {
                 debug_add("Failed to create object, create privilege on the parent " . get_class($parent) . " {$parent->guid} or the actual object class not granted for the current user.",
                     MIDCOM_LOG_ERROR);
@@ -238,7 +238,7 @@ 
             }
 
             // Default the owner to first group of current user
-            if (   empty($object->metadata->owner)
+            if (empty($object->metadata->owner)
                 && $first_group = midcom::get()->auth->user->get_first_group_guid()) {
                 $object->metadata->set('owner', $first_group);
             }
@@ -462,7 +462,7 @@ 
      */
     public static function get_by_guid(midcom_core_dbaobject $object, string $guid) : bool
     {
-        if (   !midcom::get()->auth->admin
+        if (!midcom::get()->auth->admin
             && !midcom::get()->auth->acl->can_do_byguid('midgard:read', $guid, get_class($object), midcom::get()->auth->acl->get_user_id())) {
             debug_add("Failed to load object, read privilege on the " . get_class($object) . " {$guid} not granted for the current user.", MIDCOM_LOG_ERROR);
             return false;

src/midcom/datamanager/validation/imageValidator.php

Spacing +3 added lines, -3 removed lines

@@ -12,10 +12,10 @@
 {
     public function validate($value, Constraint $constraint)
     {
-        if (   empty($value)
+        if (empty($value)
             || !empty($value['delete'])
-            || (   empty($value['file'])
-                && (   (empty($constraint->config['do_not_save_archival']) && empty($value['archival']))
+            || (empty($value['file'])
+                && ((empty($constraint->config['do_not_save_archival']) && empty($value['archival']))
                     || (!empty($constraint->config['do_not_save_archival']) && empty($value['main']))))) {
             $this->context->buildViolation('This value should not be blank.')
                 ->addViolation();

lib/org/openpsa/calendar/handler/event/create.php

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
         if ($query->has('start')) {
             $defaults['start'] = strtotime(substr($query->get('start'), 0, 19)) + 1;
             if ($query->has('end')) {
-                $defaults['end']= strtotime(substr($query->get('end'), 0, 19));
+                $defaults['end'] = strtotime(substr($query->get('end'), 0, 19));
             } else {
                 $defaults['end'] = $defaults['start'] + 3600;
             }

src/midcom/routing/resolver.php

Spacing +1 added lines, -1 removed lines

@@ -138,7 +138,7 @@
         $prefix = $this->context->get_key(MIDCOM_CONTEXT_ANCHORPREFIX);
 
         // Check if we need to start up a plugin.
-        if (   count($argv) > 1
+        if (count($argv) > 1
             && $config = plugin::get_config($argv[0], $argv[1])) {
             $namespace = array_shift($argv);
             $name = array_shift($argv);

Braces +6 added lines, -3 removed lines

@@ -69,7 +69,8 @@ 
 
             try {
                 $result = $router->match($url);
-            } catch (ResourceNotFoundException $e) {
+            }
+            catch (ResourceNotFoundException $e) {
                 throw new midcom_error_notfound('This URL method is unknown.');
             }
             $this->request->attributes->add($result);
@@ -151,11 +152,13 @@ 
 
         try {
             $result = $router->match($url);
-        } catch (ResourceNotFoundException $e) {
+        }
+        catch (ResourceNotFoundException $e) {
             // No match
             debug_add("Component {$viewer->_component} in {$viewer->_topic->name} declared unable to handle request.", MIDCOM_LOG_INFO);
             throw new midcom_error_notfound("This page is not available on this server.");
-        } catch (MethodNotAllowedException $e) {
+        }
+        catch (MethodNotAllowedException $e) {
             debug_add("Component {$viewer->_component} in {$viewer->_topic->name} declared unable to handle request (method not allowed).", MIDCOM_LOG_INFO);
             throw new midcom_error_forbidden($e->getMessage(), Response::HTTP_METHOD_NOT_ALLOWED);
         }

src/midcom/console/command/exec.php

Braces +2 added lines, -1 removed lines

@@ -80,7 +80,8 @@
 
         try {
             require $basedir . $file;
-        } catch (\midcom_error_forbidden $e) {
+        }
+        catch (\midcom_error_forbidden $e) {
             $dialog = $this->getHelperSet()->get('question');
             $this->login($dialog, $input, $output);
             require $basedir . $file;

lib/midcom/db/topic.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
     public function _on_loaded()
     {
         // if we are missing the component, use the nullcomponent.
-        if (   !$this->component
+        if (!$this->component
             || !midcom::get()->componentloader->is_installed($this->component)) {
             debug_add("Topic {$this->id} has no component assigned to it, using 'midcom.core.nullcomponent'.",
             MIDCOM_LOG_INFO);

src/midcom/events/watcher.php

Braces +2 added lines, -1 removed lines

@@ -72,7 +72,8 @@
             $component = key($watch);
             try {
                 $interface = $this->loader->get_interface_class($component);
-            } catch (\midcom_error $e) {
+            }
+            catch (\midcom_error $e) {
                 debug_add("Failed to load the component {$component}: " . $e->getMessage(), MIDCOM_LOG_INFO);
                 continue;
             }