net_nehmer_static_viewer

Complexity

Total Complexity

12

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Test Coverage

Coverage

71.74%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	get_topic_qb()	0	20	5
A	index()	0	10	1
A	_populate_node_toolbar()	0	26	5
A	_on_handle()	0	5	1

<?php
/**
 * @package net.nehmer.static
 * @author The Midgard Project, http://www.midgard-project.org
 * @copyright The Midgard Project, http://www.midgard-project.org
 * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
 */

use midcom\datamanager\datamanager;
use midcom\datamanager\schemadb;

/**
 * n.n.static site interface class
 *
 * @package net.nehmer.static
 */
class net_nehmer_static_viewer extends midcom_baseclasses_components_viewer
{
    /**
     * Indexes an article.
     *
     * @param midcom_db_topic|midcom_core_dbaproxy $topic The topic which we are bound to. If this is not an object, the code
     *     tries to load a new topic instance from the database identified by this parameter.
     */
    public static function index(datamanager $dm, midcom_services_indexer $indexer, $topic)
    {
        $nav = new midcom_helper_nav();
        $node = $nav->get_node($topic->id);

        $document = $indexer->new_document($dm);
        $document->topic_guid = $topic->guid;
        $document->topic_url = $node[MIDCOM_NAV_FULLURL];
        $document->component = $topic->component;

The property component does not exist on midcom_core_dbaproxy. Since you implemented __get, consider adding a @property annotation.

        $indexer->index($document);
    }

    /**
     * Populates the node toolbar depending on the user's rights.
     */
    private function _populate_node_toolbar()
    {
        $buttons = [];
        $workflow = $this->get_workflow('datamanager');
        if ($this->_topic->can_do('midgard:create')) {
            foreach ($this->_request_data['schemadb']->all() as $name => $schema) {
                $buttons[] = $workflow->get_button($this->router->generate('create', ['schema' => $name]), [
                    MIDCOM_TOOLBAR_LABEL => sprintf(
                        $this->_l10n_midcom->get('create %s'),
                        $this->_l10n->get($schema->get('description'))
                    ),
                    MIDCOM_TOOLBAR_GLYPHICON => 'file-o',
                    MIDCOM_TOOLBAR_ACCESSKEY => 'n',
                ]);
            }
        }

        if (   $this->_topic->can_do('midgard:update')
            && $this->_topic->can_do('midcom:component_config')) {
                $buttons[] = $workflow->get_button($this->router->generate('config'), [
                MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),
                MIDCOM_TOOLBAR_HELPTEXT => $this->_l10n_midcom->get('component configuration helptext'),
                MIDCOM_TOOLBAR_GLYPHICON => 'wrench',
            ]);
        }
        $this->_node_toolbar->add_items($buttons);
    }

    /**
     * The handle callback populates the toolbars.
     */
    public function _on_handle($handler, array $args)
    {
        $this->_request_data['schemadb'] = schemadb::from_path($this->_config->get('schemadb'));

It seems like $this->_config->get('schemadb') can also be of type false; however, parameter $path of midcom\datamanager\schemadb::from_path() does only seem to accept string, maybe add an additional type check?

        $this->_populate_node_toolbar();
    }

    public static function get_topic_qb(int $id, ?string $sort_property = null) : midcom_core_querybuilder
    {
        $qb = midcom_db_article::new_query_builder();
        $qb->add_constraint('topic', '=', $id);

        if ($sort_property) {
            $sort_order = 'ASC';
            if (str_starts_with($sort_property, 'reverse ')) {
                $sort_order = 'DESC';
                $sort_property = substr($sort_property, strlen('reverse '));
            }
            if (!str_contains($sort_property, 'metadata.')) {
                $ref = midcom_helper_reflector::get('midgard_article');
                if (!$ref->property_exists($sort_property)) {
                    $sort_property = 'metadata.' . $sort_property;
                }
            }
            $qb->add_order($sort_property, $sort_order);
        }
        return $qb;
    }
}