Passed
Push — master ( 347c14...f99775 )
by Andreas
20:11
created
lib/midcom/baseclasses/core/dbobject.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -133,14 +133,14 @@  discard block
 block discarded – undo
133 133
         if ($parent !== null) {
134 134
             // Attachments are a special case
135 135
             if ($object instanceof midcom_db_attachment) {
136
-                if (   !$parent->can_do('midgard:attachments')
136
+                if (!$parent->can_do('midgard:attachments')
137 137
                     || !$parent->can_do('midgard:update')) {
138 138
                     debug_add("Failed to create attachment, update or attachments privilege on the parent " . get_class($parent) . " {$parent->guid} not granted for the current user.",
139 139
                         MIDCOM_LOG_ERROR);
140 140
                     midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
141 141
                     return false;
142 142
                 }
143
-            } elseif (   !$parent->can_do('midgard:create')
143
+            } elseif (!$parent->can_do('midgard:create')
144 144
                       && !midcom::get()->auth->can_user_do('midgard:create', null, get_class($object))) {
145 145
                 debug_add("Failed to create object, create privilege on the parent " . get_class($parent) . " {$parent->guid} or the actual object class not granted for the current user.",
146 146
                     MIDCOM_LOG_ERROR);
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
             }
264 264
 
265 265
             // Default the owner to first group of current user
266
-            if (   empty($object->metadata->owner)
266
+            if (empty($object->metadata->owner)
267 267
                 && $first_group = midcom::get()->auth->user->get_first_group_guid()) {
268 268
                 $object->metadata->set('owner', $first_group);
269 269
             }
@@ -720,7 +720,7 @@  discard block
 block discarded – undo
720 720
      */
721 721
     public static function get_by_guid(midcom_core_dbaobject $object, string $guid) : bool
722 722
     {
723
-        if (   !midcom::get()->auth->admin
723
+        if (!midcom::get()->auth->admin
724 724
             && !midcom::get()->auth->acl->can_do_byguid('midgard:read', $guid, get_class($object), midcom::get()->auth->acl->get_user_id())) {
725 725
             debug_add("Failed to load object, read privilege on the " . get_class($object) . " {$guid} not granted for the current user.", MIDCOM_LOG_ERROR);
726 726
             return false;
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -673,7 +673,8 @@
 block discarded – undo
673 673
          */
674 674
         try {
675 675
             return $object->get_by_id($object->id);
676
-        } catch (Exception $e) {
676
+        }
677
+        catch (Exception $e) {
677 678
             return false;
678 679
         }
679 680
     }
Please login to merge, or discard this patch.
lib/net/nehmer/comments/handler/admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@
 block discarded – undo
111 111
      */
112 112
     public function _handler_moderate_ajax(Request $request, string $status, array &$data)
113 113
     {
114
-        if (   !$request->request->has('action')
114
+        if (!$request->request->has('action')
115 115
             || !$request->request->has('guid')) {
116 116
             throw new midcom_error_notfound('Incomplete POST data');
117 117
         }
Please login to merge, or discard this patch.
lib/org/openpsa/sales/handler/deliverable/add.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@
 block discarded – undo
86 86
      */
87 87
     public function _handler_add(Request $request, string $guid, array &$data)
88 88
     {
89
-        if (   !$request->request->has('product')
89
+        if (!$request->request->has('product')
90 90
             && !$request->request->has('org_openpsa_sales')) {
91 91
             throw new midcom_error('No product specified, aborting.');
92 92
         }
Please login to merge, or discard this patch.
lib/midcom/admin/folder/handler/approvals.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
      */
22 22
     public function _handler_approval(Request $request, string $handler_id)
23 23
     {
24
-        if (   !$request->request->has('guid')
24
+        if (!$request->request->has('guid')
25 25
             || !$request->request->has('return_to')) {
26 26
             throw new midcom_error('Cannot process approval request, request is incomplete.');
27 27
         }
Please login to merge, or discard this patch.
lib/midcom/helper/nav/backend.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
             }
280 280
 
281 281
             $this->_leaves[$id] = $leaf;
282
-            $this->_loaded_leaves[$node->id][$id] =& $this->_leaves[$id];
282
+            $this->_loaded_leaves[$node->id][$id] = & $this->_leaves[$id];
283 283
         }
284 284
     }
285 285
 
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
                     continue;
338 338
                 }
339 339
 
340
-                if (   !$show_noentry
340
+                if (!$show_noentry
341 341
                     && self::$_nodes[$id]->noentry) {
342 342
                     // Hide "noentry" items
343 343
                     continue;
Please login to merge, or discard this patch.
lib/midcom/core/context.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -165,7 +165,8 @@
 block discarded – undo
165 165
                 try {
166 166
                     self::$root_topic = midcom_db_topic::get_cached($guid);
167 167
                     return self::$root_topic;
168
-                } catch (midcom_error $e) {
168
+                }
169
+                catch (midcom_error $e) {
169 170
                     if ($e instanceof midcom_error_forbidden) {
170 171
                         throw $e;
171 172
                     }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -254,7 +254,7 @@
 block discarded – undo
254 254
      */
255 255
     public function set_custom_key($key, &$value)
256 256
     {
257
-        $this->_data[MIDCOM_CONTEXT_CUSTOMDATA][$key] =& $value;
257
+        $this->_data[MIDCOM_CONTEXT_CUSTOMDATA][$key] = & $value;
258 258
     }
259 259
 
260 260
     public function show()
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/style/show-campaign.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,14 +50,14 @@
 block discarded – undo
50 50
     </div>
51 51
 
52 52
     <script type="text/javascript">
53
-    $('#<?php echo $grid->get_identifier();?>').on('click', 'td.delete i', function(event) {
53
+    $('#<?php echo $grid->get_identifier(); ?>').on('click', 'td.delete i', function(event) {
54 54
         var guid = $(event.target).data('person-guid'),
55 55
             member_guid = $(event.target).data('member-guid'),
56 56
             post_data = {org_openpsa_ajax_mode: 'unsubscribe', org_openpsa_ajax_person_guid: guid};
57 57
 
58 58
         $(event.target).removeClass('fa-trash').addClass('fa-spin fa-spinner');
59 59
         $.post('&(node[MIDCOM_NAV_ABSOLUTEURL]);campaign/unsubscribe/ajax/' + member_guid + '/', post_data, function() {
60
-            $('#<?php echo $grid->get_identifier();?>').trigger('reloadGrid');
60
+            $('#<?php echo $grid->get_identifier(); ?>').trigger('reloadGrid');
61 61
             $('#org_openpsa_widgets_contact-' + guid).fadeOut('fast', function() {
62 62
                 $('#org_openpsa_widgets_contact-' + guid).remove();
63 63
             });
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/urlnameType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
      */
23 23
     public function configureOptions(OptionsResolver $resolver)
24 24
     {
25
-        $resolver->setNormalizer('write_privilege', function (Options $options, $value) {
25
+        $resolver->setNormalizer('write_privilege', function(Options $options, $value) {
26 26
             return (array) $value + ['privilege' => 'midcom:urlname'];
27 27
         });
28 28
 
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
             ]
37 37
         ]);
38 38
 
39
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
39
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
40 40
             $validator_options = [
41 41
                 'allow_catenate' => $options['type_config']['allow_catenate'],
42 42
                 'allow_unclean' => $options['type_config']['allow_unclean'],
Please login to merge, or discard this patch.
src/midcom/datamanager/storage/container/dbacontainer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
             }
37 37
             $config['name'] = $name;
38 38
             $field = $this->prepare_field($config);
39
-            if (   isset($config['default'])
39
+            if (isset($config['default'])
40 40
                 && (!$this->object->id || $field instanceof transientnode)) {
41 41
                 $field->set_value($config['default']);
42 42
             }
Please login to merge, or discard this patch.