blobs::save() - Code Metrics - Inspection of "Small readbility improvements" - flack/openpsa - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 40aec1...d8787f )

by Andreas
created 2024-06-03 13:10 UTC
blobs::save() C

↳ Parent: blobs
Complexity

Conditions	12
Paths	6
Size

Total Lines	57
Code Lines	37
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	26
CRAP Score	15.7839
Importance

Changes
Metric	Value
cc	12
eloc	37
c	0
b	0
f	0
nc	6
nop	0
dl	0
loc	57
ccs	26
cts	37
cp	0.7027
crap	15.7839
rs	6.9666
How to fix Long Method Complexity

<?php
/**
 * @copyright CONTENT CONTROL GmbH, http://www.contentcontrol-berlin.de
 */

namespace midcom\datamanager\storage;

use midcom_db_attachment;
use midcom_core_dbaobject;
use midcom_error;
use midcom_connection;
use midcom;
use midcom\datamanager\helper\attachment;
use Symfony\Component\Mime\FileBinaryMimeTypeGuesser;

/**
 * Experimental storage class
 */
class blobs extends delayed
{
    use attachment;

    /**
     * @var midcom_db_attachment[]
     */
    protected array $map = [];

    /**
     * @return midcom_db_attachment[]
     */
    public function load()
    {
        $results = [];
        if (!$this->object->id) {
            return $results;
        }

        $items = $this->load_attachment_list();
        foreach ($items as $identifier => $guid) {
            try {
                $results[$identifier] = new midcom_db_attachment($guid);
            } catch (midcom_error $e) {
                $e->log();
            }
        }

        return $results;
    }

    /**
     * {@inheritdoc}
     */
    public function save()
    {
        $this->map = [];
        $atts_in_db = $this->load();

        if (!empty($this->value)) {
            $guesser = new FileBinaryMimeTypeGuesser;
            foreach ($this->value as $identifier => $att) {
                if (!($att instanceof midcom_db_attachment)) {
                    continue;
                }

                $db_att = $atts_in_db[$identifier] ?? null;

                // new upload case
                if ($att->id === 0) {
                    $filename = midcom_db_attachment::safe_filename($att->name);
                    $title = $att->title ?: $att->name;
                    $source = $att->location;
                    $mimetype = $guesser->guessMimeType($source);

                    if (empty($db_att)) {
                        $db_att = $att;
                        $db_att->parentguid = $this->object->guid;
                        $this->create_attachment($db_att, $filename, $title, $mimetype);
                        $this->create_attachment($db_att, $filename, $title, /** @scrutinizer ignore-type */ $mimetype);
                        $identifier = md5(time() . $db_att->name . $source);
                    } else {
                        $db_att->name = $filename;
                        $db_att->title = $title;
                        $db_att->mimetype = $mimetype;
                    }
                    if (!$db_att->copy_from_file($source)) {
                        throw new midcom_error('Failed to copy attachment: ' . midcom_connection::get_error_string());
                    }
                    unlink($source);
                }
                // No file upload, only title change
                elseif ($db_att->title != $att->title) {
                    $db_att->title = $att->title;
                    $db_att->update();
                             update();
                }
                $this->map[$identifier] = $db_att;
                if (!empty($this->config['widget_config']['sortable'])) {
                    $db_att->metadata->score = $att->metadata->score;
                    $db_att->update();
                }
                if (!empty($this->config['widget_config']['show_description'])) {
                    $db_att->set_parameter('midcom.helper.datamanager2.type.blobs', 'description', $this->value['description']);
                }
            }
        }
        //delete attachments which are no longer in map
        foreach (array_diff_key($atts_in_db, $this->map) as $attachment) {
            $attachment->delete();
        }

        $this->save_attachment_list();
    }

    public function move_uploaded_files() : int
    {
        $total_moved = 0;

        foreach ($this->value as $att) {
            if (!($att instanceof midcom_db_attachment)) {
                continue;
            }
            if ($att->id !== 0) {
                continue;
            }
            $prefix = midcom::get()->config->get('midcom_tempdir') . '/tmpfile-';
            if (str_starts_with($att->location, $prefix)) {
                continue;
            }
            $total_moved++;

            $source = $att->location;
            $att->location = $prefix . md5(time() . $att->name . $source);
            $att->title = $att->name;

            move_uploaded_file($source, $att->location);
        }

        return $total_moved;
    }

    protected function save_attachment_list() : bool
    {
        if (!empty($this->config['widget_config']['sortable'])) {
            uasort($this->map, function (midcom_db_attachment $a, midcom_db_attachment $b) {
                if ($a->metadata->score == $b->metadata->score) {
                    return strnatcasecmp($a->name, $b->name);
                }
                return $b->metadata->score <=> $a->metadata->score;
            });
        }

        $list = [];

        foreach ($this->map as $identifier => $attachment) {
            $list[] = $identifier . ':' . $attachment->guid;
        }
        return $this->object->set_parameter('midcom.helper.datamanager2.type.blobs', "guids_{$this->config['name']}", implode(',', $list));
    }

    protected function load_attachment_list() : array
    {
        return self::load_map($this->object, $this->config['name']);
    }

    private static function load_map(midcom_core_dbaobject $object, string $field) : array
    {
        $map = [];
        $raw_list = $object->get_parameter('midcom.helper.datamanager2.type.blobs', "guids_{$field}");
        if (!$raw_list) {
            return $map;
        }

        foreach (explode(',', $raw_list) as $item) {
            $info = explode(':', $item);
            if (count($info) < 2) {
                debug_add("item '{$item}' is broken!", MIDCOM_LOG_ERROR);
                continue;
            }
            [$identifier, $guid] = $info;
            if (mgd_is_guid($guid)) {
                $map[$identifier] = $guid;
            }
        }
        return $map;
    }

    /**
     * @return midcom_db_attachment[] List of attachments, indexed by identifier
     */
    public static function get_attachments(midcom_core_dbaobject $object, string $field) : array
    {
        $attachments = [];
        foreach (self::load_map($object, $field) as $identifier => $guid) {
            try {
                $attachments[$identifier] = midcom_db_attachment::get_cached($guid);
            } catch (midcom_error $e) {
                $e->log();
            }
        }
        return $attachments;
    }
}

flack / openpsa

Push — master ( 40aec1...d8787f )

blobs::save() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
