Passed
Push — master ( cf00ea...cda971 )
by Andreas
09:47
created
src/midcom/datamanager/extension/type/codemirrorType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
      */
25 25
     public function configureOptions(OptionsResolver $resolver)
26 26
     {
27
-        $map_attr = function (Options $options, $value) {
27
+        $map_attr = function(Options $options, $value) {
28 28
             $value ??= [];
29 29
             $value['class'] = $options['widget_config']['enabled'] ? 'codemirror ' . $options['widget_config']['language'] : 'longtext';
30 30
 
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
             ]
45 45
         ]);
46 46
 
47
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
47
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
48 48
             if ($options['dm2_type'] == 'php') {
49 49
                 $value[] = new php;
50 50
             }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/toolbarType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
                 $operation = $button->getConfig()->getOption('operation');
67 67
                 $storage = $view->parent->vars['value'];
68 68
 
69
-                if (   $operation == controller::SAVE
69
+                if ($operation == controller::SAVE
70 70
                     && $storage instanceof dbacontainer
71 71
                     && empty($storage->get_value()->id)) {
72 72
                     $label = 'create';
Please login to merge, or discard this patch.
lib/net/nemein/rss/fetch.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
             $etag = trim($parser->data['headers']['etag']);
82 82
 
83 83
             $feed_etag = $this->_feed->get_parameter('net.nemein.rss', 'etag');
84
-            if (   !empty($feed_etag)
84
+            if (!empty($feed_etag)
85 85
                 && $feed_etag == $etag) {
86 86
                 // Feed hasn't changed, skip updating
87 87
                 debug_add("Feed {$this->_feed->url} has not changed since " . date('c', $this->_feed->latestfetch), MIDCOM_LOG_WARN);
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
         $guid = $item->get_id();
151 151
         $title = $item->get_title();
152 152
 
153
-        if (   (   empty($title)
153
+        if ((empty($title)
154 154
                 || trim($title) == '...')
155 155
             && empty($guid)) {
156 156
             // Something wrong with this entry, skip it
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
         }
213 213
 
214 214
         if ($article->id) {
215
-            if (   $this->apply_values($article, $values, $meta_values)
215
+            if ($this->apply_values($article, $values, $meta_values)
216 216
                 && !$article->update()) {
217 217
                 return null;
218 218
             }
@@ -241,14 +241,14 @@  discard block
 block discarded – undo
241 241
     private function find_author(net_nemein_rss_parser_item $item) : midcom_db_person
242 242
     {
243 243
         // Try to figure out item author
244
-        if (   $this->_feed->forceauthor
244
+        if ($this->_feed->forceauthor
245 245
             && $this->_feed->defaultauthor) {
246 246
             // Feed has a "default author" set, use it
247 247
             return new midcom_db_person($this->_feed->defaultauthor);
248 248
         }
249 249
         $author = $this->match_item_author($item);
250 250
         $fallback_person_id = 1;
251
-        if (   !$author
251
+        if (!$author
252 252
             || $author->id == $fallback_person_id) {
253 253
             if ($this->_feed->defaultauthor) {
254 254
                 // Feed has a "default author" set, use it
@@ -413,7 +413,7 @@  discard block
 block discarded – undo
413 413
             }
414 414
         }
415 415
 
416
-        if (   !empty($author_info['username'])
416
+        if (!empty($author_info['username'])
417 417
             && $person = midcom::get()->auth->get_user_by_name($author_info['username'])) {
418 418
             return $person->get_storage();
419 419
         }
Please login to merge, or discard this patch.
lib/midcom/config/main.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -363,7 +363,7 @@  discard block
 block discarded – undo
363 363
         // show_unapproved_objects). Disabled by default. Unsafe to Link Prefetching!
364 364
         'metadata_approval' => false,
365 365
         'metadata_scheduling' => false,
366
-        'metadata_lock_timeout' => 60,    // Time in minutes
366
+        'metadata_lock_timeout' => 60, // Time in minutes
367 367
 
368 368
         // Set the datamanager schema used by the Metadata Service
369 369
         'metadata_schema' => 'file:/midcom/config/metadata_default.inc',
@@ -439,12 +439,12 @@  discard block
 block discarded – undo
439 439
             return $default;
440 440
         }
441 441
 
442
-        if (   $key === 'auth_type'
442
+        if ($key === 'auth_type'
443 443
             && !in_array($this->_merged_config[$key], ['Plaintext', 'Legacy', 'SHA256'])) {
444 444
             throw new midcom_error('Unsupported authentication type');
445 445
         }
446 446
         // Check the midcom_config site prefix for absolute local urls
447
-        if (   $key === 'midcom_site_url'
447
+        if ($key === 'midcom_site_url'
448 448
             && str_starts_with($this->_merged_config[$key], '/')) {
449 449
             $this->_merged_config[$key] = midcom::get()->get_page_prefix() . substr($this->_merged_config[$key], 1);
450 450
         }
Please login to merge, or discard this patch.
lib/midcom/helper/search/handler/search.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
      */
60 60
     private function search_nodes(array $node, midcom_helper_nav $nap, string $prefix)
61 61
     {
62
-        if (   !array_key_exists($node[MIDCOM_NAV_COMPONENT], $this->_request_data['components'])
62
+        if (!array_key_exists($node[MIDCOM_NAV_COMPONENT], $this->_request_data['components'])
63 63
             && $node[MIDCOM_NAV_COMPONENT] != 'midcom.helper.search') {
64 64
             $l10n = $this->_i18n->get_l10n($node[MIDCOM_NAV_COMPONENT]);
65 65
             $this->_request_data['components'][$node[MIDCOM_NAV_COMPONENT]] = $l10n->get($node[MIDCOM_NAV_COMPONENT]);
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
         }
107 107
         $this->prepare_formdata($type, $request);
108 108
 
109
-        if (   count(explode(' ', $data['query'])) == 1
109
+        if (count(explode(' ', $data['query'])) == 1
110 110
             && !str_contains($data['query'], '*')
111 111
             && $this->_config->get('single_term_auto_wildcard')) {
112 112
             //If there is only one search term append * to the query if auto_wildcard is enabled
Please login to merge, or discard this patch.
src/midcom/console/command/cacheinvalidate.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,8 @@
 block discarded – undo
44 44
     {
45 45
         try {
46 46
             $this->cache->invalidate_all();
47
-        } catch (\Throwable $e) {
47
+        }
48
+        catch (\Throwable $e) {
48 49
             $output->writeln($e->getMessage());
49 50
         }
50 51
 
Please login to merge, or discard this patch.
lib/midcom/services/rcs/handler.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
     {
47 47
         $this->object = $this->load_object($guid);
48 48
 
49
-        if (   !midcom::get()->config->get('midcom_services_rcs_enable')
49
+        if (!midcom::get()->config->get('midcom_services_rcs_enable')
50 50
             || !$this->object->_use_rcs) {
51 51
             throw new midcom_error_notfound("Revision control not supported for " . get_class($this->object) . ".");
52 52
         }
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
             throw new midcom_error_notfound("Revision {$args[1]} does not exist.");
258 258
         }
259 259
 
260
-        $data['preview'] = array_filter($this->backend->get_revision($revision), function ($value, $key) {
260
+        $data['preview'] = array_filter($this->backend->get_revision($revision), function($value, $key) {
261 261
             return !is_array($value)
262 262
                 && !in_array($value, ['', '0000-00-00'])
263 263
                 && midcom_services_rcs::is_field_showable($key);
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
         $this->object->require_do('midgard:update');
288 288
         // TODO: set another privilege for restoring?
289 289
 
290
-        if (   $this->backend->get_history()->version_exists($args[1])
290
+        if ($this->backend->get_history()->version_exists($args[1])
291 291
             && $this->backend->restore_to_revision($args[1])) {
292 292
             midcom::get()->uimessages->add($this->_l10n->get('midcom.admin.rcs'), sprintf($this->_l10n->get('restore to version %s successful'), $args[1]));
293 293
             return new midcom_response_relocate($this->get_object_url());
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/deleted.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
                 'purge' => true
63 63
             ]
64 64
         ]);
65
-        if (   midcom::get()->config->get('midcom_services_rcs_enable')
65
+        if (midcom::get()->config->get('midcom_services_rcs_enable')
66 66
             && $object->can_do('midgard:update')
67 67
             && $object->_use_rcs) {
68 68
             $this->_request_data['asgard_toolbar']->add_item([
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/rcs.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
             return parent::load_object($guid);
30 30
         } catch (midcom_error_midgard $e) {
31 31
             $mgd_exception = $e->getPrevious();
32
-            if (   $mgd_exception
32
+            if ($mgd_exception
33 33
                 && $mgd_exception->getCode() == mgd_exception::OBJECT_DELETED) {
34 34
                 return $this->load_deleted($guid);
35 35
             }
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,8 @@
 block discarded – undo
27 27
     {
28 28
         try {
29 29
             return parent::load_object($guid);
30
-        } catch (midcom_error_midgard $e) {
30
+        }
31
+        catch (midcom_error_midgard $e) {
31 32
             $mgd_exception = $e->getPrevious();
32 33
             if (   $mgd_exception
33 34
                 && $mgd_exception->getCode() == mgd_exception::OBJECT_DELETED) {
Please login to merge, or discard this patch.