@@ -61,7 +61,7 @@ |
||
| 61 | 61 | $schemadb = schemadb::from_path($this->_config->get('schemadb_salesproject')); |
| 62 | 62 | |
| 63 | 63 | if (!empty($guid)) { |
| 64 | - $field =& $schemadb->get('default')->get_field('customer'); |
|
| 64 | + $field = & $schemadb->get('default')->get_field('customer'); |
|
| 65 | 65 | try { |
| 66 | 66 | $customer = new org_openpsa_contacts_group_dba($guid); |
| 67 | 67 | $field['type_config']['options'] = [0 => '', $customer->id => $customer->official]; |
@@ -107,7 +107,7 @@ |
||
| 107 | 107 | |
| 108 | 108 | // sending per email enabled in billing data? |
| 109 | 109 | $billing_data = org_openpsa_invoices_billing_data_dba::get_by_object($this->invoice); |
| 110 | - if ( !$this->invoice->sent |
|
| 110 | + if (!$this->invoice->sent |
|
| 111 | 111 | && intval($billing_data->sendingoption) == 2) { |
| 112 | 112 | $buttons[] = $this->build_button('send_by_mail', 'paper-plane'); |
| 113 | 113 | } |
@@ -46,7 +46,7 @@ discard block |
||
| 46 | 46 | ] |
| 47 | 47 | ]); |
| 48 | 48 | |
| 49 | - $resolver->setNormalizer('constraints', function (Options $options, $value) { |
|
| 49 | + $resolver->setNormalizer('constraints', function(Options $options, $value) { |
|
| 50 | 50 | if ($options['required']) { |
| 51 | 51 | return [new constraint(['config' => $options['type_config']])]; |
| 52 | 52 | } |
@@ -78,7 +78,7 @@ discard block |
||
| 78 | 78 | |
| 79 | 79 | $builder->add('delete', CheckboxType::class, ['attr' => [ |
| 80 | 80 | "class" => "midcom_datamanager_photo_checkbox" |
| 81 | - ], "required" => false ]); |
|
| 81 | + ], "required" => false]); |
|
| 82 | 82 | $builder->add('identifier', HiddenType::class); |
| 83 | 83 | } |
| 84 | 84 | |
@@ -82,7 +82,7 @@ discard block |
||
| 82 | 82 | { |
| 83 | 83 | $entries = array_merge($this->get_status_entries(), $this->get_journal_entries()); |
| 84 | 84 | |
| 85 | - usort($entries, function ($a, $b) { |
|
| 85 | + usort($entries, function($a, $b) { |
|
| 86 | 86 | if ($a['timestamp'] == $b['timestamp']) { |
| 87 | 87 | return $b['order'] <=> $a['order']; |
| 88 | 88 | } |
@@ -116,8 +116,8 @@ discard block |
||
| 116 | 116 | 'order' => 3 |
| 117 | 117 | ]; |
| 118 | 118 | } |
| 119 | - if ( $this->invoice->due |
|
| 120 | - && ( ( $this->invoice->due < time() |
|
| 119 | + if ($this->invoice->due |
|
| 120 | + && (($this->invoice->due < time() |
|
| 121 | 121 | && $this->invoice->paid == 0) |
| 122 | 122 | || $this->invoice->due < $this->invoice->paid)) { |
| 123 | 123 | $entries[] = [ |
@@ -90,7 +90,7 @@ |
||
| 90 | 90 | $data['query'] = new org_openpsa_reports_query_dba($args[0]); |
| 91 | 91 | $data['query']->require_do('midgard:update'); |
| 92 | 92 | } else { |
| 93 | - $data['query']= new org_openpsa_reports_query_dba(); |
|
| 93 | + $data['query'] = new org_openpsa_reports_query_dba(); |
|
| 94 | 94 | $data['query']->component = $this->_component; |
| 95 | 95 | } |
| 96 | 96 | |
@@ -151,7 +151,7 @@ discard block |
||
| 151 | 151 | $contacts = $importer->parse($input); |
| 152 | 152 | if (!empty($contacts)) { |
| 153 | 153 | $this->_request_data['import_status'] = $importer->import_subscribers($contacts, $this->_request_data['campaign']); |
| 154 | - if ( $this->_request_data['import_status']['subscribed_new'] > 0 |
|
| 154 | + if ($this->_request_data['import_status']['subscribed_new'] > 0 |
|
| 155 | 155 | || $this->_request_data['import_status']['already_subscribed'] > 0) { |
| 156 | 156 | $this->_import_success = true; |
| 157 | 157 | } |
@@ -189,7 +189,7 @@ discard block |
||
| 189 | 189 | // Update the breadcrumb line |
| 190 | 190 | $this->_update_breadcrumb($handler_id, $guid); |
| 191 | 191 | |
| 192 | - if ( $request->request->has('org_openpsa_directmarketing_import') |
|
| 192 | + if ($request->request->has('org_openpsa_directmarketing_import') |
|
| 193 | 193 | && is_uploaded_file($_FILES['org_openpsa_directmarketing_import_upload']['tmp_name'])) { |
| 194 | 194 | $importer = new org_openpsa_directmarketing_importer_vcards($this->_schemadbs); |
| 195 | 195 | $this->_run_import($importer, $_FILES['org_openpsa_directmarketing_import_upload']['tmp_name']); |
@@ -244,7 +244,7 @@ discard block |
||
| 244 | 244 | $read_rows = 0; |
| 245 | 245 | $handle = fopen($data['tmp_file'], 'r'); |
| 246 | 246 | $total_columns = 0; |
| 247 | - while ( $read_rows < 2 |
|
| 247 | + while ($read_rows < 2 |
|
| 248 | 248 | && $csv_line = fgetcsv($handle, 1000, $data['separator'])) { |
| 249 | 249 | if ($total_columns == 0) { |
| 250 | 250 | $total_columns = count($csv_line); |
@@ -59,7 +59,7 @@ |
||
| 59 | 59 | |
| 60 | 60 | public function __set($name, $value) |
| 61 | 61 | { |
| 62 | - if ( $name == 'homepage' |
|
| 62 | + if ($name == 'homepage' |
|
| 63 | 63 | && !empty($value) |
| 64 | 64 | && $value != $this->homepage) { |
| 65 | 65 | $this->_register_prober = true; |
@@ -98,7 +98,7 @@ |
||
| 98 | 98 | |
| 99 | 99 | public function reverseTransform($array) |
| 100 | 100 | { |
| 101 | - if (!is_array($array) ) { |
|
| 101 | + if (!is_array($array)) { |
|
| 102 | 102 | throw new TransformationFailedException('Expected an array.'); |
| 103 | 103 | } |
| 104 | 104 | |
@@ -246,7 +246,7 @@ discard block |
||
| 246 | 246 | */ |
| 247 | 247 | public function set_assignee($assignee) : bool |
| 248 | 248 | { |
| 249 | - if ( is_a($assignee, midcom_core_user::class) |
|
| 249 | + if (is_a($assignee, midcom_core_user::class) |
|
| 250 | 250 | || is_a($assignee, midcom_core_group::class)) { |
| 251 | 251 | $this->assignee = $assignee->id; |
| 252 | 252 | } elseif (is_string($assignee)) { |
@@ -305,12 +305,12 @@ discard block |
||
| 305 | 305 | } |
| 306 | 306 | } |
| 307 | 307 | |
| 308 | - if ( !$this->is_magic_assignee() |
|
| 308 | + if (!$this->is_magic_assignee() |
|
| 309 | 309 | && !$this->get_assignee()) { |
| 310 | 310 | debug_add("The assignee identifier '{$this->assignee}' is invalid.", MIDCOM_LOG_INFO); |
| 311 | 311 | return false; |
| 312 | 312 | } |
| 313 | - if ( $this->assignee == 'OWNER' |
|
| 313 | + if ($this->assignee == 'OWNER' |
|
| 314 | 314 | && $this->privilegename == 'midgard:owner') { |
| 315 | 315 | debug_add("Tried to assign midgard:owner to the OWNER magic assignee, this is invalid.", MIDCOM_LOG_INFO); |
| 316 | 316 | return false; |
@@ -322,7 +322,7 @@ discard block |
||
| 322 | 322 | MIDCOM_LOG_INFO); |
| 323 | 323 | return false; |
| 324 | 324 | } |
| 325 | - if ( !$object->can_do('midgard:update') |
|
| 325 | + if (!$object->can_do('midgard:update') |
|
| 326 | 326 | || !$object->can_do('midgard:privileges')) { |
| 327 | 327 | debug_add("Insufficient privileges on the content object with the GUID '{$this->__guid}', midgard:update and midgard:privileges required.", |
| 328 | 328 | MIDCOM_LOG_INFO); |