flack / openpsa

lib/org/openpsa/documents/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
 
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
     {
-        if (   $object instanceof org_openpsa_documents_document_dba
+        if ($object instanceof org_openpsa_documents_document_dba
             && $object->topic == $topic->id) {
             return "document/{$object->guid}/";
         }

lib/net/nemein/wiki/style/view-wikipage-raw.php

Spacing +1 added lines, -1 removed lines

@@ -6,6 +6,6 @@
     &(view["content"]:h);
     <?php
 } else {
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
 }
 ?>
\ No newline at end of file

lib/org/openpsa/invoices/style/admin-read.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div>
     <?php } ?>
 
-    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div>
+    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div>
     <div class="description value">&(view['description']:h);</div></div>
 
     <?php

Braces +2 added lines, -1 removed lines

@@ -8,7 +8,8 @@
     if ($customer->orgOpenpsaObtype < org_openpsa_contacts_group_dba::ORGANIZATION) {
         $customer = false;
     }
-} catch (midcom_error $e) {
+}
+catch (midcom_error $e) {
     $customer = false;
 }
 

lib/org/openpsa/relatedto/style/show_entries_html.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
             <?php
             //index is needed for sorting
             echo "'index_name',";
-            echo "'" . $data['l10n']->get('entry title') ."',";
+            echo "'" . $data['l10n']->get('entry title') . "',";
             echo "'" . $data['l10n']->get('entry text') . "',";
             echo "'" . $data['l10n']->get('entry created') . "',";
             echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',";

Braces +2 added lines, -1 removed lines

@@ -25,7 +25,8 @@
             $row['creator_index'] = $creator->rname;
             $creator_card = org_openpsa_widgets_contact::get($entry->metadata->creator);
             $row['creator'] = $creator_card->show_inline();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $row['creator_index'] = '';
             $row['creator'] = '';
         }

lib/midcom/helper/reflector/main.php

Braces +2 added lines, -1 removed lines

@@ -203,7 +203,8 @@
         if ($object instanceof mgdobject) {
             try {
                 $obj = midcom::get()->dbfactory->convert_midgard_to_midcom($object);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 return null;
             }
         } else {

Spacing +3 added lines, -3 removed lines

@@ -304,7 +304,7 @@ 
 
         $label_prop = $this->get_label_property();
 
-        if (    $label_prop != 'guid'
+        if ($label_prop != 'guid'
              && $this->property_exists($label_prop)) {
             $search_properties[$label_prop] = true;
         }
@@ -354,7 +354,7 @@ 
                 continue;
             }
 
-            if (   !$this->is_link($property)
+            if (!$this->is_link($property)
                 && $this->get_midgard_type($property) != MGD_TYPE_GUID) {
                 continue;
             }
@@ -388,7 +388,7 @@ 
     protected static function class_rewrite(string $schema_type) : string
     {
         $extends = midcom_baseclasses_components_configuration::get('midcom.helper.reflector', 'config')->get_array('class_extends');
-        if (   isset($extends[$schema_type])
+        if (isset($extends[$schema_type])
             && class_exists($extends[$schema_type])) {
             return $extends[$schema_type];
         }

lib/net/nemein/rss/fetch.php

Spacing +6 added lines, -6 removed lines

@@ -87,7 +87,7 @@ 
             $etag = trim($parser->data['headers']['etag']);
 
             $feed_etag = $this->_feed->get_parameter('net.nemein.rss', 'etag');
-            if (   !empty($feed_etag)
+            if (!empty($feed_etag)
                 && $feed_etag == $etag) {
                 // Feed hasn't changed, skip updating
                 debug_add("Feed {$this->_feed->url} has not changed since " . date('c', $this->_feed->latestfetch), MIDCOM_LOG_WARN);
@@ -158,7 +158,7 @@ 
         $guid = $item->get_id();
         $title = $item->get_title();
 
-        if (   (   empty($title)
+        if ((empty($title)
                 || trim($title) == '...')
             && empty($guid)) {
             // Something wrong with this entry, skip it
@@ -223,7 +223,7 @@ 
                 $meta_values['published'] = $article_date;
             }
 
-            if (   $this->apply_values($article, $values, $meta_values)
+            if ($this->apply_values($article, $values, $meta_values)
                 && !$article->update()) {
                 return null;
             }
@@ -252,14 +252,14 @@ 
     private function find_author(net_nemein_rss_parser_item $item) : midcom_db_person
     {
         // Try to figure out item author
-        if (   $this->_feed->forceauthor
+        if ($this->_feed->forceauthor
             && $this->_feed->defaultauthor) {
             // Feed has a "default author" set, use it
             return new midcom_db_person($this->_feed->defaultauthor);
         }
         $author = $this->match_item_author($item);
         $fallback_person_id = 1;
-        if (   !$author
+        if (!$author
             || $author->id == $fallback_person_id) {
             if ($this->_feed->defaultauthor) {
                 // Feed has a "default author" set, use it
@@ -429,7 +429,7 @@ 
             }
         }
 
-        if (   !empty($author_info['username'])
+        if (!empty($author_info['username'])
             && $person = midcom::get()->auth->get_user_by_name($author_info['username'])) {
             return $person->get_storage();
         }

lib/midgard/admin/asgard/handler/object/attachments.php

Spacing +3 added lines, -3 removed lines

@@ -98,13 +98,13 @@ 
         }
 
         $mimetype = $request->request->get('midgard_admin_asgard_mimetype');
-        if (   !empty($mimetype)
+        if (!empty($mimetype)
             && $local_file->mimetype != $mimetype) {
             $local_file->mimetype = $mimetype;
             $needs_update = true;
         }
 
-        if (   $needs_update
+        if ($needs_update
             && !$local_file->update()) {
             return null;
         }
@@ -234,7 +234,7 @@ 
         $this->bind_view_to_object($this->_file);
 
         $filename = $this->_process_form($request);
-        if (   $filename
+        if ($filename
             && $filename != $data['filename']) {
             return $this->relocate_to_file($filename);
         }

lib/org/openpsa/slideshow/image.php

Braces +4 added lines, -2 removed lines

@@ -48,7 +48,8 @@ 
 
         try {
             $folder = midcom_db_topic::get_cached($this->topic);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         $folder->delete_attachment(self::FOLDER_THUMBNAIL);
@@ -58,7 +59,8 @@ 
     {
         try {
             return new midcom_db_attachment($this->$type);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return null;
         }

lib/org/openpsa/relatedto/plugin.php

Braces +2 added lines, -1 removed lines

@@ -104,7 +104,8 @@
     {
         $ret = ['org_openpsa_relatedto' => []];
         foreach ($array as $rel) {
-            if (!midcom::get()->dbfactory->is_a($rel, org_openpsa_relatedto_dba::class)) { //Matches also 'org_openpsa_relatedto'
+            if (!midcom::get()->dbfactory->is_a($rel, org_openpsa_relatedto_dba::class)) {
+//Matches also 'org_openpsa_relatedto'
                 //Wrong type of object found in array, cruelly abort the whole procedure
                 return null;
             }