flack / openpsa

lib/org/openpsa/contacts/handler/person/view.php

Spacing +4 added lines, -4 removed lines

@@ -110,7 +110,7 @@ 
         $invoices_url = $siteconfig->get_node_full_url('org.openpsa.invoices');
         $user_url = $siteconfig->get_node_full_url('org.openpsa.user');
 
-        if (   $invoices_url
+        if ($invoices_url
             && midcom::get()->auth->can_user_do('midgard:create', null, 'org_openpsa_invoices_invoice_dba')
             && $this->_contact->can_do('midgard:update')) {
             $buttons[] = $workflow->get_button($invoices_url . "billingdata/" . $this->_contact->guid . '/', array(
@@ -118,8 +118,8 @@ 
             ));
         }
 
-        if (   $user_url
-            && (   midcom_connection::get_user() == $this->_contact->id
+        if ($user_url
+            && (midcom_connection::get_user() == $this->_contact->id
                 || midcom::get()->auth->can_user_do('org.openpsa.user:access', null, 'org_openpsa_user_interface'))) {
             $buttons[] = array(
                 MIDCOM_TOOLBAR_URL => $user_url . "view/{$this->_contact->guid}/",
@@ -197,7 +197,7 @@ 
      */
     public function _show_group_memberships($handler_id, array &$data)
     {
-        if (   count($data['organizations']) == 0
+        if (count($data['organizations']) == 0
             && count($data['groups']) == 0) {
             midcom_show_style('show-person-groups-empty');
         } else {

Braces +2 added lines, -1 removed lines

@@ -216,7 +216,8 @@
         foreach ($this->_request_data[$identifier] as $member) {
             try {
                 $this->_request_data['group'] = org_openpsa_contacts_group_dba::get_cached($member->gid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
                 continue;
             }

lib/org/openpsa/contacts/handler/person/admin.php

Spacing +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
     {
         $this->_load_schemadb();
         $this->_controller = midcom_helper_datamanager2_controller::create('simple');
-        $this->_controller->schemadb =& $this->_schemadb;
+        $this->_controller->schemadb = & $this->_schemadb;
         $this->_controller->set_storage($this->_contact, $this->_schema);
         if (!$this->_controller->initialize()) {
             throw new midcom_error("Failed to initialize a DM2 controller instance for contact {$this->_contact->id}.");

lib/org/openpsa/contacts/handler/group/view.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
             );
         }
 
-        if (   midcom::get()->auth->can_user_do('midgard:create', null, 'org_openpsa_contacts_person_dba')
+        if (midcom::get()->auth->can_user_do('midgard:create', null, 'org_openpsa_contacts_person_dba')
             && $this->group->can_do('midgard:create')) {
             $buttons[] = $workflow->get_button("person/create/{$this->group->guid}/", array(
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('create person'),
@@ -68,7 +68,7 @@ 
 
         $siteconfig = org_openpsa_core_siteconfig::get_instance();
         $user_url = $siteconfig->get_node_full_url('org.openpsa.user');
-        if (   $user_url
+        if ($user_url
             && midcom::get()->auth->can_user_do('org.openpsa.user:access', null, 'org_openpsa_user_interface')) {
             $buttons[] = array(
                 MIDCOM_TOOLBAR_URL => $user_url . "group/{$this->group->guid}/",

lib/org/openpsa/reports/handler/base.php

Spacing +6 added lines, -6 removed lines

@@ -42,7 +42,7 @@ 
     public function _handler_generator_get($handler_id, array $args, array &$data)
     {
         midcom::get()->auth->require_valid_user();
-        if (   !array_key_exists('org_openpsa_reports_query_data', $_REQUEST)
+        if (!array_key_exists('org_openpsa_reports_query_data', $_REQUEST)
             || !is_array($_REQUEST['org_openpsa_reports_query_data'])) {
             throw new midcom_error('query data not present or invalid');
         }
@@ -89,7 +89,7 @@ 
     private function _load_edit_controller()
     {
         $this->_controller = midcom_helper_datamanager2_controller::create('simple');
-        $this->_controller->schemadb =& $this->_schemadb;
+        $this->_controller->schemadb = & $this->_schemadb;
         $this->_controller->set_storage($this->_request_data['query'], 'default');
         if (!$this->_controller->initialize()) {
             throw new midcom_error("Failed to initialize a DM2 controller instance for document {$this->_document->id}.");
@@ -132,9 +132,9 @@ 
     {
         $this->_load_schemadb();
         $this->_controller = midcom_helper_datamanager2_controller::create('create');
-        $this->_controller->schemadb =& $this->_schemadb;
+        $this->_controller->schemadb = & $this->_schemadb;
         $this->_controller->schemaname = 'default';
-        $this->_controller->callback_object =& $this;
+        $this->_controller->callback_object = & $this;
         if (!$this->_controller->initialize()) {
             throw new midcom_error("Failed to initialize a DM2 create controller.");
         }
@@ -172,9 +172,9 @@ 
         $this->_request_data['datamanager'] = $this->_datamanagers[$this->module];
 
         if (isset($data['query'])) {
-            $breadcrumb_label =  sprintf($this->_l10n->get('edit report %s'), $data['query']->title);
+            $breadcrumb_label = sprintf($this->_l10n->get('edit report %s'), $data['query']->title);
         } else {
-            $breadcrumb_label =  $this->_l10n->get('define custom report');
+            $breadcrumb_label = $this->_l10n->get('define custom report');
         }
         $this->add_breadcrumb("", $breadcrumb_label);
     }

lib/org/openpsa/reports/handler/sales/report.php

Braces +2 added lines, -1 removed lines

@@ -71,7 +71,8 @@
             $owner = org_openpsa_contacts_person_dba::get_cached($salesproject->owner);
             $row['index_owner'] = $owner->name;
             $row['owner'] = org_openpsa_widgets_contact::get($owner->guid)->show_inline();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         $row['amount'] = $object->pricePerUnit * $object->units;

lib/org/openpsa/helpers/list.php

Braces +2 added lines, -1 removed lines

@@ -69,7 +69,8 @@
         if (empty(self::$_seen[$company_id])) {
             try {
                 $company = new org_openpsa_contacts_group_dba($company_id);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 return;
             }
             self::$_seen[$company->id] = true;

lib/org/openpsa/expenses/handler/csv.php

Spacing +3 added lines, -3 removed lines

@@ -17,7 +17,7 @@ 
 
     public function _load_schemadbs($handler_id, &$args, &$data)
     {
-        if (   isset($_GET['filename'])
+        if (isset($_GET['filename'])
             && is_string($_GET['filename'])
             && strpos($_GET['filename'], '.csv')) {
             $data['filename'] = $_GET['filename'];
@@ -28,14 +28,14 @@ 
     public function _load_data($handler_id, &$args, &$data)
     {
         midcom::get()->auth->require_valid_user();
-        if (   empty($_POST['guids'])
+        if (empty($_POST['guids'])
             || !is_array($_POST['guids'])) {
             throw new midcom_error("No GUIDs found, aborting.");
         }
 
         $qb = org_openpsa_projects_hour_report_dba::new_query_builder();
         $qb->add_constraint('guid', 'IN', $_POST['guids']);
-        if (   isset($_POST['order'])
+        if (isset($_POST['order'])
             && is_array($_POST['order'])) {
             foreach ($_POST['order'] as $field => $order) {
                 $qb->add_order($field, $order);

lib/org/openpsa/core/siteconfig.php

Spacing +1 added lines, -1 removed lines

@@ -174,7 +174,7 @@
         }
         if (!midcom::get()->auth->admin) {
             $user_id = midcom::get()->auth->acl->get_user_id();
-            if (   !$this->data[$type . '_guid']
+            if (!$this->data[$type . '_guid']
                 || !midcom::get()->auth->acl->can_do_byguid('midgard:read', $this->data[$type . '_guid'], 'midcom_db_topic', $user_id)) {
                 return null;
             }

lib/org/openpsa/products/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
      */
     public function _on_reindex($topic, $config, &$indexer)
     {
-        if (   !$config->get('index_products')
+        if (!$config->get('index_products')
             && !$config->get('index_groups')) {
             debug_add("No indexing to groups and products, skipping", MIDCOM_LOG_WARN);
             return true;