flack / openpsa

lib/midgard/admin/user/handler/group/list.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
                 midcom::get()->uimessages->add($this->_l10n->get('midgard.admin.user'), $this->_l10n_midcom->get('updated'));
                 return new midcom_response_relocate("__mfa/asgard_midgard.admin.user/group/edit/{$data['group']->guid}/");
             }
-            debug_add('Failed to update the group, last error was '. midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
+            debug_add('Failed to update the group, last error was ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
             debug_print_r('We operated on this object', $data['group'], MIDCOM_LOG_ERROR);
 
             throw new midcom_error('Failed to update the group, see error level log for details');

lib/midgard/admin/user/handler/group/create.php

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
         $this->_group = new midcom_db_group();
         if (!$this->_group->create()) {
             debug_print_r('We operated on this object:', $this->_group);
-            throw new midcom_error('Failed to create a new group. Last Midgard error was: '. midcom_connection::get_error_string());
+            throw new midcom_error('Failed to create a new group. Last Midgard error was: ' . midcom_connection::get_error_string());
         }
 
         return $this->_group;

lib/midgard/admin/user/handler/user/create.php

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
         $this->_person = new midcom_db_person();
         if (!$this->_person->create()) {
             debug_print_r('We operated on this object:', $this->_person);
-            throw new midcom_error('Failed to create a new person. Last Midgard error was: '. midcom_connection::get_error_string());
+            throw new midcom_error('Failed to create a new person. Last Midgard error was: ' . midcom_connection::get_error_string());
         }
 
         return $this->_person;

lib/midgard/admin/user/validator.php

Spacing +2 added lines, -2 removed lines

@@ -27,8 +27,8 @@
         if (!empty($fields["username"])) {
             $user = midcom::get()->auth->get_user_by_name($fields["username"]);
 
-            if (   $user
-                && (   !isset($fields['person'])
+            if ($user
+                && (!isset($fields['person'])
                     || $user->guid != $fields['person'])) {
                 $result["username"] = sprintf(midcom::get()->i18n->get_string("username %s is already in use", "midgard.admin.user"), $fields['username']);
             }

lib/org/openpsa/projects/midcom/indexer.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
  */
 class org_openpsa_projects_midcom_indexer extends midcom_helper_datamanager2_indexer_client
 {
-    public function prepare_document(midcom_services_indexer_document &$document, midcom_helper_datamanager2_datamanager $dm)
+    public function prepare_document(midcom_services_indexer_document & $document, midcom_helper_datamanager2_datamanager $dm)
     {
         $document->title = $dm->storage->object->get_label();
         if (is_a($dm->storage->object, 'org_openpsa_projects_task_dba')) {

lib/org/openpsa/projects/handler/workflow.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     {
         midcom::get()->auth->require_valid_user();
         //Look for action among POST variables, then load main handler...
-        if (   empty($_POST['org_openpsa_projects_workflow_action'])
+        if (empty($_POST['org_openpsa_projects_workflow_action'])
             || !is_array($_POST['org_openpsa_projects_workflow_action'])) {
             throw new midcom_error('Incomplete request');
         }

lib/org/openpsa/projects/handler/task/crud.php

Spacing +2 added lines, -2 removed lines

@@ -39,7 +39,7 @@ 
      */
     public function _populate_toolbar($handler_id)
     {
-        if (   $this->_mode == 'read'
+        if ($this->_mode == 'read'
             && $this->_object->can_do('midgard:update')) {
             $this->_populate_read_toolbar();
             org_openpsa_widgets_ui::enable_ui_tab();
@@ -79,7 +79,7 @@ 
             MIDCOM_TOOLBAR_ACCESSKEY => 'e',
         ));
 
-        if (   $this->_object->reportedHours == 0
+        if ($this->_object->reportedHours == 0
             && $this->_object->can_do('midgard:delete')) {
             $delete_workflow = $this->get_workflow('delete', array('object' => $this->_object));
             $buttons[] = $delete_workflow->get_button("task/delete/{$this->_object->guid}/");

Braces +6 added lines, -3 removed lines

@@ -121,7 +121,8 @@ 
                     );
                 }
 
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
             }
         }
 
@@ -151,7 +152,8 @@ 
             // This task is to be connected to a project
             try {
                 $this->_parent = new org_openpsa_projects_project($args[1]);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 return false;
             }
 
@@ -163,7 +165,8 @@ 
         } elseif ($this->_mode == 'delete') {
             try {
                 $this->_parent = new org_openpsa_projects_project($this->_object->project);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/org/openpsa/projects/task/resource.php

Spacing +4 added lines, -4 removed lines

@@ -26,12 +26,12 @@
     private function _find_duplicates()
     {
         $qb = org_openpsa_projects_task_resource_dba::new_query_builder();
-        $qb->add_constraint('person', '=', (int)$this->person);
-        $qb->add_constraint('task', '=', (int)$this->task);
-        $qb->add_constraint('orgOpenpsaObtype', '=', (int)$this->orgOpenpsaObtype);
+        $qb->add_constraint('person', '=', (int) $this->person);
+        $qb->add_constraint('task', '=', (int) $this->task);
+        $qb->add_constraint('orgOpenpsaObtype', '=', (int) $this->orgOpenpsaObtype);
 
         if ($this->id) {
-            $qb->add_constraint('id', '<>', (int)$this->id);
+            $qb->add_constraint('id', '<>', (int) $this->id);
         }
 
         return ($qb->count() > 0);

lib/org/openpsa/relatedto/suspect.php

Spacing +3 added lines, -3 removed lines

@@ -91,7 +91,7 @@ 
     {
         $properties = array('fromClass', 'toClass', 'fromGuid', 'toGuid', 'fromComponent', 'toComponent', 'status', 'toExtra', 'toExtra');
         foreach ($properties as $property) {
-            if (   !empty($defaults->$property)
+            if (!empty($defaults->$property)
                 && empty($link->$property)) {
                 debug_add("Copying property '{$property}' ('{$defaults->$property}') from defaults");
                 $link->$property = $defaults->$property;
@@ -99,7 +99,7 @@ 
         }
         if ($component) {
             debug_add('$component given, guessing direction');
-            if (   empty($link->toComponent)
+            if (empty($link->toComponent)
                 && !empty($link->fromComponent)) {
                 debug_add("Setting property 'toComponent' to '{$component}'");
                 $link->toComponent = $component;
@@ -110,7 +110,7 @@ 
         }
         if (is_object($obj)) {
             debug_add('$obj given, guessing direction');
-            if (   empty($link->toGuid)
+            if (empty($link->toGuid)
                 && !empty($link->fromGuid)) {
                 $link->toClass = get_class($obj);
                 $link->toGuid = $obj->guid;