flack / openpsa

lib/midgard/admin/asgard/handler/object/attachments.php

Spacing +5 added lines, -5 removed lines

@@ -67,7 +67,7 @@ 
         }
 
         // Check if we have an uploaded file
-        if (   isset($_FILES['midgard_admin_asgard_file'])
+        if (isset($_FILES['midgard_admin_asgard_file'])
             && is_uploaded_file($_FILES['midgard_admin_asgard_file']['tmp_name'])) {
             return $this->_process_file_upload($_FILES['midgard_admin_asgard_file']);
         }
@@ -86,19 +86,19 @@ 
 
         $needs_update = false;
 
-        if (   !empty($_POST['midgard_admin_asgard_filename'])
+        if (!empty($_POST['midgard_admin_asgard_filename'])
             && $local_file->name != $_POST['midgard_admin_asgard_filename']) {
             $local_file->name = $_POST['midgard_admin_asgard_filename'];
             $needs_update = true;
         }
 
-        if (   !empty($_POST['midgard_admin_asgard_mimetype'])
+        if (!empty($_POST['midgard_admin_asgard_mimetype'])
             && $local_file->mimetype != $_POST['midgard_admin_asgard_mimetype']) {
             $local_file->mimetype = $_POST['midgard_admin_asgard_mimetype'];
             $needs_update = true;
         }
 
-        if (   $needs_update
+        if ($needs_update
             && !$local_file->update()) {
             return false;
         }
@@ -232,7 +232,7 @@ 
         $this->bind_view_to_object($this->_file);
 
         $filename = $this->_process_form();
-        if (   $filename
+        if ($filename
             && $filename != $data['filename']) {
             return new midcom_response_relocate("__mfa/asgard/object/attachments/{$this->_object->guid}/{$filename}/");
         }

lib/midgard/admin/asgard/handler/object/permissions.php

Spacing +4 added lines, -4 removed lines

@@ -100,7 +100,7 @@ 
         $tmp = $this->_object;
 
         $i = 0;
-        while (   !empty($tmp->guid)
+        while (!empty($tmp->guid)
                && !midcom::get()->dbfactory->is_a($tmp, 'midgard_topic')
                && $i < 100) {
             // Get the parent; wishing eventually to get a topic
@@ -196,7 +196,7 @@ 
         foreach ($assignees as $assignee => $label) {
             foreach ($this->_privileges as $privilege) {
                 $privilege_components = explode(':', $privilege);
-                if (   $privilege_components[0] == 'midcom'
+                if ($privilege_components[0] == 'midcom'
                     || $privilege_components[0] == 'midgard') {
                     // This is one of the core privileges, we handle it
                     $privilege_label = $privilege;
@@ -250,7 +250,7 @@ 
                 if (is_object($assignee)) {
                     $label = $assignee->name;
                 } else {
-                    $label = $this->_l10n->get('ghost assignee for '. $privilege->assignee);
+                    $label = $this->_l10n->get('ghost assignee for ' . $privilege->assignee);
                 }
             }
 
@@ -405,7 +405,7 @@ 
     private function _render_row_label($row_name)
     {
         foreach ($this->_row_labels as $key => $label) {
-            if (   strpos($row_name, $key) !== false
+            if (strpos($row_name, $key) !== false
                 && !isset($this->_rendered_row_labels[$key])) {
                 $this->_rendered_row_labels[$key] = true;
 

lib/midgard/admin/asgard/handler/type.php

Spacing +2 added lines, -2 removed lines

@@ -109,8 +109,8 @@
         }
 
         $help = new midcom_admin_help_help();
-        $this->_request_data['help'] =  $help->get_help_contents('asgard_'.$this->type, $help_component);
-        $this->_request_data['component'] =  $component;
+        $this->_request_data['help'] = $help->get_help_contents('asgard_' . $this->type, $help_component);
+        $this->_request_data['component'] = $component;
     }
 
     /**

lib/midgard/admin/asgard/handler/shell.php

Spacing +2 added lines, -2 removed lines

@@ -36,10 +36,10 @@
                 break;
 
             case 'edit':
-                if (   $controller->formmanager->form->isSubmitted()
+                if ($controller->formmanager->form->isSubmitted()
                     && !empty($controller->datamanager->validation_errors)) {
                     foreach ($controller->datamanager->validation_errors as $field => $error) {
-                        $element =& $controller->formmanager->form->getElement($field);
+                        $element = & $controller->formmanager->form->getElement($field);
                         $message = sprintf($this->_l10n->get('validation error in field %s: %s'), $element->getLabel(), $error);
                         midcom::get()->uimessages->add(
                                 $this->_l10n->get('midgard.admin.asgard'),

lib/midgard/admin/asgard/handler/welcome.php

Spacing +6 added lines, -6 removed lines

@@ -20,7 +20,7 @@ 
 
         // List installed MgdSchema types and convert to DBA classes
         foreach ($this->_request_data['schema_types'] as $schema_type) {
-            if (   !is_null($type)
+            if (!is_null($type)
                 && $schema_type != $type) {
                 // Skip
                 continue;
@@ -49,7 +49,7 @@ 
                 $qb->add_constraint('metadata.revised', '>=', $since);
             }
 
-            if (   $only_mine
+            if ($only_mine
                 && midcom::get()->auth->user) {
                 $qb->add_constraint('metadata.authors', 'LIKE', '|' . midcom::get()->auth->user->guid . '|');
             }
@@ -93,7 +93,7 @@ 
 
         $data['view_title'] = $this->_l10n->get('asgard');
 
-        if (    isset($_POST['execute_mass_action'])
+        if (isset($_POST['execute_mass_action'])
              && !empty($_POST['selections'])
              && isset($_POST['mass_action'])) {
             $method_name = "_mass_{$_POST['mass_action']}";
@@ -108,14 +108,14 @@ 
             }
 
             $data['review_by'] = null;
-            if (   $this->_config->get('enable_review_dates')
+            if ($this->_config->get('enable_review_dates')
                 && isset($_REQUEST['review_by'])
                 && $_REQUEST['review_by'] != 'any') {
                 $data['review_by'] = (int) $_REQUEST['review_by'];
             }
 
             $data['type_filter'] = null;
-            if (   isset($_REQUEST['type_filter'])
+            if (isset($_REQUEST['type_filter'])
                 && $_REQUEST['type_filter'] != 'any') {
                 $data['type_filter'] = $_REQUEST['type_filter'];
             }
@@ -274,7 +274,7 @@ 
                 continue;
             }
 
-            if (   $object->can_do('midgard:update')
+            if ($object->can_do('midgard:update')
                 && $object->can_do('midcom:approve')) {
                 $object->metadata->approve();
                 midcom::get()->uimessages->add($this->_l10n->get('midgard.admin.asgard'), sprintf($this->_l10n->get('object %s approved'), $object->guid));

Braces +8 added lines, -4 removed lines

@@ -147,7 +147,8 @@ 
         foreach ($activities as $activity) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($activity->target);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 if (midcom_connection::get_error() == MGD_ERR_OBJECT_DELETED) {
                     // TODO: Visualize deleted objects somehow
                 }
@@ -155,7 +156,8 @@ 
             }
             try {
                 $actor = midcom_db_person::get_cached($activity->actor);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $actor = null;
             }
 
@@ -253,7 +255,8 @@ 
         foreach ($guids as $guid) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 continue;
             }
 
@@ -270,7 +273,8 @@ 
         foreach ($guids as $guid) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 continue;
             }
 

lib/midgard/admin/asgard/plugin.php

Spacing +3 added lines, -3 removed lines

@@ -153,7 +153,7 @@ 
         }
         $data['default_mode'] = 'view';
 
-        if (   !midgard_admin_asgard_plugin::get_preference('edit_mode')
+        if (!midgard_admin_asgard_plugin::get_preference('edit_mode')
             && midcom_baseclasses_components_configuration::get('midgard.admin.asgard', 'config')->get('edit_mode') == 1) {
             $data['default_mode'] = 'edit';
         } elseif (midgard_admin_asgard_plugin::get_preference('edit_mode') == 1) {
@@ -194,7 +194,7 @@ 
 
         $parent = $object->get_parent();
 
-        if (   is_a($object, 'midcom_db_parameter')
+        if (is_a($object, 'midcom_db_parameter')
             && is_object($parent)
             && $parent->guid) {
             // Add "parameters" list to breadcrumb if we're in a param
@@ -205,7 +205,7 @@ 
         }
 
         $i = 0;
-        while (   is_object($parent)
+        while (is_object($parent)
                && $parent->guid
                && $i < 10) {
             $i++;

src/openpsa/createphp/workflow/delete.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
 {
     public function getToolbarConfig($object)
     {
-        if (    $object->can_do('midgard:delete')
+        if ($object->can_do('midgard:delete')
              && !empty($object->up)) {
             // show delete for all collection children
             return array(

src/midcom/workflow/datamanager2.php

Spacing +2 added lines, -2 removed lines

@@ -93,8 +93,8 @@
 
     private function prepare_url($url)
     {
-        if (   substr($url, 0, 1) != '/'
-            && ! preg_match('|^https?://|', $url)) {
+        if (substr($url, 0, 1) != '/'
+            && !preg_match('|^https?://|', $url)) {
             $url = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX) . $url;
         }
         return '"' . $url . '"';

src/midcom/workflow/delete.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
             ))
             ->setRequired('object')
             ->setAllowedTypes('object', 'midcom_core_dbaobject')
-            ->setNormalizer('label', function ($options, $value) {
+            ->setNormalizer('label', function($options, $value) {
                 if ($value === null) {
                     return midcom_helper_reflector::get_object_title($options['object']);
                 }