Passed
Push — master ( c790fd...b67c6a )
by Andreas
12:04
created
lib/net/nemein/wiki/style/view-wikipage-raw.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,6 +6,6 @@
 block discarded – undo
6 6
     &(view["content"]:h);
7 7
     <?php
8 8
 } else {
9
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
9
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
10 10
 }
11 11
 ?>
12 12
\ No newline at end of file
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/style/admin-read.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
         <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div>
35 35
     <?php } ?>
36 36
 
37
-    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div>
37
+    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div>
38 38
     <div class="description value">&(view['description']:h);</div></div>
39 39
 
40 40
     <?php
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,8 @@
 block discarded – undo
8 8
     if ($customer->orgOpenpsaObtype < org_openpsa_contacts_group_dba::ORGANIZATION) {
9 9
         $customer = false;
10 10
     }
11
-} catch (midcom_error $e) {
11
+}
12
+catch (midcom_error $e) {
12 13
     $customer = false;
13 14
 }
14 15
 
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/style/show_entries_html.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
             <?php
47 47
             //index is needed for sorting
48 48
             echo "'index_name',";
49
-            echo "'" . $data['l10n']->get('entry title') ."',";
49
+            echo "'" . $data['l10n']->get('entry title') . "',";
50 50
             echo "'" . $data['l10n']->get('entry text') . "',";
51 51
             echo "'" . $data['l10n']->get('entry created') . "',";
52 52
             echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',";
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,8 @@
 block discarded – undo
25 25
             $row['creator_index'] = $creator->rname;
26 26
             $creator_card = org_openpsa_widgets_contact::get($entry->metadata->creator);
27 27
             $row['creator'] = $creator_card->show_inline();
28
-        } catch (midcom_error $e) {
28
+        }
29
+        catch (midcom_error $e) {
29 30
             $row['creator_index'] = '';
30 31
             $row['creator'] = '';
31 32
         }
Please login to merge, or discard this patch.
lib/midcom/helper/reflector/main.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -203,7 +203,8 @@
 block discarded – undo
203 203
         if ($object instanceof mgdobject) {
204 204
             try {
205 205
                 $obj = midcom::get()->dbfactory->convert_midgard_to_midcom($object);
206
-            } catch (midcom_error $e) {
206
+            }
207
+            catch (midcom_error $e) {
207 208
                 return null;
208 209
             }
209 210
         } else {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
 
305 305
         $label_prop = $this->get_label_property();
306 306
 
307
-        if (    $label_prop != 'guid'
307
+        if ($label_prop != 'guid'
308 308
              && $this->property_exists($label_prop)) {
309 309
             $search_properties[$label_prop] = true;
310 310
         }
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
                 continue;
355 355
             }
356 356
 
357
-            if (   !$this->is_link($property)
357
+            if (!$this->is_link($property)
358 358
                 && $this->get_midgard_type($property) != MGD_TYPE_GUID) {
359 359
                 continue;
360 360
             }
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
     protected static function class_rewrite(string $schema_type) : string
389 389
     {
390 390
         $extends = midcom_baseclasses_components_configuration::get('midcom.helper.reflector', 'config')->get_array('class_extends');
391
-        if (   isset($extends[$schema_type])
391
+        if (isset($extends[$schema_type])
392 392
             && class_exists($extends[$schema_type])) {
393 393
             return $extends[$schema_type];
394 394
         }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/attachments.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -98,13 +98,13 @@  discard block
 block discarded – undo
98 98
         }
99 99
 
100 100
         $mimetype = $request->request->get('midgard_admin_asgard_mimetype');
101
-        if (   !empty($mimetype)
101
+        if (!empty($mimetype)
102 102
             && $local_file->mimetype != $mimetype) {
103 103
             $local_file->mimetype = $mimetype;
104 104
             $needs_update = true;
105 105
         }
106 106
 
107
-        if (   $needs_update
107
+        if ($needs_update
108 108
             && !$local_file->update()) {
109 109
             return null;
110 110
         }
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
         $this->bind_view_to_object($this->_file);
235 235
 
236 236
         $filename = $this->_process_form($request);
237
-        if (   $filename
237
+        if ($filename
238 238
             && $filename != $data['filename']) {
239 239
             return $this->relocate_to_file($filename);
240 240
         }
Please login to merge, or discard this patch.
lib/org/openpsa/slideshow/image.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,8 @@  discard block
 block discarded – undo
48 48
 
49 49
         try {
50 50
             $folder = midcom_db_topic::get_cached($this->topic);
51
-        } catch (midcom_error $e) {
51
+        }
52
+        catch (midcom_error $e) {
52 53
             $e->log();
53 54
         }
54 55
         $folder->delete_attachment(self::FOLDER_THUMBNAIL);
@@ -58,7 +59,8 @@  discard block
 block discarded – undo
58 59
     {
59 60
         try {
60 61
             return new midcom_db_attachment($this->$type);
61
-        } catch (midcom_error $e) {
62
+        }
63
+        catch (midcom_error $e) {
62 64
             $e->log();
63 65
             return null;
64 66
         }
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/plugin.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -104,7 +104,8 @@
 block discarded – undo
104 104
     {
105 105
         $ret = ['org_openpsa_relatedto' => []];
106 106
         foreach ($array as $rel) {
107
-            if (!midcom::get()->dbfactory->is_a($rel, org_openpsa_relatedto_dba::class)) { //Matches also 'org_openpsa_relatedto'
107
+            if (!midcom::get()->dbfactory->is_a($rel, org_openpsa_relatedto_dba::class)) {
108
+//Matches also 'org_openpsa_relatedto'
108 109
                 //Wrong type of object found in array, cruelly abort the whole procedure
109 110
                 return null;
110 111
             }
Please login to merge, or discard this patch.
lib/midcom/helper/reflector/copy.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
         }
189 189
 
190 190
         // Override requested root object properties
191
-        if (   !empty($this->target->guid)
191
+        if (!empty($this->target->guid)
192 192
             && $target->guid === $this->target->guid) {
193 193
             foreach ($this->root_object_values as $name => $value) {
194 194
                 $target->$name = $value;
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
     {
242 242
         if ($this->$type) {
243 243
             $method = 'copy_' . $type;
244
-            if (   !$this->$method($source, $target)
244
+            if (!$this->$method($source, $target)
245 245
                 && $this->halt_on_errors) {
246 246
                 $this->errors[] = $this->_l10n->get('failed to copy ' . $type);
247 247
                 return false;
Please login to merge, or discard this patch.
lib/midcom/core/dbaobject.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
             }
95 95
             $this->set_object($id);
96 96
         } else {
97
-            if (   is_int($id)
97
+            if (is_int($id)
98 98
                 && $id < 1) {
99 99
                 throw new midcom_error($id . ' is not a valid database ID');
100 100
             }
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
             }
109 109
 
110 110
             //Some useful information for performance tuning
111
-            if (   midcom::get()->config->get('log_level') >= MIDCOM_LOG_DEBUG
111
+            if (midcom::get()->config->get('log_level') >= MIDCOM_LOG_DEBUG
112 112
                 && $this->__object->guid) {
113 113
                 static $guids = [];
114 114
                 static $total = 0;
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,8 @@
 block discarded – undo
102 102
             try {
103 103
                 $mgdschemaclass = $this->__mgdschema_class_name__;
104 104
                 $this->set_object(new $mgdschemaclass($id));
105
-            } catch (mgd_exception $e) {
105
+            }
106
+            catch (mgd_exception $e) {
106 107
                 debug_add('Constructing ' . $this->__mgdschema_class_name__ . ' object ' . $id . ' failed, reason: ' . $e->getMessage(), MIDCOM_LOG_WARN);
107 108
                 throw new midcom_error_midgard($e, $id);
108 109
             }
Please login to merge, or discard this patch.