Passed
Push — master ( c56cec...70227f )
by Andreas
09:58
created
lib/org/openpsa/sales/style/show-deliverable-subscription.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 $state = $data['deliverable']->get_state();
4 4
 $formatter = $data['l10n']->get_formatter();
5 5
 $per_unit = $data['l10n']->get('per unit');
6
-if (   $data['product']
6
+if ($data['product']
7 7
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
8 8
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
9 9
 }
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         </div>
125 125
         <?php
126 126
         $tabs = [];
127
-        if (   $data['invoices_url']
127
+        if ($data['invoices_url']
128 128
             && $data['deliverable']->invoiced > 0) {
129 129
             $tabs[] = [
130 130
                 'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
             ];
133 133
         }
134 134
 
135
-        if (   $data['projects_url']
135
+        if ($data['projects_url']
136 136
             && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
137 137
             && $data['product']
138 138
             && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
             }
192 192
             echo "    </tbody>\n";
193 193
             echo "</table>\n";
194
-            if (   $at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
194
+            if ($at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
195 195
                 && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)) {
196 196
                 $label = $data['l10n']->get('generate now');
197 197
                 $process_link = $data['router']->generate('deliverable_run_cycle', ['guid' => $data['deliverable']->guid]);
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -74,12 +74,12 @@
 block discarded – undo
74 74
                         <tr>
75 75
                           <td class="title"><?php echo $data['l10n']->get('cost'); ?></td>
76 76
                           <?php
77
-                          if ($data['deliverable']->costType == '%') { ?>
77
+                            if ($data['deliverable']->costType == '%') { ?>
78 78
                               <td class="numeric"><?php echo $view['costPerUnit']; ?> %</td>
79 79
                               <td class="numeric">&nbsp;</td>
80 80
                               <td class="numeric">&nbsp;</td>
81 81
                           <?php
82
-                          } else { ?>
82
+                            } else { ?>
83 83
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->costPerUnit); ?></td>
84 84
                               <td class="numeric"><?php echo $view['plannedUnits']; ?></td>
85 85
                               <td class="numeric"><?php echo $view['units']; ?></td>
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
 
40 40
         $schema_name = $args[0];
41 41
         $schemadb = $data['schemadb'];
42
-        if (   $this->_config->get('simple_name_handling')
42
+        if ($this->_config->get('simple_name_handling')
43 43
             && !midcom::get()->auth->can_user_do('midcom:urlname')) {
44 44
             foreach ($schemadb->all() as $schema) {
45 45
                 $schema->get_field('name')['readonly'] = true;
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
         $this->article->require_do('midgard:update');
52 52
 
53 53
         $schemadb = $data['schemadb'];
54
-        if (   $this->_config->get('simple_name_handling')
54
+        if ($this->_config->get('simple_name_handling')
55 55
             && !midcom::get()->auth->can_user_do('midcom:urlname')) {
56 56
             foreach ($schemadb->all() as $schema) {
57 57
                 $schema->get_field('name')['readonly'] = true;
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/handler/invoice/view.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@
 block discarded – undo
107 107
 
108 108
             // sending per email enabled in billing data?
109 109
             $billing_data = org_openpsa_invoices_billing_data_dba::get_by_object($this->invoice);
110
-            if (    !$this->invoice->sent
110
+            if (!$this->invoice->sent
111 111
                  && intval($billing_data->sendingoption) == 2) {
112 112
                 $buttons[] = $this->build_button('send_by_mail', 'paper-plane');
113 113
             }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/imageType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
             ]
47 47
         ]);
48 48
 
49
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
49
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
50 50
             if ($options['required']) {
51 51
                 return [new constraint(['config' => $options['type_config']])];
52 52
             }
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
         $builder->add('delete', CheckboxType::class, ['attr' => [
80 80
             "class" => "midcom_datamanager_photo_checkbox"
81
-        ], "required" => false ]);
81
+        ], "required" => false]);
82 82
         $builder->add('identifier', HiddenType::class);
83 83
     }
84 84
 
Please login to merge, or discard this patch.
lib/org/openpsa/reports/handler/base.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
             $data['query'] = new org_openpsa_reports_query_dba($args[0]);
91 91
             $data['query']->require_do('midgard:update');
92 92
         } else {
93
-            $data['query']= new org_openpsa_reports_query_dba();
93
+            $data['query'] = new org_openpsa_reports_query_dba();
94 94
             $data['query']->component = $this->_component;
95 95
         }
96 96
 
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/group.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 
60 60
     public function __set($name, $value)
61 61
     {
62
-        if (   $name == 'homepage'
62
+        if ($name == 'homepage'
63 63
             && !empty($value)
64 64
             && $value != $this->homepage) {
65 65
             $this->_register_prober = true;
Please login to merge, or discard this patch.
lib/org/openpsa/user/accounthelper.php 2 patches
Braces   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
         $password_length = mb_strlen($password);
320 320
 
321 321
         if ($password_length < $this->_config->get('min_password_length')) {
322
-            if ($show_ui_message){
322
+            if ($show_ui_message) {
323 323
                 midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get('password too short'), 'error');
324 324
             }
325 325
             return false;
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
         }
338 338
 
339 339
         if ($score < $this->_config->get('min_password_score')) {
340
-            if ($show_ui_message){
340
+            if ($show_ui_message) {
341 341
                 midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get('password weak'), 'error');
342 342
             }
343 343
             return false;
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
         $account = $this->get_account();
155 155
         if (!empty($new_password)) {
156 156
             //check if the new encrypted password was already used
157
-            if (   !$this->check_password_reuse($new_password, true)
157
+            if (!$this->check_password_reuse($new_password, true)
158 158
                 || !$this->check_password_strength($new_password, true)) {
159 159
                 $this->errstr = "password strength too low";
160 160
                 return false;
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
         $password_length = mb_strlen($password);
294 294
 
295 295
         if ($password_length < $this->_config->get('min_password_length')) {
296
-            if ($show_ui_message){
296
+            if ($show_ui_message) {
297 297
                 midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get('password too short'), 'error');
298 298
             }
299 299
             return false;
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
311 311
         }
312 312
 
313 313
         if ($score < $this->_config->get('min_password_score')) {
314
-            if ($show_ui_message){
314
+            if ($show_ui_message) {
315 315
                 midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get('password weak'), 'error');
316 316
             }
317 317
             return false;
@@ -439,7 +439,7 @@  discard block
 block discarded – undo
439 439
 
440 440
     public static function get_person_by_formdata(array $data)
441 441
     {
442
-        if (   empty($data['username'])
442
+        if (empty($data['username'])
443 443
             || empty($data['password'])) {
444 444
             return false;
445 445
         }
@@ -471,7 +471,7 @@  discard block
 block discarded – undo
471 471
         $max_attempts = midcom_baseclasses_components_configuration::get($component, 'config')->get('max_password_attempts');
472 472
         $timeframe = midcom_baseclasses_components_configuration::get($component, 'config')->get('password_block_timeframe_min');
473 473
 
474
-        if (   $max_attempts == 0
474
+        if ($max_attempts == 0
475 475
             || $timeframe == 0) {
476 476
             return $stat;
477 477
         }
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
          * If the maximum number of attempts is reached and the oldest attempt
494 494
          * on the stack is within our defined timeframe, we block the account
495 495
          */
496
-        if (   count($attempts) >= $max_attempts
496
+        if (count($attempts) >= $max_attempts
497 497
             && $attempts[$max_attempts - 1] >= (time() - ($timeframe * 60))) {
498 498
             $this->disable_account();
499 499
             $stat = false;
Please login to merge, or discard this patch.
lib/midcom/services/indexer/main.php 1 patch
Braces   +12 added lines, -6 removed lines patch added patch discarded remove patch
@@ -131,7 +131,8 @@  discard block
 block discarded – undo
131 131
         try {
132 132
             $this->_backend->index($documents);
133 133
             return true;
134
-        } catch (Exception $e) {
134
+        }
135
+        catch (Exception $e) {
135 136
             if ($batch) {
136 137
                 throw $e;
137 138
             }
@@ -160,7 +161,8 @@  discard block
 block discarded – undo
160 161
         try {
161 162
             $this->_backend->delete($RIs);
162 163
             return true;
163
-        } catch (Exception $e) {
164
+        }
165
+        catch (Exception $e) {
164 166
             debug_add("Deleting error: " . $e->getMessage(), MIDCOM_LOG_ERROR);
165 167
             return false;
166 168
         }
@@ -182,7 +184,8 @@  discard block
 block discarded – undo
182 184
         try {
183 185
             $this->_backend->delete_all($constraint);
184 186
             return true;
185
-        } catch (Exception $e) {
187
+        }
188
+        catch (Exception $e) {
186 189
             debug_add("Deleting error: " . $e->getMessage(), MIDCOM_LOG_ERROR);
187 190
             return false;
188 191
         }
@@ -216,7 +219,8 @@  discard block
 block discarded – undo
216 219
 
217 220
         try {
218 221
             $result_raw = $this->_backend->query($query, $filter, $options);
219
-        } catch (Exception $e) {
222
+        }
223
+        catch (Exception $e) {
220 224
             debug_add("Query error: " . $e->getMessage(), MIDCOM_LOG_ERROR);
221 225
             return $result;
222 226
         }
@@ -237,7 +241,8 @@  discard block
 block discarded – undo
237 241
             if (!empty($document->topic_guid)) {
238 242
                 try {
239 243
                     midcom_db_topic::get_cached($document->topic_guid);
240
-                } catch (midcom_error $e) {
244
+                }
245
+                catch (midcom_error $e) {
241 246
                     // Skip document, the object is hidden.
242 247
                     debug_add("Skipping the generic document {$document->title}, its topic seems to be invisible, we cannot proceed.");
243 248
                     continue;
@@ -250,7 +255,8 @@  discard block
 block discarded – undo
250 255
                 // Strip language code from end of RI if it looks like "<GUID>_<LANG>"
251 256
                 try {
252 257
                     midcom::get()->dbfactory->get_object_by_guid(preg_replace('/^([0-9a-f]{32,80})_[a-z]{2}$/', '\\1', $document->RI));
253
-                } catch (midcom_error $e) {
258
+                }
259
+                catch (midcom_error $e) {
254 260
                     // Skip document, the object is hidden, deleted or otherwise unavailable.
255 261
                     //@todo Maybe nonexistent objects should be removed from index?
256 262
                     continue;
Please login to merge, or discard this patch.