Passed
Branch master (7a7694)
by Andreas
18:25
created
src/midcom/datamanager/datamanager.php 2 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -210,8 +210,7 @@
 block discarded – undo
210 210
     {
211 211
         $ret = [];
212 212
 
213
-        foreach ($this->storage as $field => $value)
214
-        {
213
+        foreach ($this->storage as $field => $value) {
215 214
             $ret[$field] = $value->get_value();
216 215
             $config = $this->schema->get_field($field);
217 216
             if (!empty($config['type_config']['allow_multiple'])) {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
     public function set_storage(midcom_core_dbaobject $storage = null, string $schemaname = null) : self
75 75
     {
76
-        if (   $schemaname === null
76
+        if ($schemaname === null
77 77
             && !empty($storage->id)) {
78 78
             $schemaname = $storage->get_parameter('midcom.helper.datamanager2', 'schema_name');
79 79
         }
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
         }
165 165
         $name = $this->get_name($name);
166 166
 
167
-        if (   $this->form === null
167
+        if ($this->form === null
168 168
             || $this->form->getName() != $name) {
169 169
             $this->build_form($this->get_builder($name));
170 170
         }
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
     {
262 262
         $ret = true;
263 263
         foreach ($this->storage as $field) {
264
-            if (   $field instanceof recreateable
264
+            if ($field instanceof recreateable
265 265
                 && !$field->recreate()) {
266 266
                 $ret = false;
267 267
             }
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/handler/group/create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@
 block discarded – undo
72 72
 
73 73
         $this->_group = new org_openpsa_contacts_group_dba();
74 74
 
75
-        if (   $this->_type == 'organization'
75
+        if ($this->_type == 'organization'
76 76
             && $this->_parent_group) {
77 77
             $this->_group->owner = $this->_parent_group->id;
78 78
         } else {
Please login to merge, or discard this patch.
lib/org/openpsa/documents/handler/directory/create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,6 +50,6 @@
 block discarded – undo
50 50
         $indexer = new org_openpsa_documents_midcom_indexer($this->_topic);
51 51
         $indexer->index($controller->get_datamanager());
52 52
 
53
-        return $controller->get_datamanager()->get_storage()->get_value()->name. "/";
53
+        return $controller->get_datamanager()->get_storage()->get_value()->name . "/";
54 54
     }
55 55
 }
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/midcom/indexer.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -9,11 +9,11 @@
 block discarded – undo
9 9
 use midcom\datamanager\indexer\client;
10 10
 use midcom\datamanager\datamanager;
11 11
 
12
- /**
13
- * Indexer client class
14
- *
15
- * @package org.openpsa.invoices
16
- */
12
+    /**
13
+     * Indexer client class
14
+     *
15
+     * @package org.openpsa.invoices
16
+     */
17 17
 class org_openpsa_invoices_midcom_indexer extends client
18 18
 {
19 19
     public function prepare_document(midcom_services_indexer_document &$document, datamanager $dm)
Please login to merge, or discard this patch.
src/midcom/datamanager/storage/dbanode.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,8 @@
 block discarded – undo
30 30
         $this->config = $config;
31 31
     }
32 32
 
33
-    protected function cast($value) {
33
+    protected function cast($value)
34
+    {
34 35
         if ($this->config['type'] == 'number' && !is_numeric($value)) {
35 36
             $value = (float) $value;
36 37
         }
Please login to merge, or discard this patch.
lib/net/nemein/wiki/midcom/interfaces.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,8 @@
 block discarded – undo
30 30
             foreach ($result as $wikipage) {
31 31
                 try {
32 32
                     $datamanager->set_storage($wikipage);
33
-                } catch (midcom_error $e) {
33
+                }
34
+                catch (midcom_error $e) {
34 35
                     $e->log(MIDCOM_LOG_WARN);
35 36
                     continue;
36 37
                 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 
45 45
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
46 46
     {
47
-        if (   $object instanceof midcom_db_article
47
+        if ($object instanceof midcom_db_article
48 48
             && $topic->id == $object->topic) {
49 49
             if ($object->name == 'index') {
50 50
                 return '';
Please login to merge, or discard this patch.
lib/org/openpsa/user/handler/group/privileges.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 
23 23
         // Get the calendar root event
24 24
         if ($root_event = org_openpsa_calendar_interface::find_root_event()) {
25
-            $field =& $schemadb->get('default')->get_field('calendar');
25
+            $field = & $schemadb->get('default')->get_field('calendar');
26 26
             $field['type_config']['privilege_object'] = $root_event;
27 27
             $field['type_config']['assignee'] = 'group:' . $group->guid;
28 28
         }
Please login to merge, or discard this patch.
lib/org/openpsa/user/handler/person/privileges.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 
23 23
         // Get the calendar root event
24 24
         if ($root_event = org_openpsa_calendar_interface::find_root_event()) {
25
-            $field =& $schemadb->get('default')->get_field('calendar');
25
+            $field = & $schemadb->get('default')->get_field('calendar');
26 26
             $field['type_config']['privilege_object'] = $root_event;
27 27
             $field['type_config']['assignee'] = 'user:' . $person->guid;
28 28
         }
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/archive.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -409,7 +409,8 @@
 block discarded – undo
409 409
             foreach ($this->_articles as $article_counter => $article) {
410 410
                 try {
411 411
                     $data['datamanager']->set_storage($article);
412
-                } catch (midcom_error $e) {
412
+                }
413
+                catch (midcom_error $e) {
413 414
                     $e->log();
414 415
                     continue;
415 416
                 }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -131,8 +131,8 @@  discard block
 block discarded – undo
131 131
         $year_data = [];
132 132
         $first_post = $this->_compute_welcome_first_post();
133 133
         $this->_request_data['first_post'] = $first_post;
134
-        $this->_request_data['total_count'] =& $total_count;
135
-        $this->_request_data['year_data'] =& $year_data;
134
+        $this->_request_data['total_count'] = & $total_count;
135
+        $this->_request_data['year_data'] = & $year_data;
136 136
         if (!$first_post) {
137 137
             return;
138 138
         }
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
         switch ($handler_id) {
262 262
             case 'archive-year-category':
263 263
                 $category = trim(strip_tags($args[1]));
264
-                if (   $data['datamanager']->get_schema('default')->has_field('categories')
264
+                if ($data['datamanager']->get_schema('default')->has_field('categories')
265 265
                     && !$data['datamanager']->get_schema('default')->get_field('categories')['type_config']['allow_multiple']) {
266 266
                     $qb->add_constraint('extra1', '=', $category);
267 267
                 } else {
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
             throw new midcom_error_notfound("The year '{$year}' is not valid.");
346 346
         }
347 347
 
348
-        if (   $month < 1
348
+        if ($month < 1
349 349
             || $month > 12) {
350 350
             throw new midcom_error_notfound("The month {$month} is not valid.");
351 351
         }
Please login to merge, or discard this patch.