Passed
Branch master (7a7694)
by Andreas
18:25
created
lib/midcom/helper/_dbfactory.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,8 @@  discard block
 block discarded – undo
43 43
     {
44 44
         try {
45 45
             $tmp = midgard_object_class::get_object_by_guid($guid);
46
-        } catch (mgd_exception $e) {
46
+        }
47
+        catch (mgd_exception $e) {
47 48
             debug_add('Loading object by GUID ' . $guid . ' failed, reason: ' . $e->getMessage(), MIDCOM_LOG_INFO);
48 49
 
49 50
             throw new midcom_error_midgard($e, $guid);
@@ -163,7 +164,8 @@  discard block
 block discarded – undo
163 164
 
164 165
         try {
165 166
             return $this->get_cached($classname, $parent_guid);
166
-        } catch (midcom_error $e) {
167
+        }
168
+        catch (midcom_error $e) {
167 169
             return null;
168 170
         }
169 171
     }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             throw new midcom_error_midgard($e, $guid);
50 50
         }
51 51
         $person_class = midcom::get()->config->get('person_class');
52
-        if (   get_class($tmp) == 'midgard_person'
52
+        if (get_class($tmp) == 'midgard_person'
53 53
             && $person_class != 'midgard_person') {
54 54
             $tmp = new $person_class($guid);
55 55
         }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
         }
80 80
         $object = new $classname($src);
81 81
         $cache[$classname][$object->guid] = $object;
82
-        $cache[$classname][$object->id] =& $cache[$classname][$object->guid];
82
+        $cache[$classname][$object->id] = & $cache[$classname][$object->guid];
83 83
         return $cache[$classname][$object->guid];
84 84
     }
85 85
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
             return true;
128 128
         }
129 129
 
130
-        if (   isset($object->__object)
130
+        if (isset($object->__object)
131 131
             && is_object($object->__object)
132 132
             && $object->__object instanceof $class) {
133 133
             // Decorator whose MgdSchema object matches
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
             return $this->get_parent_data_uncached($object);
151 151
         });
152 152
 
153
-        if (   empty($parent_guid)
153
+        if (empty($parent_guid)
154 154
             || $parent_guid === $object->guid) {
155 155
             return null;
156 156
         }
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/event.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
         }
142 142
 
143 143
         //Check up
144
-        if (   !$this->up
144
+        if (!$this->up
145 145
             && $this->title != '__org_openpsa_calendar') {
146 146
             $root_event = org_openpsa_calendar_interface::find_root_event();
147 147
             $this->up = $root_event->id;
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 
167 167
     private function _check_timerange() : bool
168 168
     {
169
-        if (   !$this->start
169
+        if (!$this->start
170 170
             || !$this->end) {
171 171
             debug_add('Event must have start and end timestamps');
172 172
             midcom_connection::set_error(MGD_ERR_RANGE);
Please login to merge, or discard this patch.
lib/midcom/admin/folder/handler/move.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
     {
36 36
         $this->_object = midcom::get()->dbfactory->get_object_by_guid($guid);
37 37
 
38
-        if (   !is_a($this->_object, midcom_db_topic::class)
38
+        if (!is_a($this->_object, midcom_db_topic::class)
39 39
             && !is_a($this->_object, midcom_db_article::class)) {
40 40
             throw new midcom_error_notfound("Moving only topics and articles is supported.");
41 41
         }
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
             $folder = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ROOTTOPIC);
77 77
         }
78 78
 
79
-        if (   is_a($this->_object, midcom_db_topic::class)
79
+        if (is_a($this->_object, midcom_db_topic::class)
80 80
             && $folder->up == $this->_object->id) {
81 81
             $tree_disabled = true;
82 82
         }
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
             $selected = ' checked="checked"';
90 90
         }
91 91
 
92
-        if (   !is_a($this->_object, midcom_db_topic::class)
92
+        if (!is_a($this->_object, midcom_db_topic::class)
93 93
             && $folder->component !== $this->current_folder->component) {
94 94
             // Non-topic objects may only be moved under folders of same component
95 95
             $class = 'wrong_component';
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,8 @@
 block discarded – undo
47 47
                 $target = new midcom_db_topic($request->request->getInt('move_to'));
48 48
                 $this->_move_object($target);
49 49
                 midcom::get()->uimessages->add($this->_l10n->get($this->_component), sprintf($this->_l10n->get('moved %s to %s'), $this->_topic->get_label(), $target->get_label()));
50
-            } catch (midcom_error $e) {
50
+            }
51
+            catch (midcom_error $e) {
51 52
                 midcom::get()->uimessages->add($this->_l10n->get($this->_component), $e->getMessage(), 'error');
52 53
             }
53 54
         }
Please login to merge, or discard this patch.
lib/net/nemein/wiki/handler/view.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -202,9 +202,9 @@
 block discarded – undo
202 202
         $toc .= "\n<ol class=\"midcom_helper_toc_formatter level_{$current_list_level}\">\n";
203 203
         foreach ($headings[4] as $key => $heading) {
204 204
             $anchor = 'heading-' . md5($heading);
205
-            $tag_level =& $headings[3][$key];
206
-            $heading_code =& $headings[0][$key];
207
-            $heading_tag =& $headings[2][$key];
205
+            $tag_level = & $headings[3][$key];
206
+            $heading_code = & $headings[0][$key];
207
+            $heading_tag = & $headings[2][$key];
208 208
             $heading_new_code = "<a id='{$anchor}'></a>{$heading_code}";
209 209
             $content = str_replace($heading_code, $heading_new_code, $content);
210 210
             if ($current_tag_level === false) {
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/message/send.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
     {
115 115
         $nap = new midcom_helper_nav();
116 116
         $node = $nap->get_node($nap->get_current_node());
117
-        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid .'/';
117
+        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid . '/';
118 118
         $this->batch_url_base_full = $node[MIDCOM_NAV_RELATIVEURL] . 'message/send_bg/' . $data['message']->guid . '/';
119 119
         debug_add("compose_url: {$compose_url}");
120 120
         debug_add("batch_url base: {$this->batch_url_base_full}");
Please login to merge, or discard this patch.
lib/org/openpsa/products/handler/product/csv.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
 
51 51
     public function _load_data(string $handler_id, array &$args, array &$data) : array
52 52
     {
53
-        if (   empty($_POST)
53
+        if (empty($_POST)
54 54
             && $this->session->exists('POST_data')) {
55 55
             $_POST = $this->session->get('POST_data');
56 56
             $this->session->remove('POST_data');
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/person.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 
60 60
     public function __set($name, $value)
61 61
     {
62
-        if (   $name == 'homepage'
62
+        if ($name == 'homepage'
63 63
             && !empty($value)
64 64
             && $value != $this->homepage) {
65 65
             $this->_register_prober = true;
Please login to merge, or discard this patch.
src/midcom/templating/dbloader.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,8 @@
 block discarded – undo
51 51
                 if ($root_topic->style) {
52 52
                     $scope = midcom_db_style::id_from_path($root_topic->style);
53 53
                 }
54
-            } catch (midcom_error_forbidden $e) {
54
+            }
55
+            catch (midcom_error_forbidden $e) {
55 56
                 $e->log();
56 57
             }
57 58
         }
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/view.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
             ]);
49 49
         }
50 50
 
51
-        if (   $this->_article->topic === $this->_topic->id
51
+        if ($this->_article->topic === $this->_topic->id
52 52
             && $this->_article->can_do('midgard:delete')) {
53 53
             $delete = $this->get_workflow('delete', ['object' => $this->_article]);
54 54
             $buttons[] = $delete->get_button("delete/{$this->_article->guid}/");
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         if ($this->_config->get('comments_enable')) {
84 84
             if ($node = net_nehmer_comments_interface::get_node($this->_topic, $this->_config->get('comments_topic'))) {
85 85
                 $data['comments_url'] = $node[MIDCOM_NAV_RELATIVEURL] . "comment/{$this->_article->guid}";
86
-                if (   $this->_topic->can_do('midgard:update')
86
+                if ($this->_topic->can_do('midgard:update')
87 87
                     && $this->_topic->can_do('net.nehmer.comments:moderation')) {
88 88
                     net_nehmer_comments_viewer::add_head_elements();
89 89
                 }
Please login to merge, or discard this patch.