Passed
Branch master (7a7694)
by Andreas
18:25
created
lib/org/openpsa/products/midcom/interfaces.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,8 @@  discard block
 block discarded – undo
79 79
                 try {
80 80
                     $dms['group']->set_storage($group);
81 81
                     org_openpsa_products_viewer::index($dms['group'], $indexer, $topic, $config);
82
-                } catch (midcom_error $e) {
82
+                }
83
+                catch (midcom_error $e) {
83 84
                     $e->log(MIDCOM_LOG_WARN);
84 85
                 }
85 86
             }
@@ -91,7 +92,8 @@  discard block
 block discarded – undo
91 92
                     try {
92 93
                         $dms['product']->set_storage($product);
93 94
                         org_openpsa_products_viewer::index($dms['product'], $indexer, $topic, $config);
94
-                    } catch (midcom_error $e) {
95
+                    }
96
+                    catch (midcom_error $e) {
95 97
                         $e->log(MIDCOM_LOG_WARN);
96 98
                     }
97 99
                 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
      */
53 53
     public function _on_reindex($topic, midcom_helper_configuration $config, midcom_services_indexer &$indexer)
54 54
     {
55
-        if (   !$config->get('index_products')
55
+        if (!$config->get('index_products')
56 56
             && !$config->get('index_groups')) {
57 57
             debug_add("No indexing to groups and products, skipping", MIDCOM_LOG_WARN);
58 58
             return true;
Please login to merge, or discard this patch.
lib/org/openpsa/notifications/notifier/email.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
             $mail->from = $config->get('default_sender') ?: '"OpenPSA Notifier" <noreply@' . $_SERVER['SERVER_NAME'] . '>';
39 39
         }
40 40
 
41
-        $mail->subject = $message['title'] ??  'org.openpsa.notifications message (no title provided)';
41
+        $mail->subject = $message['title'] ?? 'org.openpsa.notifications message (no title provided)';
42 42
         if (array_key_exists('attachments', $message)) {
43 43
             $mail->attachments = $message['attachments'];
44 44
         }
Please login to merge, or discard this patch.
lib/org/openpsa/qbpager/style/show_pages_as_list.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
         echo "\n<li class=\"separator\"></li>";
15 15
         echo "\n<li class=\"page splitter\">...</li>";
16 16
     }
17
-    if (   $i > 0
17
+    if ($i > 0
18 18
         && $i < $total_links) {
19 19
         echo "\n<li class=\"separator\"></li>";
20 20
     }
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/handler/relatedto.php 2 patches
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -116,7 +116,8 @@  discard block
 block discarded – undo
116 116
             //TODO: check for duplicates ?
117 117
             try {
118 118
                 $result = ['other_obj' => midcom::get()->dbfactory->get_object_by_guid($link[$other . 'Guid'])];
119
-            } catch (midcom_error $e) {
119
+            }
120
+            catch (midcom_error $e) {
120 121
                 continue;
121 122
             }
122 123
             $result['link'] = [
@@ -421,7 +422,8 @@  discard block
 block discarded – undo
421 422
             if (!($this->_object instanceof org_openpsa_relatedto_dba)) {
422 423
                 $response->status = "method requires guid of a link object as an argument";
423 424
             }
424
-        } catch (midcom_error $e) {
425
+        }
426
+        catch (midcom_error $e) {
425 427
             $response->status = "error: " . $e->getMessage();
426 428
         }
427 429
 
@@ -444,7 +446,8 @@  discard block
 block discarded – undo
444 446
             $relation = new org_openpsa_relatedto_dba($guid);
445 447
             $response->result = $relation->delete();
446 448
             $response->status = 'Last message: ' . midcom_connection::get_error_string();
447
-        } catch (midcom_error $e) {
449
+        }
450
+        catch (midcom_error $e) {
448 451
             $response->result = false;
449 452
             $response->status = "Object '{$guid}' could not be loaded, error:" . $e->getMessage();
450 453
         }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -199,7 +199,7 @@
 block discarded – undo
199 199
     private function _render_line(array $link, midcom_core_dbaobject &$other_obj)
200 200
     {
201 201
         $this->_request_data['link'] = $link;
202
-        $this->_request_data['other_obj'] =& $other_obj;
202
+        $this->_request_data['other_obj'] = & $other_obj;
203 203
         $this->_request_data['icon'] = midcom_helper_reflector::get_object_icon($other_obj);
204 204
 
205 205
         if (get_class($other_obj) != $link['class']) {
Please login to merge, or discard this patch.
lib/midcom/services/auth/frontend/form.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
      */
41 41
     public function read_login_data(Request $request) : ?array
42 42
     {
43
-        if (   !$request->request->has('midcom_services_auth_frontend_form_submit')
43
+        if (!$request->request->has('midcom_services_auth_frontend_form_submit')
44 44
             || !$request->request->has('username')
45 45
             || !$request->request->has('password')) {
46 46
             return null;
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     {
77 77
         // Store the submitted form if the session expired, but user wants to save the data
78 78
         if (!empty($_POST)) {
79
-            $data =& midcom_core_context::get()->get_custom_key('request_data');
79
+            $data = & midcom_core_context::get()->get_custom_key('request_data');
80 80
 
81 81
             $data['restored_form_data'] = [];
82 82
 
Please login to merge, or discard this patch.
lib/org/openpsa/documents/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 
41 41
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
42 42
     {
43
-        if (   $object instanceof org_openpsa_documents_document_dba
43
+        if ($object instanceof org_openpsa_documents_document_dba
44 44
             && $object->topic == $topic->id) {
45 45
             return "document/{$object->guid}/";
46 46
         }
Please login to merge, or discard this patch.
lib/midcom/admin/folder/style/midcom-admin-folder-order-type.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 $count = count($data['navigation_items']);
5 5
 
6 6
 foreach ($data['navigation_items'] as $i => $item) {
7
-    if (   isset($item[MIDCOM_NAV_SORTABLE])
7
+    if (isset($item[MIDCOM_NAV_SORTABLE])
8 8
         && !$item[MIDCOM_NAV_SORTABLE]) {
9 9
         continue;
10 10
     }
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
     }
20 20
 
21 21
     // Skip all components that return the default icon
22
-    if (   isset($item[MIDCOM_NAV_COMPONENT])
22
+    if (isset($item[MIDCOM_NAV_COMPONENT])
23 23
         && ($tmp = midcom::get()->componentloader->get_component_icon($item[MIDCOM_NAV_COMPONENT], false))) {
24 24
         $icon = '<i class="fa fa-' . $tmp . '"></i>';
25 25
     } elseif (!$item[MIDCOM_NAV_GUID]) {
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/style/midgard_admin_asgard_rcs_history.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
                 echo "                    <td>" . strftime('%x %X Z', $revision['date']) . "</td>\n";
37 37
                 echo "                    <td>";
38 38
 
39
-                if (   $revision['user']
39
+                if ($revision['user']
40 40
                     && $user = midcom::get()->auth->get_user($revision['user'])) {
41 41
                     echo $user->get_storage()->name;
42 42
                 } elseif ($revision['ip']) {
Please login to merge, or discard this patch.
lib/net/nemein/wiki/style/view-wikipage-raw.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,6 +6,6 @@
 block discarded – undo
6 6
     &(view["content"]:h);
7 7
     <?php
8 8
 } else {
9
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
9
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
10 10
 }
11 11
 ?>
12 12
\ No newline at end of file
Please login to merge, or discard this patch.