Passed
Branch master (7a7694)
by Andreas
18:25
created
src/midcom/datamanager/storage/container/dbacontainer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
             }
37 37
             $config['name'] = $name;
38 38
             $field = $this->prepare_field($config);
39
-            if (   isset($config['default'])
39
+            if (isset($config['default'])
40 40
                 && (!$this->object->id || $field instanceof transientnode)) {
41 41
                 $field->set_value($config['default']);
42 42
             }
Please login to merge, or discard this patch.
lib/midcom/response/styled.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
 
56 56
     private function set_context(midcom_core_context $context)
57 57
     {
58
-        if (   $context->get_key(MIDCOM_CONTEXT_PERMALINKGUID) === null
58
+        if ($context->get_key(MIDCOM_CONTEXT_PERMALINKGUID) === null
59 59
             || $context->get_key(MIDCOM_CONTEXT_PAGETITLE) == '') {
60 60
             // Retrieve Metadata
61 61
             $nav = new midcom_helper_nav();
Please login to merge, or discard this patch.
src/midcom/datamanager/validation/imageValidator.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,10 +12,10 @@
 block discarded – undo
12 12
 {
13 13
     public function validate($value, Constraint $constraint)
14 14
     {
15
-        if (   empty($value)
15
+        if (empty($value)
16 16
             || !empty($value['delete'])
17
-            || (   empty($value['file'])
18
-                && (   (empty($constraint->config['do_not_save_archival']) && empty($value['archival']))
17
+            || (empty($value['file'])
18
+                && ((empty($constraint->config['do_not_save_archival']) && empty($value['archival']))
19 19
                     || (!empty($constraint->config['do_not_save_archival']) && empty($value['main']))))) {
20 20
             $this->context->buildViolation('This value should not be blank.')
21 21
                 ->addViolation();
Please login to merge, or discard this patch.
src/midcom/datamanager/template/form.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
     public function form_end(FormView $view, array $data)
85 85
     {
86 86
         $string = '';
87
-        if (   !isset($data['render_rest'])
87
+        if (!isset($data['render_rest'])
88 88
             || $data['render_rest']) {
89 89
             $string .= $this->renderer->rest($view);
90 90
         }
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
             $data['attr']['class'] = 'shorttext';
224 224
         }
225 225
 
226
-        if (   !empty($data['value'])
226
+        if (!empty($data['value'])
227 227
             || is_numeric($data['value'])) {
228 228
             $data['attr']['value'] = $data['value'];
229 229
         }
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
     {
266 266
         if ($view->vars['readonly']) {
267 267
             $string = $this->get_view_renderer()->autocomplete_widget($view, $data);
268
-            return $string .  $this->renderer->widget($view['selection']);
268
+            return $string . $this->renderer->widget($view['selection']);
269 269
         }
270 270
 
271 271
         autocomplete::add_head_elements($data['handler_options']['creation_mode_enabled'], $data['handler_options']['sortable']);
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
         $jsinit .= "midcom_helper_datamanager2_autocomplete.create_dm2_widget('{$element_id}_search_input', {$data['min_chars']});\n";
276 276
 
277 277
         $string = '<fieldset ' . $this->renderer->block($view, 'widget_container_attributes') . '>';
278
-        $string .=  $this->renderer->widget($view['selection']);
278
+        $string .= $this->renderer->widget($view['selection']);
279 279
         $string .= ' ' . $this->renderer->widget($view['search_input']);
280 280
         $string .= '</fieldset>';
281 281
         return $string . $this->jsinit($jsinit);
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
         }
325 325
 
326 326
         $string = '<select ';
327
-        if (   $data['required']
327
+        if ($data['required']
328 328
             && null === $data['placeholder']
329 329
             && $data['placeholder_in_choices'] === false
330 330
             && $data['multiple'] === false) {
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
         $string .= $this->renderer->block($view, 'widget_attributes', $data) . '>';
339 339
         if (null !== $data['placeholder']) {
340 340
             $string .= '<option value=""';
341
-            if (   $data['required']
341
+            if ($data['required']
342 342
                 && empty($data['value'])
343 343
                 && "0" !== $data['value']) {
344 344
                 $string .= ' selected="selected"';
@@ -499,7 +499,7 @@  discard block
 block discarded – undo
499 499
             $string .= '<label class="midcom_datamanager_photo_label">' . $this->renderer->humanize('delete photo') . ' ' . $this->renderer->widget($data['form']['delete']) . '</label>';
500 500
             $string .= '<ul>';
501 501
             foreach ($objects as $identifier => $info) {
502
-                if (   $info['size_x']
502
+                if ($info['size_x']
503 503
                     && $info['size_y']) {
504 504
                     $size = "{$info['size_x']}&times;{$info['size_y']}";
505 505
                 } else {
@@ -524,7 +524,7 @@  discard block
 block discarded – undo
524 524
         $string .= '</td></tr></table></div>';
525 525
         $string .= $this->renderer->row($data['form']['identifier']);
526 526
 
527
-        return $string . $this->jsinit('init_image_widget("' . $view->vars['id'] .'");');
527
+        return $string . $this->jsinit('init_image_widget("' . $view->vars['id'] . '");');
528 528
     }
529 529
 
530 530
     public function subform_widget(FormView $view, array $data)
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/handler/event/create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         if ($query->has('start')) {
46 46
             $defaults['start'] = strtotime(substr($query->get('start'), 0, 19)) + 1;
47 47
             if ($query->has('end')) {
48
-                $defaults['end']= strtotime(substr($query->get('end'), 0, 19));
48
+                $defaults['end'] = strtotime(substr($query->get('end'), 0, 19));
49 49
             } else {
50 50
                 $defaults['end'] = $defaults['start'] + 3600;
51 51
             }
Please login to merge, or discard this patch.
src/midcom/routing/resolver.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
         $prefix = $this->context->get_key(MIDCOM_CONTEXT_ANCHORPREFIX);
139 139
 
140 140
         // Check if we need to start up a plugin.
141
-        if (   count($argv) > 1
141
+        if (count($argv) > 1
142 142
             && $config = plugin::get_config($argv[0], $argv[1])) {
143 143
             $namespace = array_shift($argv);
144 144
             $name = array_shift($argv);
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -74,7 +74,8 @@  discard block
 block discarded – undo
74 74
 
75 75
             try {
76 76
                 $result = $router->match($url);
77
-            } catch (ResourceNotFoundException $e) {
77
+            }
78
+            catch (ResourceNotFoundException $e) {
78 79
                 throw new midcom_error_notfound('This URL method is unknown.');
79 80
             }
80 81
             $this->request->attributes->add($result);
@@ -158,7 +159,8 @@  discard block
 block discarded – undo
158 159
 
159 160
         try {
160 161
             $result = $router->match($url);
161
-        } catch (ResourceNotFoundException $e) {
162
+        }
163
+        catch (ResourceNotFoundException $e) {
162 164
             // No match
163 165
             debug_add("Component {$viewer->_component} in {$viewer->_topic->name} declared unable to handle request.", MIDCOM_LOG_INFO);
164 166
             throw new midcom_error_notfound("This page is not available on this server.");
Please login to merge, or discard this patch.
src/midcom/console/command/exec.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@
 block discarded – undo
86 86
             require $basedir . $file;
87 87
         }
88 88
 
89
-        midcom::get()->auth->drop_sudo();#
89
+        midcom::get()->auth->drop_sudo(); #
90 90
         return 0;
91 91
     }
92 92
 
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,8 @@
 block discarded – undo
80 80
 
81 81
         try {
82 82
             require $basedir . $file;
83
-        } catch (\midcom_error_forbidden $e) {
83
+        }
84
+        catch (\midcom_error_forbidden $e) {
84 85
             $dialog = $this->getHelperSet()->get('question');
85 86
             $this->login($dialog, $input, $output);
86 87
             require $basedir . $file;
Please login to merge, or discard this patch.
lib/midcom/db/topic.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
     public function _on_loaded()
34 34
     {
35 35
         // if we are missing the component, use the nullcomponent.
36
-        if (   !$this->component
36
+        if (!$this->component
37 37
             || !midcom::get()->componentloader->is_installed($this->component)) {
38 38
             debug_add("Topic {$this->id} has no component assigned to it, using 'midcom.core.nullcomponent'.",
39 39
             MIDCOM_LOG_INFO);
Please login to merge, or discard this patch.
src/midcom/events/watcher.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,8 @@
 block discarded – undo
72 72
             $component = key($watch);
73 73
             try {
74 74
                 $interface = $this->loader->get_interface_class($component);
75
-            } catch (\midcom_error $e) {
75
+            }
76
+            catch (\midcom_error $e) {
76 77
                 debug_add("Failed to load the component {$component}: " . $e->getMessage(), MIDCOM_LOG_INFO);
77 78
                 continue;
78 79
             }
Please login to merge, or discard this patch.