flack / openpsa

lib/midcom/admin/help/style/midcom_admin_help_mgdschemas.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
 
         foreach ($properties as $propname => $val) {
             $description = preg_replace('/ *\n */', "\n", $val['value']);
-            if (   $val['link']
+            if ($val['link']
                 && $linked_component = midcom::get()->dbclassloader->get_component_for_class($val['link_name'])) {
                 $proplink = $data['router']->generate('help', ['component' => $linked_component, 'help_id' => 'mgdschemas']);
                 $proplink = "<a href='{$proplink}#{$val['link_name']}' title='{$linked_component}/{$val['link_name']}::{$val['link_target']}'>{$val['link_name']}:{$val['link_target']}</a>";

lib/org/openpsa/projects/task.php

Spacing +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
     public function _on_updated()
     {
         // Sync the object's ACL properties into MidCOM ACL system
-        if (   !$this->_skip_acl_refresh) {
+        if (!$this->_skip_acl_refresh) {
             if ($this->orgOpenpsaAccesstype && $this->orgOpenpsaOwnerWg) {
                 debug_add("Synchronizing task ACLs to MidCOM");
                 $sync = new org_openpsa_core_acl_synchronizer();

Braces +4 added lines, -2 removed lines

@@ -238,7 +238,8 @@ 
                     $salesproject = org_openpsa_sales_salesproject_dba::get_cached($agreement->salesproject);
                     $this->customer = $salesproject->customer;
                 }
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
             }
         } else {
             // No agreement, we can't be invoiceable
@@ -283,7 +284,8 @@ 
         try {
             $agreement = new org_openpsa_sales_salesproject_deliverable_dba($this->get_agreement());
             $agreement->update_units($this->id, $hours);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
         }
 
         if ($update) {

lib/org/openpsa/sales/handler/view.php

Spacing +3 added lines, -3 removed lines

@@ -91,7 +91,7 @@ 
         }
 
         if ($this->_config->get('sales_pdfbuilder_class')) {
-            if (   $this->_salesproject->can_do('midgard:update')
+            if ($this->_salesproject->can_do('midgard:update')
                 && $this->is_pdf_creatable()) {
                 $workflow = $this->get_workflow('datamanager');
                 $buttons[] = $workflow->get_button($this->router->generate('create_offer', ['guid' => $this->_salesproject->guid]), [
@@ -218,7 +218,7 @@ 
             case 'ordered':
                 if ($deliverable->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
                     $entries = $deliverable->get_at_entries();
-                    if (   $entries
+                    if ($entries
                         && $entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
                         && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)) {
                         return '<button class="run_cycle"><i class="fa fa-refresh"></i>' . $this->_l10n->get('generate now') . '</button>';
@@ -228,7 +228,7 @@ 
                 }
                 break;
             case 'delivered':
-                if (   $deliverable->orgOpenpsaObtype != org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+                if ($deliverable->orgOpenpsaObtype != org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
                     && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)) {
                     $client_class = $this->_config->get('calculator');
                     $client = new $client_class();

lib/org/openpsa/sales/style/show-deliverable-subscription.php

Spacing +4 added lines, -4 removed lines

@@ -3,7 +3,7 @@ 
 $state = $data['deliverable']->get_state();
 $formatter = $data['l10n']->get_formatter();
 $per_unit = $data['l10n']->get('per unit');
-if (   $data['product']
+if ($data['product']
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
 }
@@ -124,7 +124,7 @@ 
         </div>
         <?php
         $tabs = [];
-        if (   $data['invoices_url']
+        if ($data['invoices_url']
             && $data['deliverable']->invoiced > 0) {
             $tabs[] = [
                 'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -132,7 +132,7 @@ 
             ];
         }
 
-        if (   $data['projects_url']
+        if ($data['projects_url']
             && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
             && $data['product']
             && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {
@@ -191,7 +191,7 @@ 
             }
             echo "    </tbody>\n";
             echo "</table>\n";
-            if (   $at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
+            if ($at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
                 && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)) {
                 $label = $data['l10n']->get('generate now');
                 $process_link = $data['router']->generate('deliverable_run_cycle', ['guid' => $data['deliverable']->guid]);

Indentation +2 added lines, -2 removed lines

@@ -74,12 +74,12 @@
                         <tr>
                           <td class="title"><?php echo $data['l10n']->get('cost'); ?></td>
                           <?php
-                          if ($data['deliverable']->costType == '%') { ?>
+                            if ($data['deliverable']->costType == '%') { ?>
                               <td class="numeric"><?php echo $view['costPerUnit']; ?> %</td>
                               <td class="numeric">&nbsp;</td>
                               <td class="numeric">&nbsp;</td>
                           <?php
-                          } else { ?>
+                            } else { ?>
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->costPerUnit); ?></td>
                               <td class="numeric"><?php echo $view['plannedUnits']; ?></td>
                               <td class="numeric"><?php echo $view['units']; ?></td>

src/midcom/datamanager/extension/type/tinymceType.php

Spacing +2 added lines, -2 removed lines

@@ -26,11 +26,11 @@
      */
     public function configureOptions(OptionsResolver $resolver)
     {
-        $resolver->setDefault('config', function (Options $options) {
+        $resolver->setDefault('config', function(Options $options) {
             return \midcom_baseclasses_components_configuration::get('midcom.datamanager', 'config');
         });
 
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
             $widget_defaults = [
                 'mode' => 'exact',
                 'theme' => $options['config']->get('tinymce_default_theme'),

src/midcom/datamanager/extension/type/autocompleteType.php

Spacing +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@ 
     public function configureOptions(OptionsResolver $resolver)
     {
         $resolver->setDefault('error_bubbling', false);
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
             $widget_defaults = [
                 'creation_mode_enabled' => false,
                 'class' => null,
@@ -66,7 +66,7 @@ 
 
             return helper::normalize($widget_defaults, $value);
         });
-        $resolver->setNormalizer('type_config', function (Options $options, $value) {
+        $resolver->setNormalizer('type_config', function(Options $options, $value) {
             $type_defaults = [
                 'options' => [],
                 'method' => 'GET',

Braces +2 added lines, -1 removed lines

@@ -116,7 +116,8 @@
                 try {
                     $object = $options['widget_config']['class']::get_cached($identifier);
                     $preset[$identifier] = autocomplete_helper::create_item_label($object, $options['widget_config']['result_headers'], $options['widget_config']['titlefield']);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $e->log();
                 }
             }

src/midcom/datamanager/extension/type/subformType.php

Spacing +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
                 'max_count' => 0
             ]
         ]);
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
             $validation = [];
             if ($options['type_config']['max_count'] > 0) {
                 $validation['max'] = $options['type_config']['max_count'];
@@ -54,13 +54,13 @@ 
             }
             return $validation;
         });
-        $resolver->setNormalizer('entry_options', function (Options $options, $value) {
+        $resolver->setNormalizer('entry_options', function(Options $options, $value) {
             return array_replace([
                 'required' => false, //@todo no idea why this is necessary
                 'widget_config' => $options['widget_config']
             ], (array) $value);
         });
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
             if (!array_key_exists('sortable', $value)) {
                 $value['sortable'] = false;
             }

lib/org/openpsa/sales/handler/edit.php

Braces +4 added lines, -2 removed lines

@@ -68,7 +68,8 @@ 
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];
 
                 $defaults['customer'] = $customer->id;
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $customer = new org_openpsa_contacts_person_dba($guid);
                 $defaults['customerContact'] = $customer->id;
                 $field['type_config']['options'] = $this->list_groups(new org_openpsa_sales_salesproject_dba, [$customer->id => true]);
@@ -142,7 +143,8 @@ 
             try {
                 $company = org_openpsa_contacts_group_dba::get_cached($company_id);
                 $ret[$company->id] = $company->get_label();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
         $schemadb = schemadb::from_path($this->_config->get('schemadb_salesproject'));
 
         if (!empty($guid)) {
-            $field =& $schemadb->get('default')->get_field('customer');
+            $field = & $schemadb->get('default')->get_field('customer');
             try {
                 $customer = new org_openpsa_contacts_group_dba($guid);
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];

lib/midcom/core/context.php

Spacing +2 added lines, -2 removed lines

@@ -153,7 +153,7 @@ 
             return false;
         }
 
-        if (   $key === MIDCOM_CONTEXT_ROOTTOPIC
+        if ($key === MIDCOM_CONTEXT_ROOTTOPIC
             && $this->_data[$key] === null) {
             $this->_data[$key] = self::initialize_root_topic();
         }
@@ -277,7 +277,7 @@ 
      */
     public function set_custom_key($key, &$value)
     {
-        $this->_data[MIDCOM_CONTEXT_CUSTOMDATA][$key] =& $value;
+        $this->_data[MIDCOM_CONTEXT_CUSTOMDATA][$key] = & $value;
     }
 
     public function show()

Braces +2 added lines, -1 removed lines

@@ -165,7 +165,8 @@
                 try {
                     self::$root_topic = midcom_db_topic::get_cached($guid);
                     return self::$root_topic;
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     if ($e instanceof midcom_error_forbidden) {
                         throw $e;
                     }