Passed
Branch master (7a7694)
by Andreas
18:25
created
lib/org/openpsa/user/handler/person/account.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
59 59
         $response = $workflow->run($request);
60 60
 
61
-        if (   $workflow->get_state() == 'save'
61
+        if ($workflow->get_state() == 'save'
62 62
             && $this->create_account($this->person, $data["controller"]->get_form_values())) {
63 63
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), sprintf($this->_l10n->get('person %s created'), $this->person->name));
64 64
         }
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         $accounthelper = new org_openpsa_user_accounthelper($this->person);
149 149
 
150 150
         // Update account
151
-        if (   !$accounthelper->set_account($controller->get_form_values()["username"], $password)
151
+        if (!$accounthelper->set_account($controller->get_form_values()["username"], $password)
152 152
             && midcom_connection::get_error() != MGD_ERR_OK) {
153 153
             // Failure, give a message
154 154
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get("failed to update the user account, reason") . ': ' . midcom_connection::get_error_string(), 'error');
Please login to merge, or discard this patch.
lib/org/openpsa/expenses/handler/hours/admin.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,8 @@
 block discarded – undo
100 100
         try {
101 101
             $task = org_openpsa_projects_task_dba::get_cached($hour_report->task);
102 102
             $options['success_url'] = $this->router->generate('list_hours_task', ['guid' => $task->guid]);
103
-        } catch (midcom_error $e) {
103
+        }
104
+        catch (midcom_error $e) {
104 105
             $e->log();
105 106
         }
106 107
         return $this->get_workflow('delete', $options)->run($request);
Please login to merge, or discard this patch.
src/midcom/datamanager/controller.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -70,13 +70,13 @@  discard block
 block discarded – undo
70 70
             }
71 71
         } elseif (!$this->form->isSubmitted()) {
72 72
             $this->form->handleRequest($request);
73
-            if (   $this->form->isSubmitted()
73
+            if ($this->form->isSubmitted()
74 74
                 && $button = $this->form->getClickedButton()) {
75 75
                 $operation = $button->getConfig()->getOption('operation');
76 76
             }
77 77
         }
78 78
 
79
-        if (   in_array($operation, [self::SAVE, self::NEXT])
79
+        if (in_array($operation, [self::SAVE, self::NEXT])
80 80
             && !$this->form->isValid()) {
81 81
             $operation = self::EDIT;
82 82
         }
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
                 if ($storage->get_last_operation() === self::SAVE) {
160 160
                     // Get GUIDs and such for new-created dependent objects
161 161
                     $this->dm->set_storage($storage->get_value(), $this->dm->get_schema()->get_name());
162
-                } elseif (   !$this->form->isValid()
162
+                } elseif (!$this->form->isValid()
163 163
                           && $storage->move_uploaded_files() > 0) {
164 164
                     $form = $this->dm->get_form($this->form->getName(), true);
165 165
                     $this->copy_errors($this->form, $form);
Please login to merge, or discard this patch.
lib/net/nehmer/blog/style/feeds-item.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 $item->title = $data['article']->title;
19 19
 $arg = $data['article']->name ?: $data['article']->guid;
20 20
 
21
-if (   $data['config']->get('link_to_external_url')
21
+if ($data['config']->get('link_to_external_url')
22 22
     && !empty($data['article']->url)) {
23 23
     $item->link = $data['article']->url;
24 24
 } else {
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
     $item->description .= '<div class="abstract">' . $view['abstract'] . '</div>';
38 38
 }
39 39
 
40
-if (   array_key_exists('image', $view)
40
+if (array_key_exists('image', $view)
41 41
     && $data['config']->get('rss_use_image')) {
42 42
     $item->description .= "\n<div class=\"image\">" . $view['image'] . '</div>';
43 43
 }
Please login to merge, or discard this patch.
lib/org/openpsa/documents/handler/document/admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
 
102 102
         $this->_controller = $this->load_controller();
103 103
 
104
-        if (   $data['enable_versioning']
104
+        if ($data['enable_versioning']
105 105
             && $request->request->count() > 0) {
106 106
             $this->_backup_attachment();
107 107
         }
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/suspect.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -68,14 +68,14 @@  discard block
 block discarded – undo
68 68
     {
69 69
         $properties = ['fromClass', 'toClass', 'fromGuid', 'toGuid', 'fromComponent', 'toComponent', 'status', 'toExtra', 'toExtra'];
70 70
         foreach ($properties as $property) {
71
-            if (   !empty($defaults->$property)
71
+            if (!empty($defaults->$property)
72 72
                 && empty($link->$property)) {
73 73
                 debug_add("Copying property '{$property}' ('{$defaults->$property}') from defaults");
74 74
                 $link->$property = $defaults->$property;
75 75
             }
76 76
         }
77 77
 
78
-        if (   empty($link->toComponent)
78
+        if (empty($link->toComponent)
79 79
             && !empty($link->fromComponent)) {
80 80
             debug_add("Setting property 'toComponent' to '{$component}'");
81 81
             $link->toComponent = $component;
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
             $link->fromComponent = $component;
85 85
         }
86 86
 
87
-        if (   empty($link->toGuid)
87
+        if (empty($link->toGuid)
88 88
             && !empty($link->fromGuid)) {
89 89
             $link->toClass = get_class($obj);
90 90
             $link->toGuid = $obj->guid;
Please login to merge, or discard this patch.
lib/org/openpsa/projects/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
      */
54 54
     private function _find_suspects_event(midcom_core_dbaobject $object, org_openpsa_relatedto_dba $defaults, array &$links_array)
55 55
     {
56
-        if (   !is_array($object->participants)
56
+        if (!is_array($object->participants)
57 57
             || count($object->participants) < 1) {
58 58
             //We have invalid list or zero participants, abort
59 59
             return;
Please login to merge, or discard this patch.
lib/midcom/admin/folder/management.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
             }
51 51
 
52 52
             // Skip components beginning with midcom or midgard
53
-            if (   preg_match('/^(midcom|midgard)\./', $manifest->name)
53
+            if (preg_match('/^(midcom|midgard)\./', $manifest->name)
54 54
                 && $manifest->name != 'midcom.helper.search') {
55 55
                 continue;
56 56
             }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/welcome.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -196,7 +196,8 @@  discard block
 block discarded – undo
196 196
         foreach ($guids as $guid) {
197 197
             try {
198 198
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
199
-            } catch (midcom_error $e) {
199
+            }
200
+            catch (midcom_error $e) {
200 201
                 continue;
201 202
             }
202 203
 
@@ -211,7 +212,8 @@  discard block
 block discarded – undo
211 212
         foreach ($guids as $guid) {
212 213
             try {
213 214
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
214
-            } catch (midcom_error $e) {
215
+            }
216
+            catch (midcom_error $e) {
215 217
                 continue;
216 218
             }
217 219
 
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
                 $qb = new midcom_core_querybuilder($midcom_dba_classname);
34 34
                 $qb->add_constraint('metadata.revised', '>=', $since);
35 35
 
36
-                if (   $only_mine
36
+                if ($only_mine
37 37
                     && midcom::get()->auth->user) {
38 38
                     $qb->add_constraint('metadata.authors', 'LIKE', '|' . midcom::get()->auth->user->guid . '|');
39 39
                 }
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
                 continue;
199 199
             }
200 200
 
201
-            if (   $object->can_do('midgard:update')
201
+            if ($object->can_do('midgard:update')
202 202
                 && $object->can_do('midcom:approve')) {
203 203
                 $object->metadata->approve();
204 204
                 midcom::get()->uimessages->add($this->_l10n->get('midgard.admin.asgard'), sprintf($this->_l10n->get('object %s approved'), $object->guid));
Please login to merge, or discard this patch.