Passed
Branch master (7a7694)
by Andreas
18:25
created
lib/midgard/admin/asgard/style/midgard_admin_asgard_welcome.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
                     <?php
31 31
                     foreach ($type_choices as $value => $label) {
32 32
                         $selected = '';
33
-                        if (   isset($data['type_filter'])
33
+                        if (isset($data['type_filter'])
34 34
                             && $data['type_filter'] == $value) {
35 35
                             $selected = ' selected="selected"';
36 36
                         }
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
                     <?php
46 46
                     foreach ($revised_after_choices as $value => $label) {
47 47
                         $selected = '';
48
-                        if (   isset($data['revised_after'])
48
+                        if (isset($data['revised_after'])
49 49
                             && $data['revised_after'] == date('Y-m-d', $value)) {
50 50
                             $selected = ' selected="selected"';
51 51
                         }
Please login to merge, or discard this patch.
lib/midcom/baseclasses/components/plugin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
     public function initialize(midcom_baseclasses_components_viewer $master, Router $router)
19 19
     {
20 20
         $this->router = $router;
21
-        $this->_request_data =& $master->_request_data;
21
+        $this->_request_data = & $master->_request_data;
22 22
         $this->_topic = $master->_topic;
23 23
         $this->_request_data['l10n'] = $this->_l10n;
24 24
 
Please login to merge, or discard this patch.
lib/org/openpsa/slideshow/handler/edit.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,8 @@
 block discarded – undo
134 134
         try {
135 135
             $this->$function($request->request);
136 136
             $this->_response->success = true;
137
-        } catch (midcom_error $e) {
137
+        }
138
+        catch (midcom_error $e) {
138 139
             $this->_response->success = false;
139 140
             $this->_response->error = $e->getMessage();
140 141
         }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
         $images = $qb->execute();
62 62
         $failed = 0;
63 63
         foreach ($images as $image) {
64
-            if (   !$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
64
+            if (!$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
65 65
                 || !$image->generate_image('image', $this->_config->get('image_filter'))) {
66 66
                 $failed++;
67 67
             }
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
         $attachment->title = $title;
242 242
         $attachment->mimetype = $file['type'];
243 243
         $attachment->parentguid = $image->guid;
244
-        if (   !$attachment->create()
244
+        if (!$attachment->create()
245 245
             || !$attachment->copy_from_file($file['tmp_name'])) {
246 246
             throw new midcom_error('Failed to create attachment: ' . midcom_connection::get_error_string());
247 247
         }
Please login to merge, or discard this patch.
lib/org/openpsa/projects/handler/task/crud.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,8 @@
 block discarded – undo
138 138
         try {
139 139
             $parent = new org_openpsa_projects_project($task->project);
140 140
             $options['success_url'] = $this->router->generate('project', ['guid' => $parent->guid]);
141
-        } catch (midcom_error $e) {
141
+        }
142
+        catch (midcom_error $e) {
142 143
             $e->log();
143 144
         }
144 145
 
Please login to merge, or discard this patch.
lib/org/openpsa/projects/handler/task/resourcing.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
             return new midcom_response_relocate($this->router->generate('task_view', ['guid' => $guid]));
65 65
         }
66 66
 
67
-        if (   $request->request->has('save')
67
+        if ($request->request->has('save')
68 68
             && $prospects = $request->request->get('org_openpsa_projects_prospects')) {
69 69
             $qb = org_openpsa_projects_task_resource_dba::new_query_builder();
70 70
             $qb->add_constraint('guid', 'IN', array_keys($prospects));
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
                     // create relatedto
96 96
                     org_openpsa_relatedto_plugin::create($event, 'org.openpsa.calendar', $this->_task, 'org.openpsa.projects');
97 97
                 }
98
-                if (   $update_prospect
98
+                if ($update_prospect
99 99
                     && !$prospect->update()) {
100 100
                     debug_add('Failed to update prospect: ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
101 101
                 }
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/subscriber.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,8 @@  discard block
 block discarded – undo
36 36
             // Add person to campaign
37 37
             try {
38 38
                 $campaign = new org_openpsa_directmarketing_campaign_dba($add_to);
39
-            } catch (midcom_error $e) {
39
+            }
40
+            catch (midcom_error $e) {
40 41
                 // FIXME: More informative error message
41 42
                 $this->notify('Failed adding person %s to campaign %s', $add_to, 'error');
42 43
                 return;
@@ -86,7 +87,8 @@  discard block
 block discarded – undo
86 87
             try {
87 88
                 $campaigns[$membership->campaign] = new org_openpsa_directmarketing_campaign_dba($membership->campaign);
88 89
                 $campaign_membership_map[$membership->campaign] = $membership;
89
-            } catch (midcom_error $e) {
90
+            }
91
+            catch (midcom_error $e) {
90 92
                 debug_add('Failed to load campaign ' . $membership->campaign . ', reason: ' . $e->getMessage());
91 93
             }
92 94
         }
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/handler/invoice/crud.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,8 @@  discard block
 block discarded – undo
48 48
             // We're creating invoice for chosen customer
49 49
             try {
50 50
                 $this->customer = new org_openpsa_contacts_group_dba($company);
51
-            } catch (midcom_error $e) {
51
+            }
52
+            catch (midcom_error $e) {
52 53
                 $contact = new org_openpsa_contacts_person_dba($company);
53 54
                 $this->contact_id = $contact->id;
54 55
             }
@@ -155,7 +156,8 @@  discard block
 block discarded – undo
155 156
             if (!empty($this->invoice->customer)) {
156 157
                 try {
157 158
                     $this->customer = org_openpsa_contacts_group_dba::get_cached($this->invoice->customer);
158
-                } catch (midcom_error $e) {
159
+                }
160
+                catch (midcom_error $e) {
159 161
                     $customer_field['hidden'] = true;
160 162
                     $e->log();
161 163
                 }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -153,8 +153,8 @@
 block discarded – undo
153 153
         $schema->get_field('paid')['hidden'] = empty($this->invoice->paid);
154 154
 
155 155
         $contact = $this->invoice->customerContact ? $this->invoice->customerContact : $this->contact_id;
156
-        $customer_field =& $schema->get_field('customer');
157
-        $contact_field =& $schema->get_field('customerContact');
156
+        $customer_field = & $schema->get_field('customer');
157
+        $contact_field = & $schema->get_field('customerContact');
158 158
 
159 159
         if (!empty($contact)) {
160 160
             $customer_field['type_config']['options'] = $this->get_customers_for_contact($contact);
Please login to merge, or discard this patch.
lib/org/openpsa/products/handler/product/create.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,8 @@
 block discarded – undo
89 89
         } elseif ((int) $group > 0) {
90 90
             try {
91 91
                 $this->parent = new org_openpsa_products_product_group_dba((int) $group);
92
-            } catch (midcom_error $e) {
92
+            }
93
+            catch (midcom_error $e) {
93 94
                 $e->log();
94 95
             }
95 96
         }
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/handler/group/action.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,8 @@
 block discarded – undo
29 29
                 $member->require_do('midgard:update');
30 30
                 $member->extra = $request->request->get('title');
31 31
                 $response->status = $member->update();
32
-            } catch (midcom_error $e) {
32
+            }
33
+            catch (midcom_error $e) {
33 34
                 $e->log();
34 35
             }
35 36
             $response->message = midcom_connection::get_error_string();
Please login to merge, or discard this patch.