Passed
Branch master (7a7694)
by Andreas
18:25
created
lib/org/openpsa/mypage/style/show-updates.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,8 @@
 block discarded – undo
31 31
             }
32 32
             $contact = new org_openpsa_widgets_contact($editor);
33 33
             echo "<li class=\"updated-{$class}\"><a href=\"{$url}\"{$onclick}>{$document->title}</a> <div class=\"metadata\">" . $formatter->datetime($document->edited) . " (" . $contact->show_inline() . ")</div></li>\n";
34
-        } catch (midcom_error $e) {
34
+        }
35
+        catch (midcom_error $e) {
35 36
         }
36 37
     }
37 38
     echo "</ul></div>\n";
Please login to merge, or discard this patch.
lib/org/openpsa/mypage/style/weekreview-day-item-task-status.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
 $target_person_label = midcom::get()->i18n->get_string('system', 'org.openpsa.projects');
5 5
 
6 6
 $fallback_creator = midcom_db_person::get_cached(1);
7
-if (    $task_status->metadata->creator
7
+if ($task_status->metadata->creator
8 8
      && $task_status->metadata->creator != $fallback_creator->guid) {
9 9
     $status_changer = org_openpsa_widgets_contact::get($task_status->metadata->creator);
10 10
     $status_changer_label = $status_changer->show_inline();
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,8 @@
 block discarded – undo
33 33
                 $task_label = "<a href=\"{$data['projects_url']}task/{$task->guid}/\">{$task_label}</a>";
34 34
             }
35 35
             echo $task_label;
36
-        } catch (midcom_error $e) {}
36
+        }
37
+        catch (midcom_error $e) {}
37 38
         ?>
38 39
     </td>
39 40
     <td class="multivalue">
Please login to merge, or discard this patch.
lib/org/openpsa/projects/style/show-project.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,8 @@
 block discarded – undo
19 19
             $customer_html = '<a href="' . $contacts_url . '/group/' . $customer->guid . '/">' . $customer_html . "</a>\n";
20 20
         }
21 21
         echo $customer_html;
22
-    } catch (midcom_error $e) {
22
+    }
23
+    catch (midcom_error $e) {
23 24
     }
24 25
 
25 26
     if ($project->manager) {
Please login to merge, or discard this patch.
lib/org/openpsa/projects/style/show-prospects-xml.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,8 @@
 block discarded – undo
6 6
     foreach ($data['prospects'] as $prospect) {
7 7
         try {
8 8
             $person = org_openpsa_contacts_person_dba::get_cached($prospect->person);
9
-        } catch (midcom_error $e) {
9
+        }
10
+        catch (midcom_error $e) {
10 11
             continue;
11 12
         } ?>
12 13
         <person>
Please login to merge, or discard this patch.
lib/org/openpsa/projects/style/show-frontpage.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,8 @@
 block discarded – undo
31 31
         try {
32 32
             $customer = new org_openpsa_contacts_group_dba($customer);
33 33
             $customer_title = $customer->official;
34
-        } catch (midcom_error $e) {
34
+        }
35
+        catch (midcom_error $e) {
35 36
             $customer_title = $data['l10n']->get('no customer');
36 37
         }
37 38
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('ongoing') . "\">{$task_count['ongoing']}</span></td>\n";
69 69
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('on_hold') . "\">{$task_count['on_hold']}</span></td>\n";
70 70
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('closed') . "\">{$task_count['closed']}</span></td>\n";
71
-            echo "        <td class=\"numeric\"> " ;
71
+            echo "        <td class=\"numeric\"> ";
72 72
             echo "            <span title=\"" . $data['l10n']->get('reported') . "\">" . round($hours['reportedHours'], 2) . "</span>";
73 73
             if ($hours['plannedHours'] > 0) {
74 74
                 echo          " / <span title=\"" . $data['l10n']->get('planned hours') . "\">" . round($hours['plannedHours'], 2) . "</span>";
Please login to merge, or discard this patch.
lib/org/openpsa/sales/style/show-salesproject-grid.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -35,7 +35,8 @@  discard block
 block discarded – undo
35 35
                 if ($data['contacts_url']) {
36 36
                     $row['customer'] = "<a href=\"{$data['contacts_url']}group/{$customer->guid}/\">{$label}</a>";
37 37
                 }
38
-            } catch (midcom_error $e) {
38
+            }
39
+            catch (midcom_error $e) {
39 40
                 $e->log();
40 41
             }
41 42
         }
@@ -51,7 +52,8 @@  discard block
 block discarded – undo
51 52
             if ($data['contacts_url']) {
52 53
                 $row['customerContact'] = "<a href=\"{$data['contacts_url']}person/{$customer->guid}/\">{$label}</a>";
53 54
             }
54
-        } catch (midcom_error $e) {
55
+        }
56
+        catch (midcom_error $e) {
55 57
             $e->log();
56 58
         }
57 59
     }
@@ -63,7 +65,8 @@  discard block
 block discarded – undo
63 65
         $owner_widget = org_openpsa_widgets_contact::get($salesproject->owner);
64 66
         $row['index_owner'] = $owner->rname;
65 67
         $row['owner'] = $owner_widget->show_inline();
66
-    } catch (midcom_error $e) {
68
+    }
69
+    catch (midcom_error $e) {
67 70
         $row['index_owner'] = '';
68 71
         $row['owner'] = '';
69 72
     }
Please login to merge, or discard this patch.
lib/org/openpsa/sales/style/show-salesproject-deliverables-header.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,8 @@
 block discarded – undo
17 17
                         try {
18 18
                             $group = org_openpsa_products_product_group_dba::get_cached($product['productGroup']);
19 19
                             $desc .= $group->title . ', ';
20
-                        } catch (midcom_error $e) {
20
+                        }
21
+                        catch (midcom_error $e) {
21 22
                             $e->log();
22 23
                         }
23 24
                         if ($product['delivery'] == org_openpsa_products_product_dba::DELIVERY_SINGLE) {
Please login to merge, or discard this patch.
lib/org/openpsa/slideshow/style/edit.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,8 @@
 block discarded – undo
21 21
         $original = new midcom_db_attachment($image->attachment);
22 22
         $original_url = midcom_db_attachment::get_url($original);
23 23
         $name = $original->name;
24
-    } catch (midcom_error $e) {
24
+    }
25
+    catch (midcom_error $e) {
25 26
         $url = MIDCOM_STATIC_URL . '/stock-icons/mime/gnome-text-blank.png';
26 27
         $name = $data['l10n']->get('attachment missing');
27 28
         $original_url = '';
Please login to merge, or discard this patch.
lib/org/openpsa/reports/style/invoices_report-grid.php 2 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -120,13 +120,13 @@
 block discarded – undo
120 120
 $grid->set_option('loadonce', true)
121 121
     ->set_option('grouping', true)
122 122
     ->set_option('groupingView', [
123
-             'groupField' => ['status'],
124
-             'groupColumnShow' => [false],
125
-             'groupText' => ['<strong>{0}</strong> ({1})'],
126
-             'groupOrder' => ['asc'],
127
-             'groupSummary' => [true],
128
-             'showSummaryOnHide' => true
129
-         ])
123
+                'groupField' => ['status'],
124
+                'groupColumnShow' => [false],
125
+                'groupText' => ['<strong>{0}</strong> ({1})'],
126
+                'groupOrder' => ['asc'],
127
+                'groupSummary' => [true],
128
+                'showSummaryOnHide' => true
129
+            ])
130 130
     ->set_option('sortname', $sortname)
131 131
     ->set_option('sortorder', $sortorder);
132 132
 
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -73,7 +73,8 @@  discard block
 block discarded – undo
73 73
         } else {
74 74
             $entry['customer'] = $customer->official;
75 75
         }
76
-    } catch (midcom_error $e) {
76
+    }
77
+    catch (midcom_error $e) {
77 78
     }
78 79
 
79 80
     if ($entry['status'] === 'canceled') {
@@ -85,7 +86,8 @@  discard block
 block discarded – undo
85 86
         $entry['index_contact'] = $contact->rname;
86 87
         $contact_card = org_openpsa_widgets_contact::get($invoice->customerContact);
87 88
         $entry['contact'] = $contact_card->show_inline();
88
-    } catch (midcom_error $e) {
89
+    }
90
+    catch (midcom_error $e) {
89 91
     }
90 92
 
91 93
     $entries[] = $entry;
Please login to merge, or discard this patch.