Passed
Push — master ( f0a80d...74d5c1 )
by Andreas
18:22
created
lib/org/openpsa/directmarketing/handler/message/send.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
     {
115 115
         $nap = new midcom_helper_nav();
116 116
         $node = $nap->get_node($nap->get_current_node());
117
-        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid .'/';
117
+        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid . '/';
118 118
         $this->batch_url_base_full = $node[MIDCOM_NAV_RELATIVEURL] . 'message/send_bg/' . $data['message']->guid . '/';
119 119
         debug_add("compose_url: {$compose_url}");
120 120
         debug_add("batch_url base: {$this->batch_url_base_full}");
Please login to merge, or discard this patch.
lib/org/openpsa/products/handler/product/csv.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
 
51 51
     public function _load_data(string $handler_id, array &$args, array &$data) : array
52 52
     {
53
-        if (   empty($_POST)
53
+        if (empty($_POST)
54 54
             && $this->session->exists('POST_data')) {
55 55
             $_POST = $this->session->get('POST_data');
56 56
             $this->session->remove('POST_data');
Please login to merge, or discard this patch.
lib/midcom/helper/reflector/tree.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
     private static function _check_permissions(bool $deleted) : bool
93 93
     {
94 94
         // PONDER: Check for some generic user privilege instead  ??
95
-        if (   $deleted
95
+        if ($deleted
96 96
             && !midcom_connection::is_admin()
97 97
             && !midcom::get()->auth->is_component_sudo()) {
98 98
             debug_add('Non-admins are not allowed to list deleted objects', MIDCOM_LOG_ERROR);
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
             $field_type = $field_data['type'];
222 222
             $field = $field_data['name'];
223 223
 
224
-            if (   !$field_target
224
+            if (!$field_target
225 225
                 || !isset($for_object->$field_target)) {
226 226
                 // Why return false ???
227 227
                 return false;
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/manage.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -223,10 +223,10 @@
 block discarded – undo
223 223
             $new_type_reflector = midcom_helper_reflector::get($new_type);
224 224
             $link_properties = $new_type_reflector->get_link_properties();
225 225
             foreach ($link_properties as $property => $link) {
226
-                if (   ($link['class'] && midcom_helper_reflector::is_same_class($link['class'], $this->_object->__mgdschema_class_name__))
226
+                if (($link['class'] && midcom_helper_reflector::is_same_class($link['class'], $this->_object->__mgdschema_class_name__))
227 227
                     || $link['type'] == MGD_TYPE_GUID) {
228 228
                     $defaults[$property] = $this->_object->{$link['target']};
229
-                } elseif (   $property == $parent_property
229
+                } elseif ($property == $parent_property
230 230
                           && midcom_helper_reflector::is_same_class($new_type, $this->_object->__mgdschema_class_name__)) {
231 231
                     $defaults[$property] = $this->_object->$parent_property;
232 232
                 }
Please login to merge, or discard this patch.
lib/errors.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
     private function send(int $httpcode, string $message)
112 112
     {
113 113
         $error_actions = midcom::get()->config->get_array('error_actions');
114
-        if (   !isset($error_actions[$httpcode])
114
+        if (!isset($error_actions[$httpcode])
115 115
             || !isset($error_actions[$httpcode]['action'])) {
116 116
             // No action specified for this error code, skip
117 117
             return;
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
             return;
142 142
         }
143 143
 
144
-        if (   !is_writable($config['filename'])
144
+        if (!is_writable($config['filename'])
145 145
             && !is_writable(dirname($config['filename']))) {
146 146
             debug_add("Error logging file {$config['filename']} is not writable", MIDCOM_LOG_WARN);
147 147
             return;
Please login to merge, or discard this patch.
lib/midcom/services/auth/main.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -221,7 +221,7 @@
 block discarded – undo
221 221
             return true;
222 222
         }
223 223
         if ($user === null) {
224
-            $user =& $this->user;
224
+            $user = & $this->user;
225 225
         }
226 226
 
227 227
         if ($user == 'EVERYONE') {
Please login to merge, or discard this patch.
lib/midcom/helper/reflector/main.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
 
327 327
         $label_prop = $this->get_label_property();
328 328
 
329
-        if (    $label_prop != 'guid'
329
+        if ($label_prop != 'guid'
330 330
              && $this->_mgd_reflector->property_exists($label_prop)) {
331 331
             $search_properties[$label_prop] = true;
332 332
         }
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
                 continue;
381 381
             }
382 382
 
383
-            if (   !$ref->is_link($property)
383
+            if (!$ref->is_link($property)
384 384
                 && $ref->get_midgard_type($property) != MGD_TYPE_GUID) {
385 385
                 continue;
386 386
             }
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
     protected static function class_rewrite(string $schema_type) : string
416 416
     {
417 417
         $extends = midcom_baseclasses_components_configuration::get('midcom.helper.reflector', 'config')->get_array('class_extends');
418
-        if (   isset($extends[$schema_type])
418
+        if (isset($extends[$schema_type])
419 419
             && class_exists($extends[$schema_type])) {
420 420
             return $extends[$schema_type];
421 421
         }
@@ -485,7 +485,7 @@  discard block
 block discarded – undo
485 485
         // Configured properties
486 486
         foreach ($this->_config->get_array($type . '_exceptions') as $class => $property) {
487 487
             if (midcom::get()->dbfactory->is_a($object, $class)) {
488
-                if (   $property !== false
488
+                if ($property !== false
489 489
                     && !$this->_mgd_reflector->property_exists($property)) {
490 490
                     debug_add("Matched class '{$key}' to '{$class}' via is_a but property '{$property}' does not exist", MIDCOM_LOG_ERROR);
491 491
                 } else {
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/person.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 
60 60
     public function __set($name, $value)
61 61
     {
62
-        if (   $name == 'homepage'
62
+        if ($name == 'homepage'
63 63
             && !empty($value)
64 64
             && $value != $this->homepage) {
65 65
             $this->_register_prober = true;
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/archive.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -131,8 +131,8 @@  discard block
 block discarded – undo
131 131
         $year_data = [];
132 132
         $first_post = $this->_compute_welcome_first_post();
133 133
         $this->_request_data['first_post'] = $first_post;
134
-        $this->_request_data['total_count'] =& $total_count;
135
-        $this->_request_data['year_data'] =& $year_data;
134
+        $this->_request_data['total_count'] = & $total_count;
135
+        $this->_request_data['year_data'] = & $year_data;
136 136
         if (!$first_post) {
137 137
             return;
138 138
         }
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
         switch ($handler_id) {
264 264
             case 'archive-year-category':
265 265
                 $category = trim(strip_tags($args[1]));
266
-                if (   $data['datamanager']->get_schema('default')->has_field('categories')
266
+                if ($data['datamanager']->get_schema('default')->has_field('categories')
267 267
                     && !$data['datamanager']->get_schema('default')->get_field('categories')['type_config']['allow_multiple']) {
268 268
                     $qb->add_constraint('extra1', '=', (string) $category);
269 269
                 } else {
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
             throw new midcom_error_notfound("The year '{$year}' is not valid.");
351 351
         }
352 352
 
353
-        if (   $month < 1
353
+        if ($month < 1
354 354
             || $month > 12) {
355 355
             throw new midcom_error_notfound("The month {$month} is not valid.");
356 356
         }
Please login to merge, or discard this patch.