Passed
Push — master ( f0a80d...74d5c1 )
by Andreas
18:22
created
src/midcom/workflow/datamanager.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -122,8 +122,8 @@
 block discarded – undo
122 122
             return 'undefined';
123 123
         }
124 124
 
125
-        if (   !str_starts_with($url, '/')
126
-            && ! preg_match('|^https?://|', $url)) {
125
+        if (!str_starts_with($url, '/')
126
+            && !preg_match('|^https?://|', $url)) {
127 127
             $url = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX) . $url;
128 128
         }
129 129
         return '"' . $url . '"';
Please login to merge, or discard this patch.
lib/org/openpsa/documents/elFinderVolumeOpenpsa.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_MIME, '(' . $mime . ')');
68 68
         }
69 69
 
70
-        $tmpsize = (int)sprintf('%u', filesize($tmpname));
70
+        $tmpsize = (int) sprintf('%u', filesize($tmpname));
71 71
         if ($this->uploadMaxSize > 0 && $tmpsize > $this->uploadMaxSize) {
72 72
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_SIZE);
73 73
         }
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
         $output = [$object->get_label()];
251 251
 
252 252
         $parent = $object->get_parent();
253
-        while (   $parent
253
+        while ($parent
254 254
                && $parent->component == 'org.openpsa.documents') {
255 255
             $output[] = $parent->extra;
256 256
             $parent = $parent->get_parent();
@@ -347,12 +347,12 @@  discard block
 block discarded – undo
347 347
             $data['mime'] = 'directory';
348 348
         }
349 349
 
350
-        if (   $owner
350
+        if ($owner
351 351
             && $group = midcom::get()->auth->get_assignee($owner)) {
352 352
             $data['group'] = $group->name;
353 353
         }
354 354
 
355
-        if (   $this->root !== $path
355
+        if ($this->root !== $path
356 356
             && $parent = $object->get_parent()) {
357 357
             $data['phash'] = $this->encode($parent->guid);
358 358
         }
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
      * @param  string $mode open mode
412 412
      * @return resource|false
413 413
      */
414
-    protected function _fopen($path, $mode="rb")
414
+    protected function _fopen($path, $mode = "rb")
415 415
     {
416 416
         $document = org_openpsa_documents_document_dba::get_cached($path);
417 417
         $attachments = blobs::get_attachments($document, 'document');
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
      * @param  string    $path  file path
430 430
      * @return bool
431 431
      */
432
-    protected function _fclose($fp, $path='')
432
+    protected function _fclose($fp, $path = '')
433 433
     {
434 434
         fclose($fp);
435 435
         return true;
@@ -611,7 +611,7 @@  discard block
 block discarded – undo
611 611
     {
612 612
         $filename = midcom_db_attachment::safe_filename($name, true);
613 613
         $att = $doc->create_attachment($filename, $name, $mimetype);
614
-        if (   !$att
614
+        if (!$att
615 615
             || !$att->copy_from_handle($fp)) {
616 616
             return false;
617 617
         }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/schemaType.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -34,11 +34,11 @@  discard block
 block discarded – undo
34 34
         $resolver
35 35
             ->setRequired('schema')
36 36
             ->setAllowedTypes('schema', schema::class)
37
-            ->setDefault('action', function (Options $options, $value) {
37
+            ->setDefault('action', function(Options $options, $value) {
38 38
                 return $options['schema']->get('action');
39 39
             });
40 40
 
41
-        $resolver->setNormalizer('csrf_protection', function (Options $options, $value) {
41
+        $resolver->setNormalizer('csrf_protection', function(Options $options, $value) {
42 42
             foreach ($options['schema']->get('fields') as $config) {
43 43
                 if ($config['widget'] === 'csrf') {
44 44
                     return true;
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
             }
47 47
             return false;
48 48
         });
49
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
49
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
50 50
             $validation = $options['schema']->get('validation');
51 51
             if (!empty($validation)) {
52 52
                 $cb_wrapper = new cb_wrapper($validation);
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         // this is mainly there to skip validation in case the user pressed cancel
73 73
         $builder->addEventListener(FormEvents::POST_SUBMIT, function(PostSubmitEvent $event) {
74 74
             $form = $event->getForm();
75
-            if (   $form instanceof Form
75
+            if ($form instanceof Form
76 76
                 && $form->getClickedButton()
77 77
                 && $form->getClickedButton()->getConfig()->getOption('operation') == controller::CANCEL) {
78 78
                 $event->stopPropagation();
Please login to merge, or discard this patch.
lib/fi/protie/navigation/main.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -281,8 +281,8 @@  discard block
 block discarded – undo
281 281
         $classes = [];
282 282
 
283 283
         if ($item[MIDCOM_NAV_TYPE] === 'node') {
284
-            if (   $item[MIDCOM_NAV_ID] === $this->_nap->get_current_node()
285
-                && (   !$this->_nap->get_current_leaf()
284
+            if ($item[MIDCOM_NAV_ID] === $this->_nap->get_current_node()
285
+                && (!$this->_nap->get_current_leaf()
286 286
                     || !$this->_nap->get_leaf($this->_nap->get_current_leaf()))) {
287 287
                 $classes[] = $this->css_active;
288 288
             }
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
         }
317 317
 
318 318
         // Add information about the object's status
319
-        if (   $this->object_status_to_class
319
+        if ($this->object_status_to_class
320 320
             && isset($item[MIDCOM_NAV_OBJECT])
321 321
             && $css_status_class = midcom::get()->metadata->get_object_classes($item[MIDCOM_NAV_OBJECT])) {
322 322
             $classes[] = $css_status_class;
@@ -336,12 +336,12 @@  discard block
 block discarded – undo
336 336
         echo "<a href=\"{$item[MIDCOM_NAV_ABSOLUTEURL]}\"{$link_class}>" . htmlspecialchars($item[MIDCOM_NAV_NAME]) . "</a>";
337 337
         // If either of the follow nodes switches is on, follow all the nodes
338 338
 
339
-        if (   $item[MIDCOM_NAV_TYPE] === 'node'
339
+        if ($item[MIDCOM_NAV_TYPE] === 'node'
340 340
             && !$this->show_only_current
341
-            && (   $this->list_levels === 0
341
+            && ($this->list_levels === 0
342 342
                 || $this->_level < $this->list_levels)) {
343
-            if (   $this->follow_all
344
-                || (   $this->follow_selected
343
+            if ($this->follow_all
344
+                || ($this->follow_selected
345 345
                     && in_array($item[MIDCOM_NAV_ID], $this->node_path, true))) {
346 346
                 $this->_level++;
347 347
                 $this->_list_child_elements($item[MIDCOM_NAV_ID]);
Please login to merge, or discard this patch.
lib/org/openpsa/helpers/fileinfo.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
          * if nothing matched so far and the subtype is alphanumeric, uppercase it on the theory
65 65
          * that it's probably a file extension
66 66
          */
67
-        if (   $st_orig == $subtype
67
+        if ($st_orig == $subtype
68 68
             && preg_match('/^[a-z0-9]+$/', $subtype)) {
69 69
             $subtype = strtoupper($subtype);
70 70
         }
Please login to merge, or discard this patch.
lib/org/openpsa/documents/document.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
             return;
85 85
         }
86 86
         $parent = $this->get_parent();
87
-        if (   $parent
87
+        if ($parent
88 88
             && $parent->component == 'org.openpsa.documents') {
89 89
             midcom::get()->auth->request_sudo('org.openpsa.documents');
90 90
 
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
             $backup_attachment = $backup->create_attachment($original_attachment->name, $original_attachment->title, $original_attachment->mimetype);
155 155
 
156 156
             $original_handle = $original_attachment->open('r');
157
-            if (   !$backup_attachment
157
+            if (!$backup_attachment
158 158
                 || !$original_handle) {
159 159
                 // Failed to copy the attachment, abort
160 160
                 return $backup->delete();
Please login to merge, or discard this patch.
lib/org/openpsa/widgets/contact.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -159,12 +159,12 @@  discard block
 block discarded – undo
159 159
             }
160 160
         }
161 161
 
162
-        if (   $this->_config->get('jabber_enable_presence')
162
+        if ($this->_config->get('jabber_enable_presence')
163 163
             && $person->get_parameter('org.openpsa.jabber', 'jid')) {
164 164
             $this->contact_details['jid'] = $person->get_parameter('org.openpsa.jabber', 'jid');
165 165
         }
166 166
 
167
-        if (   $this->_config->get('skype_enable_presence')
167
+        if ($this->_config->get('skype_enable_presence')
168 168
             && $person->get_parameter('org.openpsa.skype', 'name')) {
169 169
             $this->contact_details['skype'] = $person->get_parameter('org.openpsa.skype', 'name');
170 170
         }
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
         if (!empty($attachments[$type])) {
202 202
             return '<img class="photo" src="' . midcom_db_attachment::get_url($attachments[$type]) . '">';
203 203
         }
204
-        if (   $this->_config->get('gravatar_enable')
204
+        if ($this->_config->get('gravatar_enable')
205 205
             && !empty($this->contact_details['email'])) {
206 206
             $size = ($type == 'view') ? 500 : 32;
207 207
             $gravatar_url = "https://www.gravatar.com/avatar/" . md5(strtolower(trim($this->contact_details['email']))) . "?s=" . $size . '&d=identicon';
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
 
314 314
     private function _show_groups()
315 315
     {
316
-        if (   !$this->show_groups
316
+        if (!$this->show_groups
317 317
             || empty($this->contact_details['id'])) {
318 318
             return;
319 319
         }
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
                     $default_shown = true;
378 378
                     $cards_to_show[] = $cardname;
379 379
                 }
380
-            } elseif (    $customer->$property
380
+            } elseif ($customer->$property
381 381
                       || ($customer->street && !$inherited_cards_only && !$default_shown)) {
382 382
                 $inherited_cards_only = false;
383 383
                 $multiple_addresses = true;
@@ -398,8 +398,8 @@  discard block
 block discarded – undo
398 398
 
399 399
         foreach ($cards_to_show as $cardname) {
400 400
             echo '<div class="vcard">';
401
-            if (   $multiple_addresses
402
-                || (   $cardname != 'visiting'
401
+            if ($multiple_addresses
402
+                || ($cardname != 'visiting'
403 403
                     && !$inherited_cards_only)) {
404 404
                 echo '<div style="text-align:center"><em>' . midcom::get()->i18n->get_string($cardname . ' address', 'org.openpsa.contacts') . "</em></div>\n";
405 405
             }
Please login to merge, or discard this patch.
lib/midcom/services/rcs/handler.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
     {
49 49
         $this->object = midcom::get()->dbfactory->get_object_by_guid($guid);
50 50
 
51
-        if (   !midcom::get()->config->get('midcom_services_rcs_enable')
51
+        if (!midcom::get()->config->get('midcom_services_rcs_enable')
52 52
             || !$this->object->_use_rcs) {
53 53
             throw new midcom_error_notfound("Revision control not supported for " . get_class($this->object) . ".");
54 54
         }
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
             throw new midcom_error_notfound("Revision {$args[1]} does not exist.");
263 263
         }
264 264
 
265
-        $data['preview'] = array_filter($this->backend->get_revision($revision), function ($value, $key) {
265
+        $data['preview'] = array_filter($this->backend->get_revision($revision), function($value, $key) {
266 266
             return !is_array($value)
267 267
                 && !in_array($value, ['', '0000-00-00'])
268 268
                 && midcom_services_rcs::is_field_showable($key);
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
         $this->object->require_do('midgard:update');
293 293
         // TODO: set another privilege for restoring?
294 294
 
295
-        if (   $this->backend->get_history()->version_exists($args[1])
295
+        if ($this->backend->get_history()->version_exists($args[1])
296 296
             && $this->backend->restore_to_revision($args[1])) {
297 297
             midcom::get()->uimessages->add($this->_l10n->get('midcom.admin.rcs'), sprintf($this->_l10n->get('restore to version %s successful'), $args[1]));
298 298
             return new midcom_response_relocate($this->get_object_url());
Please login to merge, or discard this patch.
lib/midcom/admin/rcs/style/midcom-admin-rcs-history.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
         echo "                    <td><a href='" . $data['router']->generate('preview', ['guid' => $guid, 'revision' => $number]) . "'>{$revision['version']}</a></td>\n";
33 33
         echo "                    <td>" . $formatter->datetime($revision['date']) . "</td>\n";
34 34
 
35
-        if (   $revision['user']
35
+        if ($revision['user']
36 36
             && $user = midcom::get()->auth->get_user($revision['user'])) {
37 37
             $person_label = $user->get_storage()->name;
38 38
             echo "                    <td>{$person_label}</td>\n";
Please login to merge, or discard this patch.