Passed
Push — master ( f0a80d...74d5c1 )
by Andreas
18:22
created
lib/midcom/helper/configuration.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
     private function _update_cache()
140 140
     {
141 141
         $this->_merged = $this->_global;
142
-        if (   !empty($this->_local)
142
+        if (!empty($this->_local)
143 143
             && is_array($this->_local)) {
144 144
             $this->_merged = array_merge($this->_merged, $this->_local);
145 145
         }
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
      */
179 179
     public function store(array $params, bool $reset = true)
180 180
     {
181
-        if (   !$this->_object_stored
181
+        if (!$this->_object_stored
182 182
             && $this->_object) {
183 183
             $this->_store_from_object();
184 184
         }
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
      */
258 258
     public function get_all() : array
259 259
     {
260
-        if (   !$this->_object_stored
260
+        if (!$this->_object_stored
261 261
             && $this->_object) {
262 262
             $this->_store_from_object();
263 263
         }
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
      */
271 271
     public function exists(string $key) : bool
272 272
     {
273
-        if (   !$this->_object_stored
273
+        if (!$this->_object_stored
274 274
             && $this->_object) {
275 275
             $this->_store_from_object();
276 276
         }
Please login to merge, or discard this patch.
lib/midcom/helper/imagefilter.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
             debug_add("The File {$filename} is not writable.", MIDCOM_LOG_ERROR);
188 188
             return false;
189 189
         }
190
-        if (   !empty($this->_filename)
190
+        if (!empty($this->_filename)
191 191
             && $this->_filename !== $filename) {
192 192
             $this->_tmpfiles[] = $this->_filename;
193 193
         }
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
         $tmpfile = null;
393 393
         $imagesize = getimagesize($this->_filename);
394 394
 
395
-        if (   $imagesize[2] == IMAGETYPE_JPEG
395
+        if ($imagesize[2] == IMAGETYPE_JPEG
396 396
             && $this->_jpegtran_available()) {
397 397
             /* jpegtran */
398 398
             $operations = [
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
         $imagesize = getimagesize($this->_filename);
461 461
 
462 462
         // Try lossless jpegtran rotation if possible
463
-        if (   $imagesize[2] == IMAGETYPE_JPEG
463
+        if ($imagesize[2] == IMAGETYPE_JPEG
464 464
             && ($rotate % 90 == 0)
465 465
             && $this->_jpegtran_available()) {
466 466
             $tmpfile = $this->_get_tempfile();
@@ -590,7 +590,7 @@  discard block
 block discarded – undo
590 590
      */
591 591
     public function fill($x = null, $y = null, $color = null, string $gravity = 'center')
592 592
     {
593
-        if (   empty($x)
593
+        if (empty($x)
594 594
             || empty($y)
595 595
             || empty($color)) {
596 596
             //This is a bit silly, but here for backwards compatibility...
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 {
16 16
     public function get_url(midcom_db_article $article, bool $allow_external = false) : string
17 17
     {
18
-        if (   $allow_external
18
+        if ($allow_external
19 19
             && $this->_config->get('link_to_external_url')
20 20
             && !empty($article->url)) {
21 21
             return $article->url;
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
         $qb->add_constraint('topic.guid', 'IN', $topic_guids);
69 69
 
70
-        if (   count($topic_guids) > 1
70
+        if (count($topic_guids) > 1
71 71
             && $list_from_folders_categories = $this->_config->get('list_from_folders_categories')) {
72 72
             $list_from_folders_categories = explode(',', $list_from_folders_categories);
73 73
 
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
         // Hide the articles that have the publish time in the future and if
85 85
         // the user is not administrator
86
-        if (   $this->_config->get('enable_scheduled_publishing')
86
+        if ($this->_config->get('enable_scheduled_publishing')
87 87
             && !midcom::get()->auth->admin) {
88 88
             // Show the article only if the publishing time has passed or the viewer
89 89
             // is the author
Please login to merge, or discard this patch.
lib/org/openpsa/core/acl/synchronizer.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 {
16 16
     public function write_acls(midcom_core_dbaobject $object, $owner_id, int $accesstype) : bool
17 17
     {
18
-        if (   empty($owner_id)
18
+        if (empty($owner_id)
19 19
             || empty($accesstype)) {
20 20
             return false;
21 21
         }
@@ -63,14 +63,14 @@  discard block
 block discarded – undo
63 63
 
64 64
         if ($privileges) {
65 65
             foreach ($privileges as $privilege) {
66
-                if (   !empty($needed_privileges[$privilege->privilegename])
66
+                if (!empty($needed_privileges[$privilege->privilegename])
67 67
                     && $needed_privileges[$privilege->privilegename]['assignee'] == $privilege->assignee
68 68
                     && $needed_privileges[$privilege->privilegename]['value'] == $privilege->value) {
69 69
                     unset($needed_privileges[$privilege->privilegename]);
70 70
                     continue;
71 71
                 }
72 72
                 // Clear old ACLs applying to others than current user or selected owner group
73
-                if (   $privilege->assignee != midcom::get()->auth->user->id
73
+                if ($privilege->assignee != midcom::get()->auth->user->id
74 74
                     && $privilege->assignee != $owner_id) {
75 75
                     debug_add("Removing privilege {$privilege->privilegename} from {$privilege->assignee}");
76 76
                     $object->unset_privilege($privilege->privilegename, $privilege->assignee);
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/message/compose.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         }
60 60
 
61 61
         //Substyle handling
62
-        if (   !empty($data['message_array']['substyle'])
62
+        if (!empty($data['message_array']['substyle'])
63 63
             && !preg_match('/^builtin:/', $data['message_array']['substyle'])) {
64 64
             debug_add("Appending substyle {$data['message_array']['substyle']}");
65 65
             midcom::get()->style->append_substyle($data['message_array']['substyle']);
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     private function _real_show_compose(string $handler_id, array &$data)
113 113
     {
114 114
         $prefix = '';
115
-        if (   !empty($data['message_array']['substyle'])
115
+        if (!empty($data['message_array']['substyle'])
116 116
             && preg_match('/^builtin:(.*)/', $data['message_array']['substyle'], $matches_style)) {
117 117
             $prefix = $matches_style[1] . '-';
118 118
         }
Please login to merge, or discard this patch.
lib/midcom/db/attachment.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -318,7 +318,7 @@
 block discarded – undo
318 318
     public function update_cache()
319 319
     {
320 320
         // Check if the attachment can be read anonymously
321
-        if (   midcom::get()->config->get('attachment_cache_enabled')
321
+        if (midcom::get()->config->get('attachment_cache_enabled')
322 322
             && !$this->can_do('midgard:read', 'EVERYONE')) {
323 323
             // Not public file, ensure it is removed
324 324
             $this->remove_from_cache();
Please login to merge, or discard this patch.
lib/midcom/baseclasses/components/viewer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@
 block discarded – undo
246 246
      */
247 247
     public function prepare_handler(array &$parameters)
248 248
     {
249
-        $this->parameters =& $parameters;
249
+        $this->parameters = & $parameters;
250 250
 
251 251
         $parameters['handler'] = explode('::', $parameters['_controller'], 2);
252 252
 
Please login to merge, or discard this patch.
lib/midcom/exec/reindex.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 $reindex_topic_uri = midcom::get()->get_page_prefix() . 'midcom-exec-midcom/reindex_singlenode.php';
48 48
 
49 49
 $options = ['timeout' => 300];
50
-if (   !empty($_SERVER['PHP_AUTH_USER'])
50
+if (!empty($_SERVER['PHP_AUTH_USER'])
51 51
     && !empty($_SERVER['PHP_AUTH_PW'])) {
52 52
     $options['auth'] = ['user' => $_SERVER['PHP_AUTH_USER'], 'password' => $_SERVER['PHP_AUTH_PW']];
53 53
 }
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
             } else {
66 66
                 echo "OK.\n";
67 67
             }
68
-        }, function (RequestException $e) use ($uri) {
68
+        }, function(RequestException $e) use ($uri) {
69 69
             echo "failure.\n   Background processing failed, error: {$e->getMessage()}\n";
70 70
             echo "Url: " . $uri . "\n";
71 71
         })->wait();
Please login to merge, or discard this patch.
lib/org/openpsa/products/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
      */
53 53
     public function _on_reindex($topic, midcom_helper_configuration $config, midcom_services_indexer &$indexer)
54 54
     {
55
-        if (   !$config->get('index_products')
55
+        if (!$config->get('index_products')
56 56
             && !$config->get('index_groups')) {
57 57
             debug_add("No indexing to groups and products, skipping", MIDCOM_LOG_WARN);
58 58
             return true;
Please login to merge, or discard this patch.