flack / openpsa

lib/midgard/admin/user/handler/group/list.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
                 midcom::get()->uimessages->add($this->_l10n->get('midgard.admin.user'), $this->_l10n_midcom->get('updated'));
                 return new midcom_response_relocate($this->router->generate('group_edit', ['guid' => $guid]));
             }
-            debug_add('Failed to update the group, last error was '. midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
+            debug_add('Failed to update the group, last error was ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
             debug_print_r('We operated on this object', $data['group'], MIDCOM_LOG_ERROR);
 
             throw new midcom_error('Failed to update the group, see error level log for details');

lib/midcom/helper/imagepopup/handler/list.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
         midcom::get()->auth->require_valid_user();
         midcom::get()->skip_page_style = true;
 
-        $this->add_stylesheet(MIDCOM_STATIC_URL ."/midcom.helper.imagepopup/styling.css", 'screen');
+        $this->add_stylesheet(MIDCOM_STATIC_URL . "/midcom.helper.imagepopup/styling.css", 'screen');
 
         $data['filetype'] = $filetype;
         $data['object'] = null;

lib/org/openpsa/user/handler/person/account.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
         $response = $workflow->run($request);
 
-        if (   $workflow->get_state() == 'save'
+        if ($workflow->get_state() == 'save'
             && $this->create_account($this->person, $data["controller"]->get_form_values())) {
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), sprintf($this->_l10n->get('person %s created'), $this->person->name));
         }
@@ -148,7 +148,7 @@ 
         $accounthelper = new org_openpsa_user_accounthelper($this->person);
 
         // Update account
-        if (   !$accounthelper->set_account($controller->get_form_values()["username"], $password)
+        if (!$accounthelper->set_account($controller->get_form_values()["username"], $password)
             && midcom_connection::get_error() != MGD_ERR_OK) {
             // Failure, give a message
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get("failed to update the user account, reason") . ': ' . midcom_connection::get_error_string(), 'error');

src/midcom/datamanager/controller.php

Spacing +3 added lines, -3 removed lines

@@ -70,13 +70,13 @@ 
             }
         } elseif (!$this->form->isSubmitted()) {
             $this->form->handleRequest($request);
-            if (   $this->form->isSubmitted()
+            if ($this->form->isSubmitted()
                 && $button = $this->form->getClickedButton()) {
                 $operation = $button->getConfig()->getOption('operation');
             }
         }
 
-        if (   in_array($operation, [self::SAVE, self::NEXT])
+        if (in_array($operation, [self::SAVE, self::NEXT])
             && !$this->form->isValid()) {
             $operation = self::EDIT;
         }
@@ -159,7 +159,7 @@ 
                 if ($storage->get_last_operation() === self::SAVE) {
                     // Get GUIDs and such for new-created dependent objects
                     $this->dm->set_storage($storage->get_value(), $this->dm->get_schema()->get_name());
-                } elseif (   !$this->form->isValid()
+                } elseif (!$this->form->isValid()
                           && $storage->move_uploaded_files() > 0) {
                     $form = $this->dm->get_form($this->form->getName(), true);
                     $this->copy_errors($this->form, $form);

lib/org/openpsa/directmarketing/importer.php

Spacing +4 added lines, -4 removed lines

@@ -121,7 +121,7 @@ 
                 }
             }
 
-            if (   !$person
+            if (!$person
                 && !empty($subscriber['person']['handphone'])) {
                 // Perform a simple cell phone test. More complicated duplicate checking is best left to the o.o.contacts duplicate checker
                 $qb = org_openpsa_contacts_person_dba::new_query_builder();
@@ -167,7 +167,7 @@ 
             // User is or has been subscriber earlier, update status
             $member = $members[0];
 
-            if (   $member->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED
+            if ($member->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED
                 || $member->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_member_dba::NORMAL) {
                 $this->_import_status['already_subscribed']++;
                 return;
@@ -207,7 +207,7 @@ 
 
             $qb = org_openpsa_contacts_group_dba::new_query_builder();
             $schema = $this->_schemadbs['organization']->get('default');
-            if (   $schema->has_field('company_id')
+            if ($schema->has_field('company_id')
                 && !empty($subscriber['organization']['company_id'])) {
                 // Imported data has a company id, we use that instead of name
                 $qb->add_constraint($schema->get_field('company_id')['storage']['location'], '=', $subscriber['organization']['company_id']);
@@ -215,7 +215,7 @@ 
                 // Seek by official name
                 $qb->add_constraint('official', '=', $subscriber['organization']['official']);
 
-                if (   $schema->has_field('city')
+                if ($schema->has_field('city')
                     && !empty($subscriber['organization']['city'])) {
                     // Imported data has a city, we use also that for matching
                     $qb->add_constraint($schema->get_field('city')['storage']['location'], '=', $subscriber['organization']['city']);

lib/net/nehmer/blog/style/feeds-item.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
 $item->title = $data['article']->title;
 $arg = $data['article']->name ?: $data['article']->guid;
 
-if (   $data['config']->get('link_to_external_url')
+if ($data['config']->get('link_to_external_url')
     && !empty($data['article']->url)) {
     $item->link = $data['article']->url;
 } else {
@@ -37,7 +37,7 @@ 
     $item->description .= '<div class="abstract">' . $view['abstract'] . '</div>';
 }
 
-if (   array_key_exists('image', $view)
+if (array_key_exists('image', $view)
     && $data['config']->get('rss_use_image')) {
     $item->description .= "\n<div class=\"image\">" . $view['image'] . '</div>';
 }

lib/org/openpsa/projects/style/show-frontpage.php

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('ongoing') . "\">{$task_count['ongoing']}</span></td>\n";
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('on_hold') . "\">{$task_count['on_hold']}</span></td>\n";
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('closed') . "\">{$task_count['closed']}</span></td>\n";
-            echo "        <td class=\"numeric\"> " ;
+            echo "        <td class=\"numeric\"> ";
             echo "            <span title=\"" . $data['l10n']->get('reported') . "\">" . round($hours['reportedHours'], 2) . "</span>";
             if ($hours['plannedHours'] > 0) {
                 echo          " / <span title=\"" . $data['l10n']->get('planned hours') . "\">" . round($hours['plannedHours'], 2) . "</span>";

lib/org/openpsa/documents/handler/document/admin.php

Spacing +1 added lines, -1 removed lines

@@ -101,7 +101,7 @@
 
         $this->_controller = $this->load_controller();
 
-        if (   $data['enable_versioning']
+        if ($data['enable_versioning']
             && $request->request->count() > 0) {
             $this->_backup_attachment();
         }

lib/midgard/admin/asgard/handler/type.php

Spacing +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
         }
 
         $help = new midcom_admin_help_help();
-        $this->_request_data['help'] = $help->get_help_contents('asgard_'.$this->type, $help_component);
+        $this->_request_data['help'] = $help->get_help_contents('asgard_' . $this->type, $help_component);
         $this->_request_data['component'] = $component;
     }