flack / openpsa

lib/org/openpsa/expenses/handler/index.php

Braces +4 added lines, -2 removed lines

@@ -114,7 +114,8 @@ 
         foreach ($hours as $guid => $row) {
             try {
                 $task = org_openpsa_projects_task_dba::get_cached($row['task']);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 // Task couldn't be loaded, probably because of ACL
                 continue;
             }
@@ -127,7 +128,8 @@ 
                     $person_object = org_openpsa_contacts_person_dba::get_cached($row['person']);
                     $person_label = $this->_get_list_link($person_object->name, null, null, $row['person']);
                     $person_name = $person_object->name;
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $person_label = $this->_l10n->get('no person');
                     $person_name = '';
                 }

lib/net/nemein/redirector/handler/redirect.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
 
         // Catch first the configuration option for showing editing interface instead
         // of redirecting administrators
-        if (   $this->_topic->can_do('net.nemein.redirector:noredirect')
+        if ($this->_topic->can_do('net.nemein.redirector:noredirect')
             && !$this->_config->get('admin_redirection')) {
             return new midcom_response_relocate("{$this->_topic->name}/edit/{$args[0]}/");
         }

lib/midcom/baseclasses/components/handler.php

Spacing +2 added lines, -2 removed lines

@@ -108,12 +108,12 @@
         $this->_master = $master;
         $this->router = $router;
 
-        $this->_request_data =& $master->_request_data;
+        $this->_request_data = & $master->_request_data;
         $this->_topic = $master->_topic;
 
         // Load component specific stuff, special treatment if the handler has
         // a component different than the master handler set.
-        if (   $this->_component
+        if ($this->_component
             && $this->_component != $master->_component) {
             $this->_config->store_from_object($this->_topic, $this->_component, true);
         } else {

lib/midcom/helper/search/style/basic_form.php

Spacing +3 added lines, -3 removed lines

@@ -5,13 +5,13 @@
 ?>
 <form method='get' name='midcom_helper_search_form' action='&(action);' class='midcom.helper.search'>
 <label for="midcom_helper_search_query">
-<?php echo $data['l10n']->get('query');?>:
+<?php echo $data['l10n']->get('query'); ?>:
 <input type='text' size='60' name='query' id='midcom_helper_search_query' value=&(query:h); />
 </label>
 <input type='hidden' name='type' value='basic' />
 <input type='hidden' name='page' value='1' />
-<input type='submit' name='submit' value='<?php echo $data['l10n']->get('search');?>' />
+<input type='submit' name='submit' value='<?php echo $data['l10n']->get('search'); ?>' />
 </form>
 <p>
-  <a href="&(advanced);&(data['params']);"><?php echo $data['l10n']->get('advanced search');?></a>
+  <a href="&(advanced);&(data['params']);"><?php echo $data['l10n']->get('advanced search'); ?></a>
 </p>
\ No newline at end of file

lib/midgard/admin/asgard/style/midgard_admin_asgard_stylehelper_elementnames.php

Spacing +1 added lines, -1 removed lines

@@ -7,7 +7,7 @@
             $link = $data['router']->generate('components_component', ['component' => $component]);
 
             echo "<li class=\"component\">";
-            echo "<a href=\"{$link}\">" . midcom::get()->i18n->get_string($component, $component) ." </a>\n";
+            echo "<a href=\"{$link}\">" . midcom::get()->i18n->get_string($component, $component) . " </a>\n";
             echo "<ul>\n";
             foreach ($elements as $name => $path) {
                 echo "<li>";

lib/midgard/admin/asgard/handler/object/manage.php

Braces +2 added lines, -1 removed lines

@@ -61,7 +61,8 @@
     {
         try {
             $this->_object = midcom::get()->dbfactory->get_object_by_guid($guid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             if (midcom_connection::get_error() == MGD_ERR_OBJECT_DELETED) {
                 $relocate = $this->router->generate('object_deleted', ['guid' => $guid]);
                 midcom::get()->relocate($relocate);

Spacing +2 added lines, -2 removed lines

@@ -223,10 +223,10 @@
             $new_type_reflector = midcom_helper_reflector::get($new_type);
             $link_properties = $new_type_reflector->get_link_properties();
             foreach ($link_properties as $property => $link) {
-                if (   ($link['class'] && midcom_helper_reflector::is_same_class($link['class'], $this->_object->__mgdschema_class_name__))
+                if (($link['class'] && midcom_helper_reflector::is_same_class($link['class'], $this->_object->__mgdschema_class_name__))
                     || $link['type'] == MGD_TYPE_GUID) {
                     $defaults[$property] = $this->_object->{$link['target']};
-                } elseif (   $property == $parent_property
+                } elseif ($property == $parent_property
                           && midcom_helper_reflector::is_same_class($new_type, $this->_object->__mgdschema_class_name__)) {
                     $defaults[$property] = $this->_object->$parent_property;
                 }

lib/org/openpsa/user/style/show-person-account.php

Indentation +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
             echo '<span class="toolbar_label">' . $data['l10n_midcom']->get('delete') . '</span></a></li>';
             if (    midcom::get()->config->get('auth_allow_trusted') === true
                  && $data['person']->can_do('org.openpsa.user:su')) {
-                 echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '" />' . $data['l10n']->get('switch to user') . "</a></li>\n";
+                    echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '" />' . $data['l10n']->get('switch to user') . "</a></li>\n";
             }
             echo "</ul>\n";
         }

Spacing +4 added lines, -4 removed lines

@@ -13,7 +13,7 @@ 
             $formatter = $data['l10n']->get_formatter();
             echo '<p>' . $data['l10n']->get('last login') . ': ' . $formatter->datetime($lastlogin) . "</p>\n";
         }
-        if (   $data['person']->id == midcom_connection::get_user()
+        if ($data['person']->id == midcom_connection::get_user()
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $workflow = new midcom\workflow\datamanager;
             echo '<ul class="area_toolbar">';
@@ -22,9 +22,9 @@ 
                 'object' => $data['person'],
                 'label' => $data['l10n']->get('account')
             ]);
-            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]). '" ' . $workflow->render_attributes() . '"  class="button">';
+            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]) . '" ' . $workflow->render_attributes() . '"  class="button">';
             echo '<span class="toolbar_label">' . $data['l10n_midcom']->get('delete') . '</span></a></li>';
-            if (    midcom::get()->config->get('auth_allow_trusted') === true
+            if (midcom::get()->config->get('auth_allow_trusted') === true
                  && $data['person']->can_do('org.openpsa.user:su')) {
                  echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '" />' . $data['l10n']->get('switch to user') . "</a></li>\n";
             }
@@ -32,7 +32,7 @@ 
         }
     } else {
         echo '<p><span class="metadata">' . $data['l10n']->get("no account") . '</span></p>';
-        if (   $data['person']->id == midcom_connection::get_user()
+        if ($data['person']->id == midcom_connection::get_user()
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $workflow = new midcom\workflow\datamanager;
             echo '<ul class="area_toolbar">';

lib/org/openpsa/user/handler/person/view.php

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
         $this->add_breadcrumb('', $this->_person->get_label());
 
         $auth = midcom::get()->auth;
-        if (   $this->_person->id == midcom_connection::get_user()
+        if ($this->_person->id == midcom_connection::get_user()
             || $auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $buttons = [];
             $workflow = $this->get_workflow('datamanager');
@@ -49,7 +49,7 @@ 
                 $delete_workflow = $this->get_workflow('delete', ['object' => $this->_person]);
                 $buttons[] = $delete_workflow->get_button($this->router->generate('user_delete', ['guid' => $this->_person->guid]));
             }
-            if (   midcom_connection::is_user($this->_person)
+            if (midcom_connection::is_user($this->_person)
                 && $this->_person->can_do('midgard:privileges')) {
                 $buttons[] = $workflow->get_button($this->router->generate('user_privileges', ['guid' => $this->_person->guid]), [
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get("permissions"),

lib/org/openpsa/directmarketing/viewer.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
      */
     private function _populate_node_toolbar()
     {
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
             $workflow = $this->get_workflow('datamanager');
             $this->_node_toolbar->add_item($workflow->get_button($this->router->generate('config'), [