flack / openpsa

lib/midcom/helper/toolbar.php

Spacing +16 added lines, -16 removed lines

@@ -223,7 +223,7 @@ 
      * @see midcom_helper_toolbar::_check_index()
      * @see midcom_helper_toolbar::clean_item()
      */
-    public function add_item(array $item, string|int $before = -1)
+    public function add_item(array $item, string | int $before = -1)
     {
         if ($before != -1) {
             $before = $this->_check_index($before, false);
@@ -249,7 +249,7 @@ 
      *     it before a URL, an integer will insert it before a
      *     given index.
      */
-    public function add_items(array $items, string|int $before = -1)
+    public function add_items(array $items, string | int $before = -1)
     {
         foreach ($items as $item) {
             $this->add_item($item, $before);
@@ -279,7 +279,7 @@ 
 
         $item = array_replace($defaults, $item);
 
-        if (   !empty($item[MIDCOM_TOOLBAR_ACCESSKEY])
+        if (!empty($item[MIDCOM_TOOLBAR_ACCESSKEY])
             && !array_key_exists($item[MIDCOM_TOOLBAR_ACCESSKEY], $used_access_keys)) {
             // We have valid access key, add it to help text
             $prefix = 'Alt-';
@@ -304,7 +304,7 @@ 
     private function set_url(array &$item, string $url)
     {
         $item[MIDCOM_TOOLBAR__ORIGINAL_URL] = $url;
-        if (   (   empty($item[MIDCOM_TOOLBAR_OPTIONS]["rel"])
+        if ((empty($item[MIDCOM_TOOLBAR_OPTIONS]["rel"])
                 // Some items may want to keep their links unmutilated
                 || $item[MIDCOM_TOOLBAR_OPTIONS]["rel"] != "directlink")
             && !str_starts_with($url, '/')
@@ -323,13 +323,13 @@ 
      * @see midcom_helper_toolbar::get_index_from_url()
      * @see midcom_helper_toolbar::_check_index()
      */
-    public function remove_item(string|int $index)
+    public function remove_item(string | int $index)
     {
         $index = $this->_check_index($index);
 
         if ($index == 0) {
             array_shift($this->items);
-        } elseif ($index == count($this->items) -1) {
+        } elseif ($index == count($this->items) - 1) {
             array_pop($this->items);
         } else {
             $this->items = array_merge(array_slice($this->items, 0, $index),
@@ -350,7 +350,7 @@ 
      *
      * @param string|int $index The integer index or URL of the item to enable.
      */
-    public function enable_item(string|int $index)
+    public function enable_item(string | int $index)
     {
         $index = $this->_check_index($index);
         $this->items[$index][MIDCOM_TOOLBAR_ENABLED] = true;
@@ -361,7 +361,7 @@ 
      *
      * @param string|int $index The integer index or URL of the item to disable.
      */
-    public function disable_item(string|int $index)
+    public function disable_item(string | int $index)
     {
         $index = $this->_check_index($index, false);
 
@@ -375,7 +375,7 @@ 
      *
      * @param string|int $index The integer index or URL of the item to hide.
      */
-    public function hide_item(string|int $index)
+    public function hide_item(string | int $index)
     {
         $index = $this->_check_index($index, false);
 
@@ -389,7 +389,7 @@ 
      *
      * @param string|int $index The integer index or URL of the item to show.
      */
-    public function show_item(string|int $index)
+    public function show_item(string | int $index)
     {
         $index = $this->_check_index($index);
         $this->items[$index][MIDCOM_TOOLBAR_HIDDEN] = false;
@@ -403,7 +403,7 @@ 
      * @see midcom_helper_toolbar::_check_index()
      * @see midcom_helper_toolbar::add_item()
      */
-    public function update_item_url(string|int $index, string $url)
+    public function update_item_url(string | int $index, string $url)
     {
         $index = $this->_check_index($index);
         $this->set_url($this->items[$index], $url);
@@ -414,7 +414,7 @@ 
      */
     public function render() : string
     {
-        $visible_items = array_filter($this->items, function ($item) {
+        $visible_items = array_filter($this->items, function($item) {
             return !$item[MIDCOM_TOOLBAR_HIDDEN];
         });
         $this->rendered = true;
@@ -480,7 +480,7 @@ 
             // Try finding uppercase version of the accesskey first
             $accesskey = strtoupper($item[MIDCOM_TOOLBAR_ACCESSKEY]);
             $position = strpos($label, $accesskey);
-            if (   $position === false
+            if ($position === false
                 && midcom::get()->i18n->get_current_language() == 'en') {
                 // Try lowercase, too
                 $accesskey = strtolower($accesskey);
@@ -540,7 +540,7 @@ 
             $attributes['title'] = $item[MIDCOM_TOOLBAR_HELPTEXT];
         }
 
-        if (   $item[MIDCOM_TOOLBAR_ENABLED]
+        if ($item[MIDCOM_TOOLBAR_ENABLED]
             && $item[MIDCOM_TOOLBAR_ACCESSKEY] !== null) {
             $attributes['class'] = 'accesskey';
             $attributes['accesskey'] = $item[MIDCOM_TOOLBAR_ACCESSKEY];
@@ -591,7 +591,7 @@ 
     public function get_index_from_url(string $url) : ?int
     {
         foreach ($this->items as $i => $item) {
-            if (   $item[MIDCOM_TOOLBAR_URL] == $url
+            if ($item[MIDCOM_TOOLBAR_URL] == $url
                 || $item[MIDCOM_TOOLBAR__ORIGINAL_URL] == $url) {
                 return $i;
             }
@@ -609,7 +609,7 @@ 
      *
      * @param string|int $index The integer index or URL to check
      */
-    protected function _check_index(string|int $index, bool $raise_error = true) :?int
+    protected function _check_index(string | int $index, bool $raise_error = true) : ?int
     {
         if (is_string($index)) {
             $url = $index;

lib/midcom/services/indexer/main.php

Spacing +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
      *
      * @return boolean Indicating success.
      */
-    public function index(midcom_services_indexer_document|array $documents) : bool
+    public function index(midcom_services_indexer_document | array $documents) : bool
     {
         if ($this->_disabled) {
             return true;

lib/midcom/services/dbclassloader.php

Spacing +2 added lines, -2 removed lines

@@ -107,7 +107,7 @@ 
      * Get a MidCOM DB class name for a MgdSchema Object.
      * We also ensure that the corresponding component has been loaded.
      */
-    public function get_midcom_class_name_for_mgdschema_object(string|object $classname) : ?string
+    public function get_midcom_class_name_for_mgdschema_object(string | object $classname) : ?string
     {
         static $dba_classes_by_mgdschema = [];
 
@@ -157,7 +157,7 @@ 
      * Simple helper to check whether we are dealing with a MidCOM Database object
      * or a subclass thereof.
      */
-    public function is_midcom_db_object(object|string $object) : bool
+    public function is_midcom_db_object(object | string $object) : bool
     {
         return is_subclass_of($object, midcom_core_dbaobject::class)
             || is_a($object, midcom_core_dbaproxy::class, true);

lib/midcom/core/user.php

Spacing +2 added lines, -2 removed lines

@@ -417,7 +417,7 @@ 
      * 2. A group string identifier, matching the regex ^group:
      * 3. A valid midcom group name
      */
-    public function is_in_group(midcom_core_group|string $group) : bool
+    public function is_in_group(midcom_core_group | string $group) : bool
     {
         if ($this->_all_groups === null) {
             $this->_load_all_groups();
@@ -475,7 +475,7 @@ 
 
         $timeout = midcom::get()->config->get('auth_login_session_timeout', 0);
         $last_seen = $person->get_parameter('midcom', 'online');
-        if (   !$last_seen
+        if (!$last_seen
             || ($timeout > 0 && time() - $timeout > $last_seen)) {
             return 'offline';
         }

lib/midcom/core/dbaproxy.php

Spacing +2 added lines, -2 removed lines

@@ -22,11 +22,11 @@
     /**
      * MidCOM DBA object identifier, can be ID or GUID
      */
-    private string|int $__identifier;
+    private string | int $__identifier;
 
     private bool $__tried_to_load = false;
 
-    public function __construct(string|int $identifier, string $classname)
+    public function __construct(string | int $identifier, string $classname)
     {
         $this->__midcom_class_name__ = $classname;
         $this->__identifier = $identifier;

lib/org/openpsa/widgets/contact.php

Spacing +8 added lines, -8 removed lines

@@ -93,7 +93,7 @@ 
     /**
      * Retrieve an object, uses in-request caching
      */
-    public static function get(string|int $src) : self
+    public static function get(string | int $src) : self
     {
         static $cache = [];
 
@@ -136,12 +136,12 @@ 
             }
         }
 
-        if (   $this->_config->get('jabber_enable_presence')
+        if ($this->_config->get('jabber_enable_presence')
             && $person->get_parameter('org.openpsa.jabber', 'jid')) {
             $this->contact_details['jid'] = $person->get_parameter('org.openpsa.jabber', 'jid');
         }
 
-        if (   $this->_config->get('skype_enable_presence')
+        if ($this->_config->get('skype_enable_presence')
             && $person->get_parameter('org.openpsa.skype', 'name')) {
             $this->contact_details['skype'] = $person->get_parameter('org.openpsa.skype', 'name');
         }
@@ -178,7 +178,7 @@ 
         if (!empty($attachments[$type])) {
             return '<img class="photo" src="' . midcom_db_attachment::get_url($attachments[$type]) . '">';
         }
-        if (   $this->_config->get('gravatar_enable')
+        if ($this->_config->get('gravatar_enable')
             && !empty($this->contact_details['email'])) {
             $size = ($type == 'view') ? 500 : 32;
             $gravatar_url = "https://www.gravatar.com/avatar/" . md5(strtolower(trim($this->contact_details['email']))) . "?s=" . $size . '&d=identicon';
@@ -291,7 +291,7 @@ 
 
     private function _show_groups()
     {
-        if (   !$this->show_groups
+        if (!$this->show_groups
             || empty($this->contact_details['id'])) {
             return;
         }
@@ -355,7 +355,7 @@ 
                     $default_shown = true;
                     $cards_to_show[] = $cardname;
                 }
-            } elseif (    $customer->$property
+            } elseif ($customer->$property
                       || ($customer->street && !$inherited_cards_only && !$default_shown)) {
                 $inherited_cards_only = false;
                 $multiple_addresses = true;
@@ -377,8 +377,8 @@ 
 
         foreach ($cards_to_show as $cardname) {
             echo '<div class="vcard">';
-            if (   $multiple_addresses
-                || (   $cardname != 'visiting'
+            if ($multiple_addresses
+                || ($cardname != 'visiting'
                     && !$inherited_cards_only)) {
                 echo '<div style="text-align:center"><em>' . midcom::get()->i18n->get_string($cardname . ' address', 'org.openpsa.contacts') . "</em></div>\n";
             }

lib/org/openpsa/invoices/billing/data.php

Spacing +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
      */
     public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self
     {
-        if (   !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
+        if (!($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
                // check if the customerContact is set and has invoice_data
             && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) {
             $bd = new self();
@@ -68,7 +68,7 @@ 
     /**
      * Get the billing data for given contact if any.
      */
-    private static function get_billing_data(string $dba_class, string|int $contact_id) : ?self
+    private static function get_billing_data(string $dba_class, string | int $contact_id) : ?self
     {
         if ($contact_id == 0) {
             return null;

lib/midcom/helper/toolbar/node.php

Spacing +3 added lines, -3 removed lines

@@ -54,7 +54,7 @@ 
         }
         $buttons = [];
         $workflow = new midcom\workflow\datamanager;
-        if (   $this->topic->can_do('midgard:update')
+        if ($this->topic->can_do('midgard:update')
             && $this->topic->can_do('midcom.admin.folder:topic_management')) {
             $buttons[] = $workflow->get_button("__ais/folder/edit/", [
                 MIDCOM_TOOLBAR_LABEL => midcom::get()->i18n->get_string('edit folder', 'midcom.admin.folder'),
@@ -89,7 +89,7 @@ 
             ];
         }
         $buttons = array_merge($buttons, $this->get_approval_controls($this->topic, false));
-        if (   $this->topic->can_do('midcom.admin.folder:template_management')
+        if ($this->topic->can_do('midcom.admin.folder:template_management')
             && midcom::get()->auth->can_user_do('midgard.admin.asgard:manage_objects', class: 'midgard_admin_asgard_plugin')) {
             $enabled = false;
             $styleeditor_url = '';
@@ -122,7 +122,7 @@ 
                     MIDCOM_TOOLBAR_ACCESSKEY => 'f',
                 ]);
             }
-            if (   $this->topic->guid !== midcom::get()->config->get('midcom_root_topic_guid')
+            if ($this->topic->guid !== midcom::get()->config->get('midcom_root_topic_guid')
                 && $this->topic->can_do('midgard:delete')) {
                 $workflow = new midcom\workflow\delete(['object' => $this->topic, 'recursive' => true]);
                 $buttons[] = $workflow->get_button("__ais/folder/delete/", [

lib/midcom/services/uimessages.php

Spacing +1 added lines, -1 removed lines

@@ -133,7 +133,7 @@
      */
     public function show(bool $show_simple = false)
     {
-        if (   $show_simple
+        if ($show_simple
             || !midcom::get()->auth->can_user_do('midcom:ajax', class: static::class)) {
             $this->show_simple();
             return;