flack / openpsa

lib/midgard/admin/asgard/toolbar.php

Spacing +3 added lines, -3 removed lines

@@ -142,7 +142,7 @@ 
             ];
         }
 
-        if (   midcom::get()->config->get('midcom_services_rcs_enable')
+        if (midcom::get()->config->get('midcom_services_rcs_enable')
             && $object->can_do('midgard:update')
             && $object->_use_rcs) {
             $buttons[] = [
@@ -203,7 +203,7 @@ 
     private function get_toolbar_update_items(midcom_core_dbaobject $object) : array
     {
         $buttons = [];
-        if (   $object instanceof midcom_db_topic
+        if ($object instanceof midcom_db_topic
             && $object->component
             && $object->can_do('midcom:component_config')) {
             $buttons[] = [
@@ -241,7 +241,7 @@ 
             MIDCOM_TOOLBAR_ENABLED => $object->can_do('midgard:privileges'),
         ];
 
-        if (   midcom::get()->componentloader->is_installed('midcom.helper.replicator')
+        if (midcom::get()->componentloader->is_installed('midcom.helper.replicator')
             && midcom::get()->auth->admin) {
             $buttons[] = [
                 MIDCOM_TOOLBAR_URL => "__mfa/asgard_midcom.helper.replicator/object/{$object->guid}/",

src/midcom/httpkernel/subscriber.php

Spacing +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
         $i = array_search('__request_data__', $arguments, true);
         if ($i !== false) {
             $context = $event->getRequest()->attributes->get('context');
-            $arguments[$i] =& $context->get_custom_key('request_data');
+            $arguments[$i] = & $context->get_custom_key('request_data');
             $event->setArguments($arguments);
         }
     }

lib/midcom/baseclasses/components/viewer.php

Spacing +1 added lines, -1 removed lines

@@ -246,7 +246,7 @@
      */
     public function prepare_handler(midcom_baseclasses_components_handler $handler, array &$parameters)
     {
-        $this->parameters =& $parameters;
+        $this->parameters = & $parameters;
 
         $parameters['handler'] = explode('::', $parameters['_controller'], 2);
 

lib/org/openpsa/projects/handler/task/resourcing.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
             return new midcom_response_relocate($this->router->generate('task_view', ['guid' => $guid]));
         }
 
-        if (   $request->request->has('save')
+        if ($request->request->has('save')
             && $prospects = $request->request->all('org_openpsa_projects_prospects')) {
             $qb = org_openpsa_projects_task_resource_dba::new_query_builder();
             $qb->add_constraint('guid', 'IN', array_keys($prospects));
@@ -89,7 +89,7 @@ 
                     // create relatedto
                     org_openpsa_relatedto_plugin::create($event, 'org.openpsa.calendar', $this->_task, 'org.openpsa.projects');
                 }
-                if (   $update_prospect
+                if ($update_prospect
                     && !$prospect->update()) {
                     debug_add('Failed to update prospect: ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
                 }

lib/org/openpsa/invoices/scheduler.php

Spacing +2 added lines, -2 removed lines

@@ -95,7 +95,7 @@ 
         }
 
         // TODO: Warehouse management: create new order
-        if (   $this->_deliverable->end < $next_cycle_start
+        if ($this->_deliverable->end < $next_cycle_start
             && $this->_deliverable->end != 0) {
             debug_add('Do not register next cycle, the contract ends before');
             return $this->_deliverable->end_subscription();
@@ -328,7 +328,7 @@ 
         }
 
         //If previous cycle was run at the end of the month, the new one should be at the end of the month as well
-        if (   $date->format('t') == $date->format('j')
+        if ($date->format('t') == $date->format('j')
             && $new_date->format('t') != $new_date->format('j')) {
             $new_date->setDate((int) $new_date->format('Y'), (int) $new_date->format('m'), (int) $new_date->format('t'));
         }

lib/org/openpsa/documents/handler/document/admin.php

Spacing +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
 
         $this->_controller = $this->load_controller();
 
-        if (   $data['enable_versioning']
+        if ($data['enable_versioning']
             && $request->request->count() > 0) {
             $this->_backup_attachment($request);
         }

lib/org/openpsa/core/queryfilter.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
         $user = midcom::get()->auth->user->get_storage();
 
         if ($request->request->get('unset_filter') == $filter_id) {
-            if (   $user->get_parameter("org_openpsa_core_filter", $filter_id)
+            if ($user->get_parameter("org_openpsa_core_filter", $filter_id)
                 && !$user->delete_parameter("org_openpsa_core_filter", $filter_id)) {
                 $message_content = sprintf(
                     $l10n->get('the handed filter for %s could not be set as parameter'),

lib/org/openpsa/reports/handler/invoices/report.php

Spacing +5 added lines, -5 removed lines

@@ -56,7 +56,7 @@ 
 
     private function _get_invoices_for_subscription(org_openpsa_sales_salesproject_deliverable_dba $deliverable, midcom_services_at_entry_dba $at_entry) : array
     {
-        if (   $deliverable->invoiceByActualUnits
+        if ($deliverable->invoiceByActualUnits
             && $at_entry->arguments['cycle'] > 1) {
             $months = midcom_baseclasses_components_configuration::get('org.openpsa.sales', 'config')->get('subscription_profit_months');
             $cutoff = (new DateTime)->modify('-' . $months . ' months');
@@ -81,8 +81,8 @@ 
         $time = $at_entry->start;
         $scheduler = new org_openpsa_invoices_scheduler($deliverable);
 
-        while (   $time < $this->_request_data['end']
-               && (   $time < $deliverable->end
+        while ($time < $this->_request_data['end']
+               && ($time < $deliverable->end
                    || $deliverable->continuous)) {
             $invoices[] = $this->get_invoice_for_deliverable($deliverable, $invoice_sum, $time, $calculation_base);
 
@@ -124,8 +124,8 @@ 
         foreach ($qb->execute() as $at_entry) {
             try {
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($at_entry->arguments['deliverable']);
-                if (   $deliverable->continuous
-                    || (   $deliverable->start < $this->_request_data['end']
+                if ($deliverable->continuous
+                    || ($deliverable->start < $this->_request_data['end']
                         && $deliverable->end > $this->_request_data['start'])) {
                     $invoices = array_merge($invoices, $this->_get_invoices_for_subscription($deliverable, $at_entry));
                 }

lib/org/openpsa/directmarketing/campaign/ruleresolver.php

Spacing +2 added lines, -2 removed lines

@@ -270,7 +270,7 @@ 
      */
     private function add_misc_rule(array $rule, string $class, string $person_property)
     {
-        $persons = [ 0 => -1];
+        $persons = [0 => -1];
         $match = $rule['match'];
         $constraint_match = "IN";
         if ($rule['match'] == '<>') {
@@ -342,7 +342,7 @@ 
         $ret = [];
 
         foreach ($object->get_properties() as $property) {
-            if (   $property[0] == '_'
+            if ($property[0] == '_'
                 || in_array($property, $skip_properties)) {
                 // Skip private or otherwise invalid properties
                 continue;