flack / openpsa

src/midcom/dba/attachments.php

Spacing +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
             return false;
         }
 
-        if (   !$this->can_do('midgard:update')
+        if (!$this->can_do('midgard:update')
             || !$this->can_do('midgard:attachments')) {
             debug_add("Failed to set parameters, midgard:update or midgard:attachments on " . static::class . " {$this->guid} not granted for the current user.",
             MIDCOM_LOG_ERROR);
@@ -71,7 +71,7 @@ 
             return null;
         }
 
-        if (   !$this->can_do('midgard:update')
+        if (!$this->can_do('midgard:update')
             || !$this->can_do('midgard:attachments')) {
             debug_add("Failed to set parameters, midgard:update or midgard:attachments on the " . static::class . " {$this->guid} not granted for the current user.",
             MIDCOM_LOG_ERROR);
@@ -85,7 +85,7 @@ 
         $attachment->parentguid = $this->guid;
 
         if (!$attachment->create()) {
-            debug_add("Could not create the attachment '{$name}' for " . static::class . " {$this->guid}: "  . midcom_connection::get_error_string(),
+            debug_add("Could not create the attachment '{$name}' for " . static::class . " {$this->guid}: " . midcom_connection::get_error_string(),
             MIDCOM_LOG_INFO);
             return null;
         }

lib/midcom/services/i18n/l10n.php

Spacing +1 added lines, -1 removed lines

@@ -226,7 +226,7 @@
     private function error(string $message, string $filename, int $line) : midcom_error
     {
         $line++; // Array is 0-indexed
-        return new midcom_error('L10n DB SYNTAX ERROR: ' .  $message . ' at ' . $filename . ' ' . $line);
+        return new midcom_error('L10n DB SYNTAX ERROR: ' . $message . ' at ' . $filename . ' ' . $line);
     }
 
     /**

lib/midcom/services/rcs/main.php

Braces +2 added lines, -1 removed lines

@@ -56,7 +56,8 @@
         try {
             $backend->update(midcom::get()->auth->user->id ?? 'NOBODY', $message);
             return true;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             debug_add('RCS: Could not save file!');
             $e->log();
             return false;

lib/midcom/services/uimessages.php

Spacing +1 added lines, -1 removed lines

@@ -144,7 +144,7 @@
      */
     public function show(bool $show_simple = false)
     {
-        if (   $show_simple
+        if ($show_simple
             || !midcom::get()->auth->can_user_do('midcom:ajax', null, static::class)) {
             $this->show_simple();
             return;

lib/org/openpsa/reports/viewer.php

Braces +2 added lines, -1 removed lines

@@ -98,7 +98,8 @@
             $node_guid = $siteconfig->get_node_guid($component);
             try {
                 $available_generators[$component] = midcom_db_topic::get_cached($node_guid)->get_label();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add("topic for component '{$component}' not found or accessible");
             }
         }

lib/midcom/baseclasses/components/viewer.php

Spacing +1 added lines, -1 removed lines

@@ -246,7 +246,7 @@
      */
     public function prepare_handler(midcom_baseclasses_components_handler $handler, array &$parameters)
     {
-        $this->parameters =& $parameters;
+        $this->parameters = & $parameters;
 
         $parameters['handler'] = explode('::', $parameters['_controller'], 2);
 

lib/org/openpsa/projects/handler/task/resourcing.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
             return new midcom_response_relocate($this->router->generate('task_view', ['guid' => $guid]));
         }
 
-        if (   $request->request->has('save')
+        if ($request->request->has('save')
             && $prospects = $request->request->all('org_openpsa_projects_prospects')) {
             $qb = org_openpsa_projects_task_resource_dba::new_query_builder();
             $qb->add_constraint('guid', 'IN', array_keys($prospects));
@@ -89,7 +89,7 @@ 
                     // create relatedto
                     org_openpsa_relatedto_plugin::create($event, 'org.openpsa.calendar', $this->_task, 'org.openpsa.projects');
                 }
-                if (   $update_prospect
+                if ($update_prospect
                     && !$prospect->update()) {
                     debug_add('Failed to update prospect: ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
                 }

lib/org/openpsa/mail/backend.php

Braces +4 added lines, -2 removed lines

@@ -46,7 +46,8 @@ 
                     $object = self::_load_backend($backend, $params);
                     debug_add('Using backend ' . $backend);
                     return $object;
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     debug_add('Failed to load backend ' . $backend . ', message:' . $e->getMessage());
                 }
             }
@@ -76,7 +77,8 @@ 
             $this->mail($message);
             $this->error = null;
             return true;
-        } catch (Exception $e) {
+        }
+        catch (Exception $e) {
             $this->error = $e->getMessage();
             return false;
         }

src/midcom/grid/provider.php

Spacing +3 added lines, -3 removed lines

@@ -236,7 +236,7 @@ 
 
     private function _convert_to_localdata() : string
     {
-        return "var " . $this->_grid->get_identifier() . '_entries = ' .  json_encode($this->get_rows()) . ";\n";
+        return "var " . $this->_grid->get_identifier() . '_entries = ' . json_encode($this->get_rows()) . ";\n";
     }
 
     private function _render_json()
@@ -269,7 +269,7 @@ 
             $this->_sort_field = $query['sidx'];
             $this->_sort_direction = strtoupper($query['sord'] ?? 'ASC');
         }
-        if (   !empty($query['_search'])
+        if (!empty($query['_search'])
             && $query['_search'] === 'true') {
             foreach ($query as $field => $value) {
                 if (in_array($field, ['_search', 'nd', 'page', 'rows', 'sidx', 'sord'])) {
@@ -294,7 +294,7 @@ 
 
         $this->_total_rows = $query->count();
 
-        if (   $this->_datatype == 'json'
+        if ($this->_datatype == 'json'
             && !empty($this->_results_per_page)) {
             $query->set_limit($this->_results_per_page);
             if (!empty($this->_offset)) {