flack / openpsa

lib/org/openpsa/user/handler/person/view.php

Spacing +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
         $this->add_breadcrumb('', $person->get_label());
 
         $auth = midcom::get()->auth;
-        if (   $person->guid == midcom::get()->auth->user->guid
+        if ($person->guid == midcom::get()->auth->user->guid
             || $auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $buttons = [];
             $workflow = $this->get_workflow('datamanager');
@@ -38,7 +38,7 @@ 
                 $delete_workflow = $this->get_workflow('delete', ['object' => $person]);
                 $buttons[] = $delete_workflow->get_button($this->router->generate('user_delete', ['guid' => $person->guid]));
             }
-            if (   $data['account']->get_username()
+            if ($data['account']->get_username()
                 && $person->can_do('midgard:privileges')) {
                 $buttons[] = $workflow->get_button($this->router->generate('user_privileges', ['guid' => $person->guid]), [
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get("permissions"),

lib/org/openpsa/relatedto/finder.php

Spacing +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
             }
         }
 
-        if (   empty($link->toComponent)
+        if (empty($link->toComponent)
             && !empty($link->fromComponent)) {
             debug_add("Setting property 'toComponent' to '{$component}'");
             $link->toComponent = $component;
@@ -61,7 +61,7 @@ 
             $link->fromComponent = $component;
         }
 
-        if (   empty($link->toGuid)
+        if (empty($link->toGuid)
             && !empty($link->fromGuid)) {
             $link->toClass = get_class($obj);
             $link->toGuid = $obj->guid;

lib/org/openpsa/invoices/invoice.php

Braces +4 added lines, -2 removed lines

@@ -120,14 +120,16 @@
         if (!empty($this->customer)) {
             try {
                 return org_openpsa_contacts_group_dba::get_cached($this->customer);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }
         if (!empty($this->customerContact)) {
             try {
                 return org_openpsa_contacts_person_dba::get_cached($this->customerContact);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

Spacing +2 added lines, -2 removed lines

@@ -208,7 +208,7 @@ 
                 $invoice_item->pricePerUnit = $deliverable->pricePerUnit;
                 $invoice_item->deliverable = $deliverable->id;
                 //calculate price
-                if (   $deliverable->invoiceByActualUnits
+                if ($deliverable->invoiceByActualUnits
                     || $deliverable->plannedUnits == 0) {
                     $invoice_item->units = $hours;
                 } else {
@@ -249,7 +249,7 @@ 
      */
     public function get_billing_data() : org_openpsa_invoices_billing_data_dba
     {
-        return $this->_billing_data ??= org_openpsa_invoices_billing_data_dba::get_by_object($this);;
+        return $this->_billing_data ??= org_openpsa_invoices_billing_data_dba::get_by_object($this); ;
     }
 
     public function get_customer()

lib/org/openpsa/expenses/hour/report.php

Braces +2 added lines, -1 removed lines

@@ -98,7 +98,8 @@
             if ($this->old_task) {
                 self::update_cache(new org_openpsa_projects_task_dba($this->old_task));
             }
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
 

Spacing +1 added lines, -1 removed lines

@@ -113,7 +113,7 @@
     {
         if ($this->invoiceable) {
             $task = new org_openpsa_projects_task_dba($this->task);
-            $time_slot = (float)$task->get_parameter('org.openpsa.projects.projectbroker', 'minimum_slot');
+            $time_slot = (float) $task->get_parameter('org.openpsa.projects.projectbroker', 'minimum_slot');
             if (empty($time_slot)) {
                 $time_slot = (float) midcom_baseclasses_components_configuration::get('org.openpsa.expenses', 'config')->get('default_minimum_time_slot');
                 if (empty($time_slot)) {

lib/org/openpsa/expenses/midcom/interfaces.php

Braces +2 added lines, -1 removed lines

@@ -48,7 +48,8 @@
         foreach (array_unique($tasks_to_update) as $id) {
             try {
                 org_openpsa_expenses_hour_report_dba::update_cache(new org_openpsa_projects_task_dba($id));
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/org/openpsa/sales/calculator/default.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
     private function get_units($units = false) : float
     {
-        if (   $this->deliverable->invoiceByActualUnits
+        if ($this->deliverable->invoiceByActualUnits
             || $this->deliverable->plannedUnits == 0) {
             // In most cases we calculate the price based on the actual units entered
             return $units ?: $this->deliverable->units;

lib/org/openpsa/sales/midcom/interfaces.php

Braces +8 added lines, -4 removed lines

@@ -31,7 +31,8 @@ 
             try {
                 $agreement = new org_openpsa_sales_salesproject_deliverable_dba($agreement);
                 $agreement->update_units();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }
@@ -49,7 +50,8 @@ 
 
         try {
             $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($args['deliverable']);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $handler->print_error("Deliverable {$args['deliverable']} not found: " . midcom_connection::get_error_string());
             return false;
         }
@@ -69,7 +71,8 @@ 
         }
         try {
             $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($args['deliverable']);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $handler->print_error('no deliverable with passed GUID: ' . $args['deliverable'] . ', aborting');
             return false;
         }
@@ -77,7 +80,8 @@ 
         //get the owner of the salesproject the deliverable belongs to
         try {
             $project = new org_openpsa_sales_salesproject_dba($deliverable->salesproject);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $handler->print_error('Failed to load salesproject: ' . $e->getMessage());
             return false;
         }

lib/org/openpsa/sales/style/show-salesproject-grid.php

Braces +6 added lines, -3 removed lines

@@ -31,7 +31,8 @@ 
                 if ($data['contacts_url']) {
                     $row['customer'] = "<a href=\"{$data['contacts_url']}group/{$customer->guid}/\">{$label}</a>";
                 }
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }
@@ -44,7 +45,8 @@ 
             $contact_widget = org_openpsa_widgets_contact::get($salesproject->customerContact);
             $row['index_customerContact'] = $customer->get_label();
             $row['customerContact'] = $contact_widget->show_inline();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
     }
@@ -56,7 +58,8 @@ 
         $owner_widget = org_openpsa_widgets_contact::get($salesproject->owner);
         $row['index_owner'] = $owner->rname;
         $row['owner'] = $owner_widget->show_inline();
-    } catch (midcom_error $e) {
+    }
+    catch (midcom_error $e) {
         $row['index_owner'] = '';
         $row['owner'] = '';
     }

lib/org/openpsa/expenses/handler/index.php

Braces +4 added lines, -2 removed lines

@@ -102,7 +102,8 @@ 
         foreach ($hours as $guid => $row) {
             try {
                 $task = org_openpsa_projects_task_dba::get_cached($row['task']);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 // Task couldn't be loaded, probably because of ACL
                 continue;
             }
@@ -115,7 +116,8 @@ 
                     $person_object = midcom_db_person::get_cached($row['person']);
                     $person_label = $this->_get_list_link($person_object->name, null, null, $row['person']);
                     $person_name = $person_object->name;
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $person_label = $this->_l10n->get('no person');
                     $person_name = '';
                 }