flack / openpsa

lib/midcom/helper/imagepopup/handler/upload.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
         $temp = $request->files->get('file');
 
         // Verify file extension
-        if (   !$temp instanceof UploadedFile
+        if (!$temp instanceof UploadedFile
             || !in_array(strtolower($temp->getClientOriginalExtension()), ["gif", "jpg", "png"])) {
             throw new midcom_error('Invalid extension.');
         }

lib/org/openpsa/contacts/handler/group/action.php

Braces +2 added lines, -1 removed lines

@@ -33,7 +33,8 @@
                 $member->require_do('midgard:update');
                 $member->extra = $request->request->get('title');
                 $response['status'] = $member->update();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
             $response['message'] = midcom_connection::get_error_string();

src/midcom/datamanager/indexer/document.php

Spacing +1 added lines, -1 removed lines

@@ -171,7 +171,7 @@
                     if (!empty($field->vars['value'])) {
                         //only index the first attachment for now
                         $attachment = array_shift($field->vars['value']);
-                        if (   !$attachment instanceof \midcom_db_attachment
+                        if (!$attachment instanceof \midcom_db_attachment
                             && !empty($attachment['object'])) {
                             //This is the form edit case
                             //@todo: In create case, nothing is found currently

lib/org/openpsa/directmarketing/importer/csv.php

Spacing +2 added lines, -2 removed lines

@@ -55,11 +55,11 @@
         foreach (array_filter($csv_line) as $field => $value) {
             // Process the row accordingly
             $field_matching = $this->_settings['fields'][$field];
-            if (   $field_matching
+            if ($field_matching
                 && str_contains($field_matching, ':')) {
                 [$schemadb, $schema_field] = explode(':', $field_matching);
 
-                if (   !array_key_exists($schemadb, $this->_schemadbs)
+                if (!array_key_exists($schemadb, $this->_schemadbs)
                     || !$this->_schemadbs[$schemadb]->get('default')->has_field($schema_field)) {
                     // Invalid matching, skip
                     continue;

src/midcom/dba/parameters.php

Indentation +2 added lines, -2 removed lines

@@ -204,7 +204,7 @@ 
         if (   !$this->can_do('midgard:update')
             || !$this->can_do('midgard:parameters')) {
             debug_add("Failed to set parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
-                  MIDCOM_LOG_ERROR);
+                    MIDCOM_LOG_ERROR);
             midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
             return false;
         }
@@ -248,7 +248,7 @@ 
         if (   !$this->can_do('midgard:update')
             || !$this->can_do('midgard:parameters')) {
             debug_add("Failed to delete parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
-                  MIDCOM_LOG_ERROR);
+                    MIDCOM_LOG_ERROR);
             midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
             return false;
         }

Spacing +2 added lines, -2 removed lines

@@ -201,7 +201,7 @@ 
             return false;
         }
 
-        if (   !$this->can_do('midgard:update')
+        if (!$this->can_do('midgard:update')
             || !$this->can_do('midgard:parameters')) {
             debug_add("Failed to set parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
                   MIDCOM_LOG_ERROR);
@@ -245,7 +245,7 @@ 
             return false;
         }
 
-        if (   !$this->can_do('midgard:update')
+        if (!$this->can_do('midgard:update')
             || !$this->can_do('midgard:parameters')) {
             debug_add("Failed to delete parameters, midgard:update or midgard:parameters on " . static::class . " {$this->guid} not granted for the current user.",
                   MIDCOM_LOG_ERROR);

src/midcom/dba/attachments.php

Spacing +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
             return false;
         }
 
-        if (   !$this->can_do('midgard:update')
+        if (!$this->can_do('midgard:update')
             || !$this->can_do('midgard:attachments')) {
             debug_add("Failed to set parameters, midgard:update or midgard:attachments on " . static::class . " {$this->guid} not granted for the current user.",
             MIDCOM_LOG_ERROR);
@@ -71,7 +71,7 @@ 
             return null;
         }
 
-        if (   !$this->can_do('midgard:update')
+        if (!$this->can_do('midgard:update')
             || !$this->can_do('midgard:attachments')) {
             debug_add("Failed to set parameters, midgard:update or midgard:attachments on the " . static::class . " {$this->guid} not granted for the current user.",
             MIDCOM_LOG_ERROR);
@@ -85,7 +85,7 @@ 
         $attachment->parentguid = $this->guid;
 
         if (!$attachment->create()) {
-            debug_add("Could not create the attachment '{$name}' for " . static::class . " {$this->guid}: "  . midcom_connection::get_error_string(),
+            debug_add("Could not create the attachment '{$name}' for " . static::class . " {$this->guid}: " . midcom_connection::get_error_string(),
             MIDCOM_LOG_INFO);
             return null;
         }

lib/midcom/services/i18n/l10n.php

Spacing +1 added lines, -1 removed lines

@@ -226,7 +226,7 @@
     private function error(string $message, string $filename, int $line) : midcom_error
     {
         $line++; // Array is 0-indexed
-        return new midcom_error('L10n DB SYNTAX ERROR: ' .  $message . ' at ' . $filename . ' ' . $line);
+        return new midcom_error('L10n DB SYNTAX ERROR: ' . $message . ' at ' . $filename . ' ' . $line);
     }
 
     /**

src/midcom/httpkernel/subscriber.php

Spacing +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
         $i = array_search('__request_data__', $arguments, true);
         if ($i !== false) {
             $context = $event->getRequest()->attributes->get('context');
-            $arguments[$i] =& $context->get_custom_key('request_data');
+            $arguments[$i] = & $context->get_custom_key('request_data');
             $event->setArguments($arguments);
         }
     }

lib/midcom/baseclasses/components/viewer.php

Spacing +1 added lines, -1 removed lines

@@ -246,7 +246,7 @@
      */
     public function prepare_handler(midcom_baseclasses_components_handler $handler, array &$parameters)
     {
-        $this->parameters =& $parameters;
+        $this->parameters = & $parameters;
 
         $parameters['handler'] = explode('::', $parameters['_controller'], 2);