org_openpsa_qbpager_direct::_prepare_qbs() - Code Metrics - Inspection of "Clean up confusing count logic" - flack/openpsa - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8b441d...0083f3 )

by Andreas

created 2021-05-08 08:15 UTC

org_openpsa_qbpager_direct::_prepare_qbs() A

↳ Parent: org_openpsa_qbpager_direct

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	5
ccs	3
cts	3
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php
/**
 * @package org.openpsa.qbpager
 */
/**
 * Pages QB resultsets (uses midgard QB directly)
 *
 * @package org.openpsa.qbpager
 */
class org_openpsa_qbpager_direct extends org_openpsa_qbpager
{
    protected function _prepare_qbs(string $classname)
    {
        $this->_midcom_qb = new midgard_query_builder($classname);
        // Make another QB for counting, we need to do this to avoid trouble with core internal references system
        $this->_midcom_qb_count = new midgard_query_builder($classname);
    }

    /**
     * Wraps to execute since this is what midcom QB does, too
     */
    public function execute_unchecked() : array
    {
        return $this->execute();
    }

    /**
     * Wraps to count since this is what midcom QB does, too
     */
    public function count_unchecked() : int
    {
        if (!$this->count) {
            $this->count = $this->_midcom_qb_count->count();
        }
        return $this->count;
    }
}


1		<?php
2		/**
3		* @package org.openpsa.qbpager
4		*/
5		/**
6		* Pages QB resultsets (uses midgard QB directly)
7		*
8		* @package org.openpsa.qbpager
9		*/
10		class org_openpsa_qbpager_direct extends org_openpsa_qbpager
11		{
12	1	protected function _prepare_qbs(string $classname)
13		{
14	1	$this->_midcom_qb = new midgard_query_builder($classname);
15		// Make another QB for counting, we need to do this to avoid trouble with core internal references system
16	1	$this->_midcom_qb_count = new midgard_query_builder($classname);
17	1	}
18
19		/**
20		* Wraps to execute since this is what midcom QB does, too
21		*/
22	1	public function execute_unchecked() : array
23		{
24	1	return $this->execute();
25		}
26
27		/**
28		* Wraps to count since this is what midcom QB does, too
29		*/
30		public function count_unchecked() : int
31		{
32		if (!$this->count) {
33		$this->count = $this->_midcom_qb_count->count();
34		}
35		return $this->count;
36		}
37		}
38

flack / openpsa

Push — master ( 8b441d...0083f3 )

org_openpsa_qbpager_direct::_prepare_qbs() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like