Passed
Push — master ( 7f2659...451fb6 )
by Andreas
19:23
created
lib/midcom/services/auth/frontend/form.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
      */
41 41
     public function read_login_data(Request $request) : ?array
42 42
     {
43
-        if (   !$request->request->has('midcom_services_auth_frontend_form_submit')
43
+        if (!$request->request->has('midcom_services_auth_frontend_form_submit')
44 44
             || !$request->request->has('username')
45 45
             || !$request->request->has('password')) {
46 46
             return null;
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     {
77 77
         // Store the submitted form if the session expired, but user wants to save the data
78 78
         if (!empty($_POST)) {
79
-            $data =& midcom_core_context::get()->get_custom_key('request_data');
79
+            $data = & midcom_core_context::get()->get_custom_key('request_data');
80 80
 
81 81
             $data['restored_form_data'] = [];
82 82
 
Please login to merge, or discard this patch.
lib/net/nemein/wiki/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 
45 45
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
46 46
     {
47
-        if (   $object instanceof midcom_db_article
47
+        if ($object instanceof midcom_db_article
48 48
             && $topic->id == $object->topic) {
49 49
             if ($object->name == 'index') {
50 50
                 return '';
Please login to merge, or discard this patch.
lib/org/openpsa/documents/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 
41 41
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
42 42
     {
43
-        if (   $object instanceof org_openpsa_documents_document_dba
43
+        if ($object instanceof org_openpsa_documents_document_dba
44 44
             && $object->topic == $topic->id) {
45 45
             return "document/{$object->guid}/";
46 46
         }
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/midcom/interfaces.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -77,11 +77,11 @@  discard block
 block discarded – undo
77 77
 
78 78
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
79 79
     {
80
-        if (   $object instanceof org_openpsa_contacts_group_dba
80
+        if ($object instanceof org_openpsa_contacts_group_dba
81 81
             || $object instanceof midcom_db_group) {
82 82
             return "group/{$object->guid}/";
83 83
         }
84
-        if (   $object instanceof org_openpsa_contacts_person_dba
84
+        if ($object instanceof org_openpsa_contacts_person_dba
85 85
             || $object instanceof midcom_db_person) {
86 86
             return "person/{$object->guid}/";
87 87
         }
@@ -110,8 +110,8 @@  discard block
 block discarded – undo
110 110
             // We have a feed URL, but we should check if it is GeoRSS as well
111 111
             $items = net_nemein_rss_fetch::raw_fetch($data['rss_url'])->get_items();
112 112
 
113
-            if (   !empty($items)
114
-                && (   $items[0]->get_latitude()
113
+            if (!empty($items)
114
+                && ($items[0]->get_latitude()
115 115
                     || $items[0]->get_longitude())) {
116 116
                 // This is a GeoRSS feed
117 117
                 $data['georss_url'] = $data['rss_url'];
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/style/midgard_admin_asgard_rcs_history.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
                 echo "                    <td>" . strftime('%x %X Z', $revision['date']) . "</td>\n";
37 37
                 echo "                    <td>";
38 38
 
39
-                if (   $revision['user']
39
+                if ($revision['user']
40 40
                     && $user = midcom::get()->auth->get_user($revision['user'])) {
41 41
                     echo $user->get_storage()->name;
42 42
                 } elseif ($revision['ip']) {
Please login to merge, or discard this patch.
lib/net/nemein/wiki/style/view-wikipage-raw.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,6 +6,6 @@
 block discarded – undo
6 6
     &(view["content"]:h);
7 7
     <?php
8 8
 } else {
9
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
9
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
10 10
 }
11 11
 ?>
12 12
\ No newline at end of file
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/style/admin-read.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
         <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div>
35 35
     <?php } ?>
36 36
 
37
-    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div>
37
+    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div>
38 38
     <div class="description value">&(view['description']:h);</div></div>
39 39
 
40 40
     <?php
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/style/show_entries_html.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
             <?php
47 47
             //index is needed for sorting
48 48
             echo "'index_name',";
49
-            echo "'" . $data['l10n']->get('entry title') ."',";
49
+            echo "'" . $data['l10n']->get('entry title') . "',";
50 50
             echo "'" . $data['l10n']->get('entry text') . "',";
51 51
             echo "'" . $data['l10n']->get('entry created') . "',";
52 52
             echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',";
Please login to merge, or discard this patch.
src/midcom/datamanager/helper/autocomplete.php 1 patch
Spacing   +4 added lines, -6 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
     {
86 86
         ksort($constraints);
87 87
         foreach ($constraints as $key => $data) {
88
-            if (   !array_key_exists('value', $data)
88
+            if (!array_key_exists('value', $data)
89 89
                 || empty($data['field'])
90 90
                 || empty($data['op'])) {
91 91
                 debug_add("Constraint #{$key} is not correctly defined, skipping", MIDCOM_LOG_WARN);
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
     {
147 147
         $query = $this->request["term"];
148 148
         $wildcard_query = $query;
149
-        if (   isset($this->request['auto_wildcards'])
149
+        if (isset($this->request['auto_wildcards'])
150 150
             && !str_contains($query, '%')) {
151 151
             switch ($this->request['auto_wildcards']) {
152 152
                 case 'start':
@@ -253,9 +253,7 @@  discard block
 block discarded – undo
253 253
                 return $label;
254 254
             }
255 255
         }
256
-        return midcom_helper_reflector::get($object)->get_object_label($object) ?:
257
-            self::build_label($object, array_column($result_headers, 'name')) ?:
258
-            get_class($object) . ' #' . $object->id;
256
+        return midcom_helper_reflector::get($object)->get_object_label($object) ?: self::build_label($object, array_column($result_headers, 'name')) ?: get_class($object) . ' #' . $object->id;
259 257
     }
260 258
 
261 259
     private static function build_label($object, array $fields) : string
@@ -289,7 +287,7 @@  discard block
 block discarded – undo
289 287
             }
290 288
             return self::sanitize_label($value);
291 289
         }
292
-        if (   $field == 'username'
290
+        if ($field == 'username'
293 291
             && $object instanceof midcom_db_person) {
294 292
             $account = new midcom_core_account($object);
295 293
             return self::sanitize_label($account->get_username());
Please login to merge, or discard this patch.