Passed
Push — master ( a11f30...6bea5b )
by Andreas
37:19 queued 11:48
created
lib/midgard/admin/asgard/handler/component/configuration.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
     {
278 278
         $success = true;
279 279
         foreach ($this->_request_data['config']->_global as $global_key => $global_value) {
280
-            if (   isset($config[$global_key])
280
+            if (isset($config[$global_key])
281 281
                 && $config[$global_key] != $global_value) {
282 282
                 continue;
283 283
                 // Skip the ones we will set next
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
         }
291 291
 
292 292
         foreach ($config as $key => $value) {
293
-            if (   is_array($value)
293
+            if (is_array($value)
294 294
                 || is_object($value)) {
295 295
                 /**
296 296
                  * See http://trac.midgard-project.org/ticket/1442
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/schemadb/config.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,11 +61,11 @@
 block discarded – undo
61 61
                 $fields[$key] = $this->detect_schema($key, $value);
62 62
             }
63 63
 
64
-            if (   !isset($this->config->_local[$key])
64
+            if (!isset($this->config->_local[$key])
65 65
                 || $this->config->_local[$key] == $this->config->_global[$key]) {
66 66
                 // No local configuration setting, note to user that this is the global value
67 67
                 $fields[$key]['title'] = $schema->get_l10n()->get($fields[$key]['title']);
68
-                $fields[$key]['title'] .= " <span class=\"global\">(" . midcom::get()->i18n->get_string('global value', 'midgard.admin.asgard') .")</span>";
68
+                $fields[$key]['title'] .= " <span class=\"global\">(" . midcom::get()->i18n->get_string('global value', 'midgard.admin.asgard') . ")</span>";
69 69
             }
70 70
         }
71 71
 
Please login to merge, or discard this patch.
lib/midcom/admin/help/help.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -179,9 +179,9 @@  discard block
 block discarded – undo
179 179
         $files = [];
180 180
         $pattern = $component_dir . '*.{' . $this->_i18n->get_current_language() . ',' . $this->_i18n->get_fallback_language() . '}.txt';
181 181
 
182
-        foreach (glob($pattern, GLOB_NOSORT|GLOB_BRACE) as $path) {
182
+        foreach (glob($pattern, GLOB_NOSORT | GLOB_BRACE) as $path) {
183 183
             $entry = basename($path);
184
-            if (   str_starts_with($entry, 'index')
184
+            if (str_starts_with($entry, 'index')
185 185
                 || str_starts_with($entry, 'handler')
186 186
                 || str_starts_with($entry, 'urlmethod')) {
187 187
                 // Ignore dotfiles, handlers & index.lang.txt
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
         $data = [];
233 233
 
234 234
         $exec_path = midcom::get()->componentloader->path_to_snippetpath($component) . '/exec/';
235
-        if (   !is_dir($exec_path)
235
+        if (!is_dir($exec_path)
236 236
             || !is_readable($exec_path)) {
237 237
             // Directory not accessible, skip loading it
238 238
             return $data;
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/event.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
         }
142 142
 
143 143
         //Check up
144
-        if (   !$this->up
144
+        if (!$this->up
145 145
             && $this->title != '__org_openpsa_calendar') {
146 146
             $root_event = org_openpsa_calendar_interface::find_root_event();
147 147
             $this->up = $root_event->id;
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 
167 167
     private function _check_timerange() : bool
168 168
     {
169
-        if (   !$this->start
169
+        if (!$this->start
170 170
             || !$this->end) {
171 171
             debug_add('Event must have start and end timestamps');
172 172
             midcom_connection::set_error(MGD_ERR_RANGE);
Please login to merge, or discard this patch.
lib/midcom/helper/_dbfactory.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             throw new midcom_error_midgard($e, $guid);
50 50
         }
51 51
         $person_class = midcom::get()->config->get('person_class');
52
-        if (   get_class($tmp) == 'midgard_person'
52
+        if (get_class($tmp) == 'midgard_person'
53 53
             && $person_class != 'midgard_person') {
54 54
             $tmp = new $person_class($guid);
55 55
         }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
         }
80 80
         $object = new $classname($src);
81 81
         $cache[$classname][$object->guid] = $object;
82
-        $cache[$classname][$object->id] =& $cache[$classname][$object->guid];
82
+        $cache[$classname][$object->id] = & $cache[$classname][$object->guid];
83 83
         return $cache[$classname][$object->guid];
84 84
     }
85 85
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
             return true;
128 128
         }
129 129
 
130
-        if (   isset($object->__object)
130
+        if (isset($object->__object)
131 131
             && is_object($object->__object)
132 132
             && $object->__object instanceof $class) {
133 133
             // Decorator whose MgdSchema object matches
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
             return $this->get_parent_data_uncached($object);
151 151
         });
152 152
 
153
-        if (   empty($parent_guid)
153
+        if (empty($parent_guid)
154 154
             || $parent_guid === $object->guid) {
155 155
             return null;
156 156
         }
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
         midcom::get()->head->set_pagetitle($this->_request_data['page_title']);
92 92
 
93 93
         // Activate correct leaf
94
-        if (   $this->_config->get('show_navigation_pseudo_leaves')
94
+        if ($this->_config->get('show_navigation_pseudo_leaves')
95 95
             && in_array($this->category, $this->_request_data['categories'])) {
96 96
             $this->set_active_leaf($this->_topic->id . '_CAT_' . $this->category);
97 97
         }
Please login to merge, or discard this patch.
lib/midcom/admin/folder/handler/move.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
     {
36 36
         $this->_object = midcom::get()->dbfactory->get_object_by_guid($guid);
37 37
 
38
-        if (   !is_a($this->_object, midcom_db_topic::class)
38
+        if (!is_a($this->_object, midcom_db_topic::class)
39 39
             && !is_a($this->_object, midcom_db_article::class)) {
40 40
             throw new midcom_error_notfound("Moving only topics and articles is supported.");
41 41
         }
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
             $folder = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ROOTTOPIC);
77 77
         }
78 78
 
79
-        if (   is_a($this->_object, midcom_db_topic::class)
79
+        if (is_a($this->_object, midcom_db_topic::class)
80 80
             && $folder->up == $this->_object->id) {
81 81
             $tree_disabled = true;
82 82
         }
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
             $selected = ' checked="checked"';
90 90
         }
91 91
 
92
-        if (   !is_a($this->_object, midcom_db_topic::class)
92
+        if (!is_a($this->_object, midcom_db_topic::class)
93 93
             && $folder->component !== $this->current_folder->component) {
94 94
             // Non-topic objects may only be moved under folders of same component
95 95
             $class = 'wrong_component';
Please login to merge, or discard this patch.
lib/net/nemein/wiki/handler/view.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -202,9 +202,9 @@
 block discarded – undo
202 202
         $toc .= "\n<ol class=\"midcom_helper_toc_formatter level_{$current_list_level}\">\n";
203 203
         foreach ($headings[4] as $key => $heading) {
204 204
             $anchor = 'heading-' . md5($heading);
205
-            $tag_level =& $headings[3][$key];
206
-            $heading_code =& $headings[0][$key];
207
-            $heading_tag =& $headings[2][$key];
205
+            $tag_level = & $headings[3][$key];
206
+            $heading_code = & $headings[0][$key];
207
+            $heading_tag = & $headings[2][$key];
208 208
             $heading_new_code = "<a id='{$anchor}'></a>{$heading_code}";
209 209
             $content = str_replace($heading_code, $heading_new_code, $content);
210 210
             if ($current_tag_level === false) {
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/handler/duplicates/person.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 
42 42
     private function load_next()
43 43
     {
44
-        $i =& $this->_request_data['loop_i'];
44
+        $i = & $this->_request_data['loop_i'];
45 45
         while ($i < 100) {
46 46
             debug_add("Loop iteration {$i}");
47 47
             $qb = new midgard_query_builder('midgard_parameter');
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
                 continue;
70 70
             }
71 71
             // Make sure we actually have enough rights to do this
72
-            if (   !$person1->can_do('midgard:update')
72
+            if (!$person1->can_do('midgard:update')
73 73
                 || !$person1->can_do('midgard:delete')
74 74
                 || !$person2->can_do('midgard:update')
75 75
                 || !$person2->can_do('midgard:delete')) {
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
                 continue;
79 79
             }
80 80
             // Extra sanity check (in case of semi-successful not-duplicate mark)
81
-            if (   $person1->get_parameter('org.openpsa.contacts.duplicates:not_duplicate', $person2->guid)
81
+            if ($person1->get_parameter('org.openpsa.contacts.duplicates:not_duplicate', $person2->guid)
82 82
                 || $person2->get_parameter('org.openpsa.contacts.duplicates:not_duplicate', $person1->guid)) {
83 83
                 debug_add("It seems these two (#{$person1->id} and #{$person2->id}) have also marked as not duplicates, some cleanup might be a good thing", MIDCOM_LOG_WARN);
84 84
                 $i++;
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
             if ($keep == 'both') {
103 103
                 $option1->require_do('midgard:update');
104 104
                 $option2->require_do('midgard:update');
105
-                if (   $option1->set_parameter('org.openpsa.contacts.duplicates:not_duplicate', $option2->guid, time())
105
+                if ($option1->set_parameter('org.openpsa.contacts.duplicates:not_duplicate', $option2->guid, time())
106 106
                     && $option2->set_parameter('org.openpsa.contacts.duplicates:not_duplicate', $option1->guid, time())) {
107 107
                     // Clear the possible duplicate parameters
108 108
                     $option1->delete_parameter('org.openpsa.contacts.duplicates:possible_duplicate', $option2->guid);
@@ -120,11 +120,11 @@  discard block
 block discarded – undo
120 120
                 }
121 121
             } else {
122 122
                 if ($keep == $option1->guid) {
123
-                    $person1 =& $option1;
124
-                    $person2 =& $option2;
123
+                    $person1 = & $option1;
124
+                    $person2 = & $option2;
125 125
                 } elseif ($keep == $option2->guid) {
126
-                    $person1 =& $option2;
127
-                    $person2 =& $option1;
126
+                    $person1 = & $option2;
127
+                    $person2 = & $option1;
128 128
                 } else {
129 129
                     throw new midcom_error('Something weird happened (basically we got bogus data)');
130 130
                 }
Please login to merge, or discard this patch.