Passed
Push — master ( a11f30...6bea5b )
by Andreas
37:19 queued 11:48
created
lib/midcom/db/attachment.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -318,7 +318,7 @@
 block discarded – undo
318 318
     public function update_cache()
319 319
     {
320 320
         // Check if the attachment can be read anonymously
321
-        if (   midcom::get()->config->get('attachment_cache_enabled')
321
+        if (midcom::get()->config->get('attachment_cache_enabled')
322 322
             && !$this->can_do('midgard:read', 'EVERYONE')) {
323 323
             // Not public file, ensure it is removed
324 324
             $this->remove_from_cache();
Please login to merge, or discard this patch.
lib/midcom/baseclasses/components/viewer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@
 block discarded – undo
246 246
      */
247 247
     public function prepare_handler(array &$parameters)
248 248
     {
249
-        $this->parameters =& $parameters;
249
+        $this->parameters = & $parameters;
250 250
 
251 251
         $parameters['handler'] = explode('::', $parameters['_controller'], 2);
252 252
 
Please login to merge, or discard this patch.
lib/midcom/exec/reindex.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 $reindex_topic_uri = midcom::get()->get_page_prefix() . 'midcom-exec-midcom/reindex_singlenode.php';
48 48
 
49 49
 $options = ['timeout' => 300];
50
-if (   !empty($_SERVER['PHP_AUTH_USER'])
50
+if (!empty($_SERVER['PHP_AUTH_USER'])
51 51
     && !empty($_SERVER['PHP_AUTH_PW'])) {
52 52
     $options['auth'] = ['user' => $_SERVER['PHP_AUTH_USER'], 'password' => $_SERVER['PHP_AUTH_PW']];
53 53
 }
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
             } else {
66 66
                 echo "OK.\n";
67 67
             }
68
-        }, function (RequestException $e) use ($uri) {
68
+        }, function(RequestException $e) use ($uri) {
69 69
             echo "failure.\n   Background processing failed, error: {$e->getMessage()}\n";
70 70
             echo "Url: " . $uri . "\n";
71 71
         })->wait();
Please login to merge, or discard this patch.
src/midcom/grid/grid.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
         if (file_exists(MIDCOM_STATIC_ROOT . $jqgrid_path . 'i18n/grid.locale-' . $language . '.js')) {
110 110
             $lang = $language;
111 111
         }
112
-        $head->add_jsfile(MIDCOM_STATIC_URL . $jqgrid_path . 'i18n/grid.locale-'. $lang . '.js');
112
+        $head->add_jsfile(MIDCOM_STATIC_URL . $jqgrid_path . 'i18n/grid.locale-' . $lang . '.js');
113 113
         $head->add_jsfile(MIDCOM_STATIC_URL . $jqgrid_path . 'jquery.jqgrid.min.js');
114 114
 
115 115
         $head->add_jsfile(MIDCOM_STATIC_URL . '/midcom.grid/jqGrid.custom.js');
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
     public function set_option(string $key, $value, bool $autoquote_string = true) : self
156 156
     {
157 157
         $this->_raw_options[$key] = $value;
158
-        if (   $autoquote_string
158
+        if ($autoquote_string
159 159
             && is_string($value)) {
160 160
             $value = '"' . str_replace('"', '\\"', $value) . '"';
161 161
         } elseif ($value === true) {
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
     public function set_select_column(string $name, string $label, string $options, array $selectdata) : self
186 186
     {
187 187
         $selectstring = implode(';', array_map(
188
-            function ($key, $value) {
188
+            function($key, $value) {
189 189
                 return $key . ':' . $value;
190 190
             },
191 191
             array_keys($selectdata),
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
      */
232 232
     public function remove_column(string $name)
233 233
     {
234
-        if (   empty($name)
234
+        if (empty($name)
235 235
             || !array_key_exists($name, $this->_columns)) {
236 236
             throw new midcom_error('Invalid column name ' . $name);
237 237
         }
Please login to merge, or discard this patch.
src/midcom/workflow/datamanager.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -122,8 +122,8 @@
 block discarded – undo
122 122
             return 'undefined';
123 123
         }
124 124
 
125
-        if (   !str_starts_with($url, '/')
126
-            && ! preg_match('|^https?://|', $url)) {
125
+        if (!str_starts_with($url, '/')
126
+            && !preg_match('|^https?://|', $url)) {
127 127
             $url = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX) . $url;
128 128
         }
129 129
         return '"' . $url . '"';
Please login to merge, or discard this patch.
lib/org/openpsa/documents/elFinderVolumeOpenpsa.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_MIME, '(' . $mime . ')');
68 68
         }
69 69
 
70
-        $tmpsize = (int)sprintf('%u', filesize($tmpname));
70
+        $tmpsize = (int) sprintf('%u', filesize($tmpname));
71 71
         if ($this->uploadMaxSize > 0 && $tmpsize > $this->uploadMaxSize) {
72 72
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_SIZE);
73 73
         }
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
         $output = [$object->get_label()];
251 251
 
252 252
         $parent = $object->get_parent();
253
-        while (   $parent
253
+        while ($parent
254 254
                && $parent->component == 'org.openpsa.documents') {
255 255
             $output[] = $parent->extra;
256 256
             $parent = $parent->get_parent();
@@ -347,12 +347,12 @@  discard block
 block discarded – undo
347 347
             $data['mime'] = 'directory';
348 348
         }
349 349
 
350
-        if (   $owner
350
+        if ($owner
351 351
             && $group = midcom::get()->auth->get_assignee($owner)) {
352 352
             $data['group'] = $group->name;
353 353
         }
354 354
 
355
-        if (   $this->root !== $path
355
+        if ($this->root !== $path
356 356
             && $parent = $object->get_parent()) {
357 357
             $data['phash'] = $this->encode($parent->guid);
358 358
         }
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
      * @param  string $mode open mode
412 412
      * @return resource|false
413 413
      */
414
-    protected function _fopen($path, $mode="rb")
414
+    protected function _fopen($path, $mode = "rb")
415 415
     {
416 416
         $document = org_openpsa_documents_document_dba::get_cached($path);
417 417
         $attachments = blobs::get_attachments($document, 'document');
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
      * @param  string    $path  file path
430 430
      * @return bool
431 431
      */
432
-    protected function _fclose($fp, $path='')
432
+    protected function _fclose($fp, $path = '')
433 433
     {
434 434
         fclose($fp);
435 435
         return true;
@@ -611,7 +611,7 @@  discard block
 block discarded – undo
611 611
     {
612 612
         $filename = midcom_db_attachment::safe_filename($name, true);
613 613
         $att = $doc->create_attachment($filename, $name, $mimetype);
614
-        if (   !$att
614
+        if (!$att
615 615
             || !$att->copy_from_handle($fp)) {
616 616
             return false;
617 617
         }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/schemaType.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -34,11 +34,11 @@  discard block
 block discarded – undo
34 34
         $resolver
35 35
             ->setRequired('schema')
36 36
             ->setAllowedTypes('schema', schema::class)
37
-            ->setDefault('action', function (Options $options, $value) {
37
+            ->setDefault('action', function(Options $options, $value) {
38 38
                 return $options['schema']->get('action');
39 39
             });
40 40
 
41
-        $resolver->setNormalizer('csrf_protection', function (Options $options, $value) {
41
+        $resolver->setNormalizer('csrf_protection', function(Options $options, $value) {
42 42
             foreach ($options['schema']->get('fields') as $config) {
43 43
                 if ($config['widget'] === 'csrf') {
44 44
                     return true;
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
             }
47 47
             return false;
48 48
         });
49
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
49
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
50 50
             $validation = $options['schema']->get('validation');
51 51
             if (!empty($validation)) {
52 52
                 $cb_wrapper = new cb_wrapper($validation);
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         // this is mainly there to skip validation in case the user pressed cancel
73 73
         $builder->addEventListener(FormEvents::POST_SUBMIT, function(PostSubmitEvent $event) {
74 74
             $form = $event->getForm();
75
-            if (   $form instanceof Form
75
+            if ($form instanceof Form
76 76
                 && $form->getClickedButton()
77 77
                 && $form->getClickedButton()->getConfig()->getOption('operation') == controller::CANCEL) {
78 78
                 $event->stopPropagation();
Please login to merge, or discard this patch.
lib/fi/protie/navigation/main.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -281,8 +281,8 @@  discard block
 block discarded – undo
281 281
         $classes = [];
282 282
 
283 283
         if ($item[MIDCOM_NAV_TYPE] === 'node') {
284
-            if (   $item[MIDCOM_NAV_ID] === $this->_nap->get_current_node()
285
-                && (   !$this->_nap->get_current_leaf()
284
+            if ($item[MIDCOM_NAV_ID] === $this->_nap->get_current_node()
285
+                && (!$this->_nap->get_current_leaf()
286 286
                     || !$this->_nap->get_leaf($this->_nap->get_current_leaf()))) {
287 287
                 $classes[] = $this->css_active;
288 288
             }
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
         }
317 317
 
318 318
         // Add information about the object's status
319
-        if (   $this->object_status_to_class
319
+        if ($this->object_status_to_class
320 320
             && isset($item[MIDCOM_NAV_OBJECT])
321 321
             && $css_status_class = midcom::get()->metadata->get_object_classes($item[MIDCOM_NAV_OBJECT])) {
322 322
             $classes[] = $css_status_class;
@@ -336,12 +336,12 @@  discard block
 block discarded – undo
336 336
         echo "<a href=\"{$item[MIDCOM_NAV_ABSOLUTEURL]}\"{$link_class}>" . htmlspecialchars($item[MIDCOM_NAV_NAME]) . "</a>";
337 337
         // If either of the follow nodes switches is on, follow all the nodes
338 338
 
339
-        if (   $item[MIDCOM_NAV_TYPE] === 'node'
339
+        if ($item[MIDCOM_NAV_TYPE] === 'node'
340 340
             && !$this->show_only_current
341
-            && (   $this->list_levels === 0
341
+            && ($this->list_levels === 0
342 342
                 || $this->_level < $this->list_levels)) {
343
-            if (   $this->follow_all
344
-                || (   $this->follow_selected
343
+            if ($this->follow_all
344
+                || ($this->follow_selected
345 345
                     && in_array($item[MIDCOM_NAV_ID], $this->node_path, true))) {
346 346
                 $this->_level++;
347 347
                 $this->_list_child_elements($item[MIDCOM_NAV_ID]);
Please login to merge, or discard this patch.
lib/org/openpsa/helpers/fileinfo.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
          * if nothing matched so far and the subtype is alphanumeric, uppercase it on the theory
65 65
          * that it's probably a file extension
66 66
          */
67
-        if (   $st_orig == $subtype
67
+        if ($st_orig == $subtype
68 68
             && preg_match('/^[a-z0-9]+$/', $subtype)) {
69 69
             $subtype = strtoupper($subtype);
70 70
         }
Please login to merge, or discard this patch.