Passed
Push — master ( a11f30...6bea5b )
by Andreas
37:19 queued 11:48
created
lib/org/openpsa/user/handler/person/account.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
59 59
         $response = $workflow->run($request);
60 60
 
61
-        if (   $workflow->get_state() == 'save'
61
+        if ($workflow->get_state() == 'save'
62 62
             && $this->create_account($this->person, $data["controller"]->get_form_values())) {
63 63
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), sprintf($this->_l10n->get('person %s created'), $this->person->name));
64 64
         }
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         $accounthelper = new org_openpsa_user_accounthelper($this->person);
149 149
 
150 150
         // Update account
151
-        if (   !$accounthelper->set_account($controller->get_form_values()["username"], $password)
151
+        if (!$accounthelper->set_account($controller->get_form_values()["username"], $password)
152 152
             && midcom_connection::get_error() != MGD_ERR_OK) {
153 153
             // Failure, give a message
154 154
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get("failed to update the user account, reason") . ': ' . midcom_connection::get_error_string(), 'error');
Please login to merge, or discard this patch.
src/midcom/datamanager/controller.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -70,13 +70,13 @@  discard block
 block discarded – undo
70 70
             }
71 71
         } elseif (!$this->form->isSubmitted()) {
72 72
             $this->form->handleRequest($request);
73
-            if (   $this->form->isSubmitted()
73
+            if ($this->form->isSubmitted()
74 74
                 && $button = $this->form->getClickedButton()) {
75 75
                 $operation = $button->getConfig()->getOption('operation');
76 76
             }
77 77
         }
78 78
 
79
-        if (   in_array($operation, [self::SAVE, self::NEXT])
79
+        if (in_array($operation, [self::SAVE, self::NEXT])
80 80
             && !$this->form->isValid()) {
81 81
             $operation = self::EDIT;
82 82
         }
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
                 if ($storage->get_last_operation() === self::SAVE) {
160 160
                     // Get GUIDs and such for new-created dependent objects
161 161
                     $this->dm->set_storage($storage->get_value(), $this->dm->get_schema()->get_name());
162
-                } elseif (   !$this->form->isValid()
162
+                } elseif (!$this->form->isValid()
163 163
                           && $storage->move_uploaded_files() > 0) {
164 164
                     $form = $this->dm->get_form($this->form->getName(), true);
165 165
                     $this->copy_errors($this->form, $form);
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/importer.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
                 }
122 122
             }
123 123
 
124
-            if (   !$person
124
+            if (!$person
125 125
                 && !empty($subscriber['person']['handphone'])) {
126 126
                 // Perform a simple cell phone test. More complicated duplicate checking is best left to the o.o.contacts duplicate checker
127 127
                 $qb = org_openpsa_contacts_person_dba::new_query_builder();
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
             // User is or has been subscriber earlier, update status
168 168
             $member = $members[0];
169 169
 
170
-            if (   $member->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED
170
+            if ($member->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED
171 171
                 || $member->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_member_dba::NORMAL) {
172 172
                 $this->_import_status['already_subscribed']++;
173 173
                 return;
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 
208 208
             $qb = org_openpsa_contacts_group_dba::new_query_builder();
209 209
             $schema = $this->_schemadbs['organization']->get('default');
210
-            if (   $schema->has_field('company_id')
210
+            if ($schema->has_field('company_id')
211 211
                 && !empty($subscriber['organization']['company_id'])) {
212 212
                 // Imported data has a company id, we use that instead of name
213 213
                 $qb->add_constraint($schema->get_field('company_id')['storage']['location'], '=', $subscriber['organization']['company_id']);
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
                 // Seek by official name
216 216
                 $qb->add_constraint('official', '=', $subscriber['organization']['official']);
217 217
 
218
-                if (   $schema->has_field('city')
218
+                if ($schema->has_field('city')
219 219
                     && !empty($subscriber['organization']['city'])) {
220 220
                     // Imported data has a city, we use also that for matching
221 221
                     $qb->add_constraint($schema->get_field('city')['storage']['location'], '=', $subscriber['organization']['city']);
Please login to merge, or discard this patch.
lib/net/nehmer/blog/style/feeds-item.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 $item->title = $data['article']->title;
19 19
 $arg = $data['article']->name ?: $data['article']->guid;
20 20
 
21
-if (   $data['config']->get('link_to_external_url')
21
+if ($data['config']->get('link_to_external_url')
22 22
     && !empty($data['article']->url)) {
23 23
     $item->link = $data['article']->url;
24 24
 } else {
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
     $item->description .= '<div class="abstract">' . $view['abstract'] . '</div>';
38 38
 }
39 39
 
40
-if (   array_key_exists('image', $view)
40
+if (array_key_exists('image', $view)
41 41
     && $data['config']->get('rss_use_image')) {
42 42
     $item->description .= "\n<div class=\"image\">" . $view['image'] . '</div>';
43 43
 }
Please login to merge, or discard this patch.
lib/org/openpsa/projects/style/show-frontpage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('ongoing') . "\">{$task_count['ongoing']}</span></td>\n";
69 69
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('on_hold') . "\">{$task_count['on_hold']}</span></td>\n";
70 70
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('closed') . "\">{$task_count['closed']}</span></td>\n";
71
-            echo "        <td class=\"numeric\"> " ;
71
+            echo "        <td class=\"numeric\"> ";
72 72
             echo "            <span title=\"" . $data['l10n']->get('reported') . "\">" . round($hours['reportedHours'], 2) . "</span>";
73 73
             if ($hours['plannedHours'] > 0) {
74 74
                 echo          " / <span title=\"" . $data['l10n']->get('planned hours') . "\">" . round($hours['plannedHours'], 2) . "</span>";
Please login to merge, or discard this patch.
lib/org/openpsa/documents/handler/document/admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
 
102 102
         $this->_controller = $this->load_controller();
103 103
 
104
-        if (   $data['enable_versioning']
104
+        if ($data['enable_versioning']
105 105
             && $request->request->count() > 0) {
106 106
             $this->_backup_attachment();
107 107
         }
Please login to merge, or discard this patch.
lib/org/openpsa/projects/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
      */
54 54
     private function _find_suspects_event(midcom_core_dbaobject $object, org_openpsa_relatedto_dba $defaults, array &$links_array)
55 55
     {
56
-        if (   !is_array($object->participants)
56
+        if (!is_array($object->participants)
57 57
             || count($object->participants) < 1) {
58 58
             //We have invalid list or zero participants, abort
59 59
             return;
Please login to merge, or discard this patch.
lib/midcom/admin/folder/management.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
             }
51 51
 
52 52
             // Skip components beginning with midcom or midgard
53
-            if (   preg_match('/^(midcom|midgard)\./', $manifest->name)
53
+            if (preg_match('/^(midcom|midgard)\./', $manifest->name)
54 54
                 && $manifest->name != 'midcom.helper.search') {
55 55
                 continue;
56 56
             }
Please login to merge, or discard this patch.
lib/net/nemein/wiki/parser.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
                 return $this->render_link($parts[1], $parts[2]) . $after;
224 224
 
225 225
             // Macro [something: <data>] (for example [abbr: BOFH - Bastard Operator From Hell] or [photo: <GUID>])
226
-            case (   preg_match('/^(.*?): (.*)/', $fulltext, $macro_parts)
226
+            case (preg_match('/^(.*?): (.*)/', $fulltext, $macro_parts)
227 227
                   && method_exists($this, "_run_macro_{$macro_parts[1]}")):
228 228
                 $method = "_run_macro_{$macro_parts[1]}";
229 229
                 return $this->$method($macro_parts[2], $match[0], $after);
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
                 $folder = $wikipage_match['latest_parent'];
257 257
             }
258 258
 
259
-            if (   isset($folder[MIDCOM_NAV_OBJECT])
259
+            if (isset($folder[MIDCOM_NAV_OBJECT])
260 260
                 && $folder[MIDCOM_NAV_OBJECT]->can_do('midgard:create')) {
261 261
                 $workflow = $this->get_workflow('datamanager');
262 262
                 return "<a href=\"{$folder[MIDCOM_NAV_ABSOLUTEURL]}create/?wikiword={$wikipage_match['remaining_path']}\" " . $workflow->render_attributes() . " class=\"wiki_missing\" title=\"" . $this->_l10n->get('click to create') . "\">{$text}</a>";
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
                     $links[$parts[1]] = $parts[2];
292 292
                 }
293 293
                 // Ignore macros [something: <data>] (for example [abbr: BOFH - Bastard Operator From Hell] or [photo: <GUID>])
294
-                elseif (   !preg_match('/^(.*?): (.*)/', $fulltext, $macro_parts)
294
+                elseif (!preg_match('/^(.*?): (.*)/', $fulltext, $macro_parts)
295 295
                         || !method_exists($this, "_run_macro_{$macro_parts[1]}")) {
296 296
                     // MediaWiki-style link [wikipage] (no text)
297 297
                     $links[$fulltext] = $fulltext;
Please login to merge, or discard this patch.