Passed
Push — master ( 9da2d4...b22c21 )
by Andreas
09:56
created
lib/midcom/services/uimessages.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -133,7 +133,7 @@
 block discarded – undo
133 133
      */
134 134
     public function show(bool $show_simple = false)
135 135
     {
136
-        if (   $show_simple
136
+        if ($show_simple
137 137
             || !midcom::get()->auth->can_user_do('midcom:ajax', class: static::class)) {
138 138
             $this->show_simple();
139 139
             return;
Please login to merge, or discard this patch.
lib/midcom/services/toolbars.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -272,7 +272,7 @@
 block discarded – undo
272 272
 
273 273
     private function add_head_elements(bool $centralized = false) : bool
274 274
     {
275
-        if (   !midcom::get()->auth->user
275
+        if (!midcom::get()->auth->user
276 276
             || !midcom::get()->config->get('toolbars_enable_centralized')
277 277
             || !midcom::get()->auth->can_user_do('midcom:centralized_toolbar', class: __CLASS__)) {
278 278
             return false;
Please login to merge, or discard this patch.
lib/org/openpsa/expenses/handler/index.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -103,7 +103,8 @@  discard block
 block discarded – undo
103 103
         foreach ($hours as $guid => $row) {
104 104
             try {
105 105
                 $task = org_openpsa_projects_task_dba::get_cached($row['task']);
106
-            } catch (midcom_error $e) {
106
+            }
107
+            catch (midcom_error $e) {
107 108
                 // Task couldn't be loaded, probably because of ACL
108 109
                 continue;
109 110
             }
@@ -116,7 +117,8 @@  discard block
 block discarded – undo
116 117
                     $person_object = midcom_db_person::get_cached($row['person']);
117 118
                     $person_label = $this->_get_list_link($person_object->name, person_id: $row['person']);
118 119
                     $person_name = $person_object->name;
119
-                } catch (midcom_error $e) {
120
+                }
121
+                catch (midcom_error $e) {
120 122
                     $person_label = $this->_l10n->get('no person');
121 123
                     $person_name = '';
122 124
                 }
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/handler/group/view.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
             ];
45 45
         }
46 46
 
47
-        if (   midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_contacts_person_dba::class)
47
+        if (midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_contacts_person_dba::class)
48 48
             && $this->group->can_do('midgard:create')) {
49 49
                 $buttons[] = $workflow->get_button($this->router->generate('person_new_group', ['guid' => $this->group->guid]), [
50 50
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('create person'),
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 
55 55
         $siteconfig = org_openpsa_core_siteconfig::get_instance();
56 56
         $user_url = $siteconfig->get_node_full_url('org.openpsa.user');
57
-        if (   $user_url
57
+        if ($user_url
58 58
             && midcom::get()->auth->can_user_do('org.openpsa.user:access', class: org_openpsa_user_interface::class)) {
59 59
             $buttons[] = [
60 60
                 MIDCOM_TOOLBAR_URL => $user_url . "group/{$this->group->guid}/",
Please login to merge, or discard this patch.
lib/org/openpsa/user/handler/person/view.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         $this->add_breadcrumb('', $person->get_label());
26 26
 
27 27
         $auth = midcom::get()->auth;
28
-        if (   $person->guid == midcom::get()->auth->user->guid
28
+        if ($person->guid == midcom::get()->auth->user->guid
29 29
             || $auth->can_user_do('org.openpsa.user:manage', class: org_openpsa_user_interface::class)) {
30 30
             $buttons = [];
31 31
             $workflow = $this->get_workflow('datamanager');
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
                 $delete_workflow = $this->get_workflow('delete', ['object' => $person]);
39 39
                 $buttons[] = $delete_workflow->get_button($this->router->generate('user_delete', ['guid' => $person->guid]));
40 40
             }
41
-            if (   $data['account']->get_username()
41
+            if ($data['account']->get_username()
42 42
                 && $person->can_do('midgard:privileges')) {
43 43
                 $buttons[] = $workflow->get_button($this->router->generate('user_privileges', ['guid' => $person->guid]), [
44 44
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get("permissions"),
Please login to merge, or discard this patch.
lib/org/openpsa/sales/handler/view.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         }
84 84
 
85 85
         if ($this->_config->get('sales_pdfbuilder_class')) {
86
-            if (   $this->_salesproject->can_do('midgard:update')
86
+            if ($this->_salesproject->can_do('midgard:update')
87 87
                 && $this->is_pdf_creatable()) {
88 88
                 $workflow = $this->get_workflow('datamanager');
89 89
                 $buttons[] = $workflow->get_button($this->router->generate('create_offer', ['guid' => $this->_salesproject->guid]), [
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
             case 'ordered':
205 205
                 if ($deliverable->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
206 206
                     $entries = $deliverable->get_at_entries();
207
-                    if (   $entries
207
+                    if ($entries
208 208
                         && $entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
209 209
                         && midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_invoices_invoice_dba::class)) {
210 210
                         return '<button class="run_cycle"><i class="fa fa-refresh"></i>' . $this->_l10n->get('generate now') . '</button>';
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
                 }
215 215
                 break;
216 216
             case 'delivered':
217
-                if (   $deliverable->orgOpenpsaObtype != org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
217
+                if ($deliverable->orgOpenpsaObtype != org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
218 218
                     && midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_invoices_invoice_dba::class)) {
219 219
                     $client_class = $this->_config->get('calculator');
220 220
                     $client = new $client_class();
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/textareaExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
      */
23 23
     public function configureOptions(OptionsResolver $resolver) : void
24 24
     {
25
-        $map_attr = function (Options $options, $value) {
25
+        $map_attr = function(Options $options, $value) {
26 26
             $value ??= [];
27 27
             $value['rows'] = $options['widget_config']['height'];
28 28
             $value['cols'] = $options['widget_config']['width'];
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/transformer/jsdateTransformer.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -33,8 +33,8 @@  discard block
 block discarded – undo
33 33
             }
34 34
         }
35 35
 
36
-        if (   empty($input)
37
-            || (   $input instanceof DateTime
36
+        if (empty($input)
37
+            || ($input instanceof DateTime
38 38
                 && $input->format('Y-m-d H:i:s') == '0001-01-01 00:00:00')) {
39 39
             return $result;
40 40
         }
@@ -59,8 +59,8 @@  discard block
 block discarded – undo
59 59
             throw new TransformationFailedException('Expected an array.');
60 60
         }
61 61
 
62
-        if (   empty($array['date'])
63
-            || (   $array['date'] instanceof DateTime
62
+        if (empty($array['date'])
63
+            || ($array['date'] instanceof DateTime
64 64
                 && $array['date']->format('Y-m-d H:i:s') == '0001-01-01 00:00:00')) {
65 65
             return null;
66 66
         }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/transformer/multipleTransformer.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
                     return [];
55 55
                 }
56 56
                 $results = explode($this->multiple_separator, substr($input, 1, -1));
57
-                if (   !empty($this->config['widget_config']['id_field'])
57
+                if (!empty($this->config['widget_config']['id_field'])
58 58
                     && $this->config['widget_config']['id_field'] == 'id') {
59 59
                     $results = array_map('intval', $results);
60 60
                 }
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
     public function reverseTransform(mixed $array) : mixed
69 69
     {
70
-        if (!is_array($array) ) {
70
+        if (!is_array($array)) {
71 71
             throw new TransformationFailedException('Expected an array.');
72 72
         }
73 73
 
Please login to merge, or discard this patch.