flack / openpsa

lib/org/openpsa/documents/handler/document/admin.php

Spacing +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
 
         $this->_controller = $this->load_controller();
 
-        if (   $data['enable_versioning']
+        if ($data['enable_versioning']
             && $request->request->count() > 0) {
             $this->_backup_attachment($request);
         }

lib/org/openpsa/core/queryfilter.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
         $user = midcom::get()->auth->user->get_storage();
 
         if ($request->request->get('unset_filter') == $filter_id) {
-            if (   $user->get_parameter("org_openpsa_core_filter", $filter_id)
+            if ($user->get_parameter("org_openpsa_core_filter", $filter_id)
                 && !$user->delete_parameter("org_openpsa_core_filter", $filter_id)) {
                 $message_content = sprintf(
                     $l10n->get('the handed filter for %s could not be set as parameter'),

src/midcom/console/command/cleanup/privileges.php

Braces +2 added lines, -1 removed lines

@@ -50,7 +50,8 @@
                 try {
                     \midgard_object_class::get_object_by_guid($priv->objectguid);
                     $seen_parents[$priv->objectguid] = true;
-                } catch (\Exception $e) {
+                }
+                catch (\Exception $e) {
                     $seen_parents[$priv->objectguid] = false;
                 }
             }

lib/org/openpsa/user/handler/person/account.php

Spacing +3 added lines, -3 removed lines

@@ -44,7 +44,7 @@ 
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
         $response = $workflow->run($request);
 
-        if (   $workflow->get_state() == 'save'
+        if ($workflow->get_state() == 'save'
             && $this->create_account($this->person, $data["controller"]->get_form_values())) {
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), sprintf($this->_l10n->get('person %s created'), $this->person->name));
         }
@@ -77,7 +77,7 @@ 
         $person = new midcom_db_person($guid);
         $accounthelper = new org_openpsa_user_accounthelper($person);
         if ($accounthelper->welcome_email()) {
-            midcom::get()->uimessages->add($this->_l10n->get($this->_component), sprintf($this->_l10n->get('password reset and mail to %s sent'), $person->email ));
+            midcom::get()->uimessages->add($this->_l10n->get($this->_component), sprintf($this->_l10n->get('password reset and mail to %s sent'), $person->email));
         } else {
             midcom::get()->uimessages->add($this->_l10n->get($this->_component), $accounthelper->errstr, 'error');
         }
@@ -133,7 +133,7 @@ 
         $accounthelper = new org_openpsa_user_accounthelper($this->person);
 
         // Update account
-        if (   !$accounthelper->set_account($controller->get_form_values()["username"], $password)
+        if (!$accounthelper->set_account($controller->get_form_values()["username"], $password)
             && midcom_connection::get_error() != MGD_ERR_OK) {
             // Failure, give a message
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get("failed to update the user account, reason") . ': ' . midcom_connection::get_error_string(), 'error');

lib/org/openpsa/directmarketing/campaign/ruleresolver.php

Spacing +2 added lines, -2 removed lines

@@ -270,7 +270,7 @@ 
      */
     private function add_misc_rule(array $rule, string $class, string $person_property)
     {
-        $persons = [ 0 => -1];
+        $persons = [0 => -1];
         $match = $rule['match'];
         $constraint_match = "IN";
         if ($rule['match'] == '<>') {
@@ -342,7 +342,7 @@ 
         $ret = [];
 
         foreach ($object->get_properties() as $property) {
-            if (   $property[0] == '_'
+            if ($property[0] == '_'
                 || in_array($property, $skip_properties)) {
                 // Skip private or otherwise invalid properties
                 continue;

Braces +4 added lines, -2 removed lines

@@ -110,7 +110,8 @@ 
         try {
             $this->process_classes($rules['classes'], $rules['type']);
             return true;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return false;
         }
@@ -225,7 +226,8 @@ 
             $guid = $mc_parameter->get_subkey($parameter_key, 'parentguid');
             try {
                 $parent = midcom::get()->dbfactory->get_object_by_guid($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
                 continue;
             }

lib/midcom/core/query.php

Spacing +2 added lines, -2 removed lines

@@ -102,7 +102,7 @@ 
             $this->_user_id = midcom::get()->auth->acl->get_user_id();
         }
 
-        if (   $this->hide_invisible
+        if ($this->hide_invisible
             && !$this->_visibility_checks_added) {
             if (!midcom::get()->config->get('show_hidden_objects')) {
                 $this->add_constraint('metadata.hidden', '=', false);
@@ -168,7 +168,7 @@ 
         // Deal with empty arrays, which would produce invalid queries
         // This is done here to avoid repetitive code in callers, and because
         // it's easy enough to generalize: IN empty set => always false, NOT IN empty set => always true
-        if (   is_array($value)
+        if (is_array($value)
             && empty($value)) {
             if ($operator == 'NOT IN') {
                 return;

lib/midcom/baseclasses/components/handler/dataexport.php

Spacing +5 added lines, -5 removed lines

@@ -108,7 +108,7 @@ 
         foreach ($this->_datamanagers as $type => $datamanager) {
             foreach ($datamanager->get_schema($this->schemas[$type])->get('fields') as $name => $config) {
                 $title = $config['title'];
-                if (   $this->include_totals
+                if ($this->include_totals
                     && $config['type'] == 'number') {
                     $this->_totals[$type . '-' . $name] = 0;
                 }
@@ -172,18 +172,18 @@ 
                     $data = array_pad($data, $target_size, '');
                     continue;
                 }
-                $object =& $row[$type];
+                $object = & $row[$type];
 
                 $datamanager->set_storage($object, $this->schemas[$type]);
 
-                if (   $this->include_guid
+                if ($this->include_guid
                     && $type == $first_type) {
                     $data[] = $object->guid;
                 }
 
                 $csvdata = $datamanager->get_content_csv();
                 foreach ($datamanager->get_schema()->get('fields') as $fieldname => $config) {
-                    if (   $this->include_totals
+                    if ($this->include_totals
                         && $config['type'] == 'number') {
                         $this->_totals[$type . '-' . $fieldname] += $csvdata[$fieldname];
                     }
@@ -211,7 +211,7 @@ 
         if (empty($this->csv['charset'])) {
             // Default to ISO-LATIN-15 (Latin-1 with EURO sign etc)
             $this->csv['charset'] = 'ISO-8859-15';
-            if (   $request->server->has('HTTP_USER_AGENT')
+            if ($request->server->has('HTTP_USER_AGENT')
                 && !preg_match('/Windows/i', $request->server->get('HTTP_USER_AGENT'))) {
                 // Except when not on windows, then default to UTF-8
                 $this->csv['charset'] = 'UTF-8';

lib/midcom/helper/reflector/nameresolver.php

Spacing +3 added lines, -3 removed lines

@@ -32,7 +32,7 @@ 
     public function get_object_name(string $name_property = null) : ?string
     {
         $name_property ??= midcom_helper_reflector::get_name_property($this->_object);
-        if (    empty($name_property)
+        if (empty($name_property)
             || !midcom_helper_reflector::get($this->_object)->property_exists($name_property)) {
             // Could not resolve valid property
             return null;
@@ -124,7 +124,7 @@ 
 
             $qb->add_constraint($child_name_property, '=', $name);
             if ($qb->count()) {
-                debug_add("Name clash in sibling class {$schema_type} for " . get_class($this->_object) . " #{$this->_object->id} (path '" . midcom_helper_reflector_tree::resolve_path($this->_object, '/') . "')" );
+                debug_add("Name clash in sibling class {$schema_type} for " . get_class($this->_object) . " #{$this->_object->id} (path '" . midcom_helper_reflector_tree::resolve_path($this->_object, '/') . "')");
                 return false;
             }
         }
@@ -199,7 +199,7 @@ 
         } while (!$this->name_is_unique());
 
         // Get a copy of the current, usable name
-        $ret = (string)$this->_object->{$name_prop};
+        $ret = (string) $this->_object->{$name_prop};
         // Restore the original name
         $this->_object->{$name_prop} = $original_name;
         return $ret;

src/midcom/datamanager/extension/type/codemirrorType.php

Spacing +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@ 
      */
     public function configureOptions(OptionsResolver $resolver)
     {
-        $map_attr = function (Options $options, $value) {
+        $map_attr = function(Options $options, $value) {
             $value ??= [];
             $value['class'] = $options['widget_config']['enabled'] ? 'codemirror ' . $options['widget_config']['language'] : 'longtext';
 
@@ -44,7 +44,7 @@ 
             ]
         ]);
 
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
             if ($options['dm2_type'] == 'php') {
                 $value[] = new php;
             }