Passed
Push — master ( 9da2d4...b22c21 )
by Andreas
09:56
created
src/midcom/console/command/repligard.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
     private function _confirm(InputInterface $input, OutputInterface $output) : bool
101 101
     {
102 102
         $options = [true => 'y', false => 'N'];
103
-        $question = '<question>Delete all rows? [' . implode('|', $options). ']</question> ';
103
+        $question = '<question>Delete all rows? [' . implode('|', $options) . ']</question> ';
104 104
         $question = new ConfirmationQuestion($question, false);
105 105
         $dialog = $this->getHelperSet()->get('question');
106 106
         return $dialog->ask($input, $output, $question);
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,8 @@
 block discarded – undo
37 37
     {
38 38
         try {
39 39
             $this->db = connection::get_em()->getConnection()->getNativeConnection();
40
-        } catch (\Exception $e) {
40
+        }
41
+        catch (\Exception $e) {
41 42
             $this->db = $this->create_connection($input, $output);
42 43
         }
43 44
 
Please login to merge, or discard this patch.
src/midcom/datamanager/template/form.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
     public function form_end(FormView $view, array $data)
85 85
     {
86 86
         $string = '';
87
-        if (   !isset($data['render_rest'])
87
+        if (!isset($data['render_rest'])
88 88
             || $data['render_rest']) {
89 89
             $string .= $this->renderer->rest($view);
90 90
         }
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
             $data['attr']['class'] = 'shorttext';
224 224
         }
225 225
 
226
-        if (   !empty($data['value'])
226
+        if (!empty($data['value'])
227 227
             || is_numeric($data['value'])) {
228 228
             $data['attr']['value'] = $data['value'];
229 229
         }
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
     {
266 266
         if ($view->vars['readonly']) {
267 267
             $string = $this->get_view_renderer()->autocomplete_widget($view, $data);
268
-            return $string .  $this->renderer->widget($view['selection']);
268
+            return $string . $this->renderer->widget($view['selection']);
269 269
         }
270 270
 
271 271
         autocomplete::add_head_elements($data['handler_options']['creation_mode_enabled'], $data['handler_options']['sortable']);
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
         $jsinit .= "midcom_helper_datamanager2_autocomplete.create_dm2_widget('{$element_id}_search_input', {$data['min_chars']});\n";
276 276
 
277 277
         $string = '<fieldset ' . $this->renderer->block($view, 'widget_container_attributes') . '>';
278
-        $string .=  $this->renderer->widget($view['selection']);
278
+        $string .= $this->renderer->widget($view['selection']);
279 279
         $string .= ' ' . $this->renderer->widget($view['search_input']);
280 280
         $string .= '</fieldset>';
281 281
         return $string . $this->jsinit($jsinit);
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
         }
325 325
 
326 326
         $string = '<select ';
327
-        if (   $data['required']
327
+        if ($data['required']
328 328
             && null === $data['placeholder']
329 329
             && $data['placeholder_in_choices'] === false
330 330
             && $data['multiple'] === false) {
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
         $string .= $this->renderer->block($view, 'widget_attributes', $data) . '>';
339 339
         if (null !== $data['placeholder']) {
340 340
             $string .= '<option value=""';
341
-            if (   $data['required']
341
+            if ($data['required']
342 342
                 && empty($data['value'])
343 343
                 && "0" !== $data['value']) {
344 344
                 $string .= ' selected="selected"';
@@ -500,7 +500,7 @@  discard block
 block discarded – undo
500 500
             $string .= '<label class="midcom_datamanager_photo_label">' . $this->renderer->humanize('delete photo') . ' ' . $this->renderer->widget($data['form']['delete']) . '</label>';
501 501
             $string .= '<ul>';
502 502
             foreach ($objects as $info) {
503
-                if (   $info['size_x']
503
+                if ($info['size_x']
504 504
                     && $info['size_y']) {
505 505
                     $size = "{$info['size_x']}&times;{$info['size_y']}";
506 506
                 } else {
@@ -525,7 +525,7 @@  discard block
 block discarded – undo
525 525
         $string .= '</td></tr></table></div>';
526 526
         $string .= $this->renderer->row($data['form']['identifier']);
527 527
 
528
-        return $string . $this->jsinit('init_image_widget("' . $view->vars['id'] .'");');
528
+        return $string . $this->jsinit('init_image_widget("' . $view->vars['id'] . '");');
529 529
     }
530 530
 
531 531
     public function subform_widget(FormView $view, array $data)
Please login to merge, or discard this patch.
lib/org/openpsa/user/style/show-person-account.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
             echo '<span class="toolbar_label">' . $data['l10n_midcom']->get('delete') . '</span></a></li>';
24 24
             if (    midcom::get()->config->get('auth_allow_trusted') === true
25 25
                  && $data['person']->can_do('org.openpsa.user:su')) {
26
-                 echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '">' . $data['l10n']->get('switch to user') . "</a></li>\n";
26
+                    echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '">' . $data['l10n']->get('switch to user') . "</a></li>\n";
27 27
             }
28 28
             echo "</ul>\n";
29 29
         }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
             echo '<p>' . sprintf($data['l10n']->get('account blocked %s minutes'), $data['config']->get('password_block_timeframe_min')) . '</p>';
17 17
         }
18 18
 
19
-        if (   $data['person']->guid == midcom::get()->auth->user->guid
19
+        if ($data['person']->guid == midcom::get()->auth->user->guid
20 20
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', class: org_openpsa_user_interface::class)) {
21 21
             $workflow = new midcom\workflow\datamanager;
22 22
             echo '<ul class="area_toolbar">';
@@ -25,9 +25,9 @@  discard block
 block discarded – undo
25 25
                 'object' => $data['person'],
26 26
                 'label' => $data['l10n']->get('account')
27 27
             ]);
28
-            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]). '" ' . $workflow->render_attributes() . ' class="button">';
28
+            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]) . '" ' . $workflow->render_attributes() . ' class="button">';
29 29
             echo '<span class="toolbar_label">' . $data['l10n_midcom']->get('delete') . '</span></a></li>';
30
-            if (    midcom::get()->config->get('auth_allow_trusted') === true
30
+            if (midcom::get()->config->get('auth_allow_trusted') === true
31 31
                  && $data['person']->can_do('org.openpsa.user:su')) {
32 32
                  echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '">' . $data['l10n']->get('switch to user') . "</a></li>\n";
33 33
             }
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         }
36 36
     } else {
37 37
         echo '<p><span class="metadata">' . $data['l10n']->get("no account") . '</span></p>';
38
-        if (   $data['person']->guid == midcom::get()->auth->user->guid
38
+        if ($data['person']->guid == midcom::get()->auth->user->guid
39 39
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', class: org_openpsa_user_interface::class)) {
40 40
             $workflow = new midcom\workflow\datamanager;
41 41
             echo '<ul class="area_toolbar">';
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/tinymceType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,11 +34,11 @@
 block discarded – undo
34 34
      */
35 35
     public function configureOptions(OptionsResolver $resolver)
36 36
     {
37
-        $resolver->setDefault('config', function (Options $options) {
37
+        $resolver->setDefault('config', function(Options $options) {
38 38
             return \midcom_baseclasses_components_configuration::get('midcom.datamanager', 'config');
39 39
         });
40 40
 
41
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
41
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
42 42
             $widget_defaults = [
43 43
                 'height' => 25,
44 44
                 'width' => 80,
Please login to merge, or discard this patch.
lib/org/openpsa/widgets/contact.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -113,7 +113,8 @@  discard block
 block discarded – undo
113 113
 
114 114
         try {
115 115
             $person = midcom_db_person::get_cached($src);
116
-        } catch (midcom_error $e) {
116
+        }
117
+        catch (midcom_error $e) {
117 118
             return $cache[$src] = new self(new midcom_db_person);
118 119
         }
119 120
 
@@ -313,7 +314,8 @@  discard block
 block discarded – undo
313 314
         foreach ($mc->get_rows(['gid', 'extra']) as $data) {
314 315
             try {
315 316
                 $group = org_openpsa_contacts_group_dba::get_cached($data['gid']);
316
-            } catch (midcom_error $e) {
317
+            }
318
+            catch (midcom_error $e) {
317 319
                 $e->log();
318 320
                 continue;
319 321
             }
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     /**
94 94
      * Retrieve an object, uses in-request caching
95 95
      */
96
-    public static function get(string|int $src) : self
96
+    public static function get(string | int $src) : self
97 97
     {
98 98
         static $cache = [];
99 99
 
@@ -136,12 +136,12 @@  discard block
 block discarded – undo
136 136
             }
137 137
         }
138 138
 
139
-        if (   $this->_config->get('jabber_enable_presence')
139
+        if ($this->_config->get('jabber_enable_presence')
140 140
             && $person->get_parameter('org.openpsa.jabber', 'jid')) {
141 141
             $this->contact_details['jid'] = $person->get_parameter('org.openpsa.jabber', 'jid');
142 142
         }
143 143
 
144
-        if (   $this->_config->get('skype_enable_presence')
144
+        if ($this->_config->get('skype_enable_presence')
145 145
             && $person->get_parameter('org.openpsa.skype', 'name')) {
146 146
             $this->contact_details['skype'] = $person->get_parameter('org.openpsa.skype', 'name');
147 147
         }
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
         if (!empty($attachments[$type])) {
179 179
             return '<img class="photo" src="' . midcom_db_attachment::get_url($attachments[$type]) . '">';
180 180
         }
181
-        if (   $this->_config->get('gravatar_enable')
181
+        if ($this->_config->get('gravatar_enable')
182 182
             && !empty($this->contact_details['email'])) {
183 183
             $size = ($type == 'view') ? 500 : 32;
184 184
             $gravatar_url = "https://www.gravatar.com/avatar/" . md5(strtolower(trim($this->contact_details['email']))) . "?s=" . $size . '&d=identicon';
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
 
292 292
     private function _show_groups()
293 293
     {
294
-        if (   !$this->show_groups
294
+        if (!$this->show_groups
295 295
             || empty($this->contact_details['id'])) {
296 296
             return;
297 297
         }
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
                     $default_shown = true;
356 356
                     $cards_to_show[] = $cardname;
357 357
                 }
358
-            } elseif (    $customer->$property
358
+            } elseif ($customer->$property
359 359
                       || ($customer->street && !$inherited_cards_only && !$default_shown)) {
360 360
                 $inherited_cards_only = false;
361 361
                 $multiple_addresses = true;
@@ -377,8 +377,8 @@  discard block
 block discarded – undo
377 377
 
378 378
         foreach ($cards_to_show as $cardname) {
379 379
             echo '<div class="vcard">';
380
-            if (   $multiple_addresses
381
-                || (   $cardname != 'visiting'
380
+            if ($multiple_addresses
381
+                || ($cardname != 'visiting'
382 382
                     && !$inherited_cards_only)) {
383 383
                 echo '<div style="text-align:center"><em>' . midcom::get()->i18n->get_string($cardname . ' address', 'org.openpsa.contacts') . "</em></div>\n";
384 384
             }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/style/ASGARD_ROOT.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
 
128 128
                             $edited = (int) $view_metadata->get('revised');
129 129
                             $revision = $view_metadata->get('revision');
130
-                            if (   $revision > 0
130
+                            if ($revision > 0
131 131
                                 && $edited != $created) {
132 132
                                 try {
133 133
                                     $editor = new midcom_db_person($view_metadata->get('revisor'));
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -119,7 +119,8 @@  discard block
 block discarded – undo
119 119
                             try {
120 120
                                 $creator = new midcom_db_person($view_metadata->get('creator'));
121 121
                                 $creator_string = "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/view/{$creator->guid}/\">$creator->name</a>";
122
-                            } catch (midcom_error $e) {
122
+                            }
123
+                            catch (midcom_error $e) {
123 124
                                 $creator_string = $l10n->get('unknown person');
124 125
                             }
125 126
                             $formatter = $data['l10n']->get_formatter();
@@ -133,7 +134,8 @@  discard block
 block discarded – undo
133 134
                                 try {
134 135
                                     $editor = new midcom_db_person($view_metadata->get('revisor'));
135 136
                                     $editor_string = "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/view/{$editor->guid}/\">$editor->name</a>";
136
-                                } catch (midcom_error $e) {
137
+                                }
138
+                                catch (midcom_error $e) {
137 139
                                     $editor_string = $l10n->get('unknown person');
138 140
                                 }
139 141
 
Please login to merge, or discard this patch.
lib/org/openpsa/mail/main.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
  */
40 40
 class org_openpsa_mail
41 41
 {
42
-    use midcom_baseclasses_components_base {__get as base__get;}
42
+    use midcom_baseclasses_components_base {__get as base__get; }
43 43
 
44 44
     /**
45 45
      * Text body
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 {
16 16
     public function get_url(midcom_db_article $article, bool $allow_external = false) : string
17 17
     {
18
-        if (   $allow_external
18
+        if ($allow_external
19 19
             && $this->_config->get('link_to_external_url')
20 20
             && !empty($article->url)) {
21 21
             return $article->url;
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
         $qb->add_constraint('topic.guid', 'IN', $topic_guids);
69 69
 
70
-        if (   count($topic_guids) > 1
70
+        if (count($topic_guids) > 1
71 71
             && $list_from_folders_categories = $this->_config->get('list_from_folders_categories')) {
72 72
             $list_from_folders_categories = explode(',', $list_from_folders_categories);
73 73
 
Please login to merge, or discard this patch.
lib/net/nemein/tag/handler.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -381,7 +381,8 @@  discard block
 block discarded – undo
381 381
             try {
382 382
                 $tag = net_nemein_tag_tag_dba::get_cached($link->tag);
383 383
                 $link_object_map[$link->fromGuid][$tag->tag] = $link;
384
-            } catch (midcom_error $e) {
384
+            }
385
+            catch (midcom_error $e) {
385 386
                 $e->log();
386 387
             }
387 388
         }
@@ -410,7 +411,8 @@  discard block
 block discarded – undo
410 411
                     $tmpobject = midcom::get()->dbfactory->convert_midgard_to_midcom($tmpobject);
411 412
                 }
412 413
                 $return[] = $tmpobject;
413
-            } catch (midcom_error $e) {
414
+            }
415
+            catch (midcom_error $e) {
414 416
                 $e->log();
415 417
             }
416 418
         }
Please login to merge, or discard this patch.