Passed
Push — master ( 9da2d4...b22c21 )
by Andreas
09:56
created
lib/midcom/admin/help/help.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -179,9 +179,9 @@  discard block
 block discarded – undo
179 179
         $files = [];
180 180
         $pattern = $component_dir . '*.{' . $this->_i18n->get_current_language() . ',' . $this->_i18n->get_fallback_language() . '}.txt';
181 181
 
182
-        foreach (glob($pattern, GLOB_NOSORT|GLOB_BRACE) as $path) {
182
+        foreach (glob($pattern, GLOB_NOSORT | GLOB_BRACE) as $path) {
183 183
             $entry = basename($path);
184
-            if (   str_starts_with($entry, 'index')
184
+            if (str_starts_with($entry, 'index')
185 185
                 || str_starts_with($entry, 'handler')
186 186
                 || str_starts_with($entry, 'urlmethod')) {
187 187
                 // Ignore dotfiles, handlers & index.lang.txt
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
         $data = [];
233 233
 
234 234
         $exec_path = midcom::get()->componentloader->path_to_snippetpath($component) . '/exec/';
235
-        if (   !is_dir($exec_path)
235
+        if (!is_dir($exec_path)
236 236
             || !is_readable($exec_path)) {
237 237
             // Directory not accessible, skip loading it
238 238
             return $data;
Please login to merge, or discard this patch.
lib/midcom/helper/_dbfactory.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,8 @@  discard block
 block discarded – undo
43 43
     {
44 44
         try {
45 45
             $tmp = midgard_object_class::get_object_by_guid($guid);
46
-        } catch (mgd_exception $e) {
46
+        }
47
+        catch (mgd_exception $e) {
47 48
             debug_add('Loading object by GUID ' . $guid . ' failed, reason: ' . $e->getMessage(), MIDCOM_LOG_INFO);
48 49
 
49 50
             throw new midcom_error_midgard($e, $guid);
@@ -163,7 +164,8 @@  discard block
 block discarded – undo
163 164
 
164 165
         try {
165 166
             return $this->get_cached($classname, $parent_guid);
166
-        } catch (midcom_error $e) {
167
+        }
168
+        catch (midcom_error $e) {
167 169
             return null;
168 170
         }
169 171
     }
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 
56 56
             throw new midcom_error_midgard($e, $guid);
57 57
         }
58
-        if (   get_class($tmp) == 'midgard_person'
58
+        if (get_class($tmp) == 'midgard_person'
59 59
             && $this->person_class != 'midgard_person') {
60 60
             $tmp = new $this->person_class($guid);
61 61
         }
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
      *
68 68
      * @param string $classname Which DBA are we dealing with
69 69
      */
70
-    public function get_cached(string $classname, string|int $src) : midcom_core_dbaobject
70
+    public function get_cached(string $classname, string | int $src) : midcom_core_dbaobject
71 71
     {
72 72
         static $cache = [];
73 73
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
         }
85 85
         $object = new $classname($src);
86 86
         $cache[$classname][$object->guid] = $object;
87
-        $cache[$classname][$object->id] =& $cache[$classname][$object->guid];
87
+        $cache[$classname][$object->id] = & $cache[$classname][$object->guid];
88 88
         return $cache[$classname][$object->guid];
89 89
     }
90 90
 
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
             return true;
132 132
         }
133 133
 
134
-        if (   isset($object->__object)
134
+        if (isset($object->__object)
135 135
             && is_object($object->__object)
136 136
             && $object->__object instanceof $class) {
137 137
             // Decorator whose MgdSchema object matches
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
             return $this->get_parent_data_uncached($object);
155 155
         });
156 156
 
157
-        if (   empty($parent_guid)
157
+        if (empty($parent_guid)
158 158
             || $parent_guid === $object->guid) {
159 159
             return null;
160 160
         }
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/event.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
         }
142 142
 
143 143
         //Check up
144
-        if (   !$this->up
144
+        if (!$this->up
145 145
             && $this->title != '__org_openpsa_calendar') {
146 146
             $root_event = org_openpsa_calendar_interface::find_root_event();
147 147
             $this->up = $root_event->id;
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 
167 167
     private function _check_timerange() : bool
168 168
     {
169
-        if (   !$this->start
169
+        if (!$this->start
170 170
             || !$this->end) {
171 171
             debug_add('Event must have start and end timestamps');
172 172
             midcom_connection::set_error(MGD_ERR_RANGE);
Please login to merge, or discard this patch.
lib/net/nemein/wiki/handler/view.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -202,9 +202,9 @@
 block discarded – undo
202 202
         $toc .= "\n<ol class=\"midcom_helper_toc_formatter level_{$current_list_level}\">\n";
203 203
         foreach ($headings[4] as $key => $heading) {
204 204
             $anchor = 'heading-' . md5($heading);
205
-            $tag_level =& $headings[3][$key];
206
-            $heading_code =& $headings[0][$key];
207
-            $heading_tag =& $headings[2][$key];
205
+            $tag_level = & $headings[3][$key];
206
+            $heading_code = & $headings[0][$key];
207
+            $heading_tag = & $headings[2][$key];
208 208
             $heading_new_code = "<a id='{$anchor}'></a>{$heading_code}";
209 209
             $content = str_replace($heading_code, $heading_new_code, $content);
210 210
             if ($current_tag_level === false) {
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/handler/person/view.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -192,7 +192,8 @@
 block discarded – undo
192 192
         foreach ($this->$identifier as $member) {
193 193
             try {
194 194
                 $this->_request_data['group'] = org_openpsa_contacts_group_dba::get_cached($member->gid);
195
-            } catch (midcom_error $e) {
195
+            }
196
+            catch (midcom_error $e) {
196 197
                 $e->log();
197 198
                 continue;
198 199
             }
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
         $invoices_url = $siteconfig->get_node_full_url('org.openpsa.invoices');
100 100
         $user_url = $siteconfig->get_node_full_url('org.openpsa.user');
101 101
 
102
-        if (   $invoices_url
102
+        if ($invoices_url
103 103
             && midcom::get()->auth->can_user_do('midgard:create', class: org_openpsa_invoices_invoice_dba::class)
104 104
             && $this->_contact->can_do('midgard:update')) {
105 105
             $buttons[] = $workflow->get_button($invoices_url . "billingdata/" . $this->_contact->guid . '/', [
@@ -108,8 +108,8 @@  discard block
 block discarded – undo
108 108
             ]);
109 109
         }
110 110
 
111
-        if (   $user_url
112
-            && (   midcom::get()->auth->user->guid == $this->_contact->guid
111
+        if ($user_url
112
+            && (midcom::get()->auth->user->guid == $this->_contact->guid
113 113
                 || midcom::get()->auth->can_user_do('org.openpsa.user:access', class: org_openpsa_user_interface::class))) {
114 114
             $buttons[] = [
115 115
                 MIDCOM_TOOLBAR_URL => $user_url . "view/{$this->_contact->guid}/",
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/message/send.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
     {
115 115
         $nap = new midcom_helper_nav();
116 116
         $node = $nap->get_node($nap->get_current_node());
117
-        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid .'/';
117
+        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid . '/';
118 118
         $this->batch_url_base_full = $node[MIDCOM_NAV_RELATIVEURL] . 'message/send_bg/' . $data['message']->guid . '/';
119 119
         debug_add("compose_url: {$compose_url}");
120 120
         debug_add("batch_url base: {$this->batch_url_base_full}");
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/person.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 
60 60
     public function __set($name, $value)
61 61
     {
62
-        if (   $name == 'homepage'
62
+        if ($name == 'homepage'
63 63
             && !empty($value)
64 64
             && $value != $this->homepage) {
65 65
             $this->_register_prober = true;
Please login to merge, or discard this patch.
src/midcom/templating/dbloader.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,8 @@
 block discarded – undo
51 51
                 if ($root_topic->style) {
52 52
                     $scope = midcom_db_style::id_from_path($root_topic->style);
53 53
                 }
54
-            } catch (midcom_error_forbidden $e) {
54
+            }
55
+            catch (midcom_error_forbidden $e) {
55 56
                 $e->log();
56 57
             }
57 58
         }
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/view.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
             ]);
49 49
         }
50 50
 
51
-        if (   $this->_article->topic === $this->_topic->id
51
+        if ($this->_article->topic === $this->_topic->id
52 52
             && $this->_article->can_do('midgard:delete')) {
53 53
             $delete = $this->get_workflow('delete', ['object' => $this->_article]);
54 54
             $buttons[] = $delete->get_button("delete/{$this->_article->guid}/");
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         if ($this->_config->get('comments_enable')) {
84 84
             if ($node = net_nehmer_comments_interface::get_node($this->_topic, $this->_config->get('comments_topic'))) {
85 85
                 $data['comments_url'] = $node[MIDCOM_NAV_RELATIVEURL] . "comment/{$this->_article->guid}";
86
-                if (   $this->_topic->can_do('midgard:update')
86
+                if ($this->_topic->can_do('midgard:update')
87 87
                     && $this->_topic->can_do('net.nehmer.comments:moderation')) {
88 88
                     net_nehmer_comments_viewer::add_head_elements();
89 89
                 }
Please login to merge, or discard this patch.